From 42b47f907bbc1fdbdf145a886845d25ceab2f7f4 Mon Sep 17 00:00:00 2001 From: kaiyou <dev@kaiyou.fr> Date: Mon, 9 Oct 2023 20:36:46 +0200 Subject: [PATCH] Do not disable post start hooks anymore Removing them does not improve performance significatively, plus basic roles are actually needed for proper API authorizations on non resource endpoints --- services/apiserver.go | 8 -------- 1 file changed, 8 deletions(-) diff --git a/services/apiserver.go b/services/apiserver.go index 289ab5f..002b466 100644 --- a/services/apiserver.go +++ b/services/apiserver.go @@ -154,14 +154,6 @@ func buildConfig(c *Cluster) (config *server.Config, clients *k8s.Clients, err e sets.NewString("attach", "exec", "proxy", "log", "portforward"), ) - // Disable unneeded post start hooks, these cannot be easily disabled except at runtime, which still takes up - // space in the binary sadly - config.DisabledPostStartHooks = sets.NewString( - "storage-object-count-tracker-hook", // unused - "start-legacy-token-tracking-controller", // legacy and unused - "rbac/bootstrap-roles", // TODO replaced with our own simpler RBAC - ) - // Setup listener // TODO listen on management interface only, this is temporary so that the api is reachable on // localhost -- GitLab