From 24ef8255b3f9b44cb54f49bc78fe3382a7070b1a Mon Sep 17 00:00:00 2001
From: Eugen Rochko <eugen@zeonfederated.com>
Date: Thu, 12 Sep 2024 14:54:16 +0200
Subject: [PATCH] Change design of embed modal in web UI (#31801)
---
.../mastodon/components/copy_paste_text.tsx | 90 ++++++++++++++
.../mastodon/components/status_action_bar.jsx | 2 +-
.../mastodon/containers/status_container.jsx | 6 +-
.../mastodon/features/onboarding/share.jsx | 63 +---------
.../features/status/components/action_bar.jsx | 2 +-
.../features/ui/components/embed_modal.jsx | 101 ---------------
.../features/ui/components/embed_modal.tsx | 116 ++++++++++++++++++
app/javascript/mastodon/locales/en.json | 2 +-
.../styles/mastodon/components.scss | 111 ++++++++---------
app/serializers/oembed_serializer.rb | 17 ++-
app/views/layouts/embedded.html.haml | 2 +-
.../initializers/content_security_policy.rb | 11 +-
12 files changed, 278 insertions(+), 245 deletions(-)
create mode 100644 app/javascript/mastodon/components/copy_paste_text.tsx
delete mode 100644 app/javascript/mastodon/features/ui/components/embed_modal.jsx
create mode 100644 app/javascript/mastodon/features/ui/components/embed_modal.tsx
diff --git a/app/javascript/mastodon/components/copy_paste_text.tsx b/app/javascript/mastodon/components/copy_paste_text.tsx
new file mode 100644
index 0000000000..f888acd0f7
--- /dev/null
+++ b/app/javascript/mastodon/components/copy_paste_text.tsx
@@ -0,0 +1,90 @@
+import { useRef, useState, useCallback } from 'react';
+
+import { FormattedMessage } from 'react-intl';
+
+import classNames from 'classnames';
+
+import ContentCopyIcon from '@/material-icons/400-24px/content_copy.svg?react';
+import { useTimeout } from 'mastodon/../hooks/useTimeout';
+import { Icon } from 'mastodon/components/icon';
+
+export const CopyPasteText: React.FC<{ value: string }> = ({ value }) => {
+ const inputRef = useRef<HTMLTextAreaElement>(null);
+ const [copied, setCopied] = useState(false);
+ const [focused, setFocused] = useState(false);
+ const [setAnimationTimeout] = useTimeout();
+
+ const handleInputClick = useCallback(() => {
+ setCopied(false);
+
+ if (inputRef.current) {
+ inputRef.current.focus();
+ inputRef.current.select();
+ inputRef.current.setSelectionRange(0, value.length);
+ }
+ }, [setCopied, value]);
+
+ const handleButtonClick = useCallback(
+ (e: React.MouseEvent) => {
+ e.stopPropagation();
+ void navigator.clipboard.writeText(value);
+ inputRef.current?.blur();
+ setCopied(true);
+ setAnimationTimeout(() => {
+ setCopied(false);
+ }, 700);
+ },
+ [setCopied, setAnimationTimeout, value],
+ );
+
+ const handleKeyUp = useCallback(
+ (e: React.KeyboardEvent) => {
+ if (e.key !== ' ') return;
+ void navigator.clipboard.writeText(value);
+ setCopied(true);
+ setAnimationTimeout(() => {
+ setCopied(false);
+ }, 700);
+ },
+ [setCopied, setAnimationTimeout, value],
+ );
+
+ const handleFocus = useCallback(() => {
+ setFocused(true);
+ }, [setFocused]);
+
+ const handleBlur = useCallback(() => {
+ setFocused(false);
+ }, [setFocused]);
+
+ return (
+ <div
+ className={classNames('copy-paste-text', { copied, focused })}
+ tabIndex={0}
+ role='button'
+ onClick={handleInputClick}
+ onKeyUp={handleKeyUp}
+ >
+ <textarea
+ readOnly
+ value={value}
+ ref={inputRef}
+ onClick={handleInputClick}
+ onFocus={handleFocus}
+ onBlur={handleBlur}
+ />
+
+ <button className='button' onClick={handleButtonClick}>
+ <Icon id='copy' icon={ContentCopyIcon} />{' '}
+ {copied ? (
+ <FormattedMessage id='copypaste.copied' defaultMessage='Copied' />
+ ) : (
+ <FormattedMessage
+ id='copypaste.copy_to_clipboard'
+ defaultMessage='Copy to clipboard'
+ />
+ )}
+ </button>
+ </div>
+ );
+};
diff --git a/app/javascript/mastodon/components/status_action_bar.jsx b/app/javascript/mastodon/components/status_action_bar.jsx
index f24f81e1b2..165e81c7d8 100644
--- a/app/javascript/mastodon/components/status_action_bar.jsx
+++ b/app/javascript/mastodon/components/status_action_bar.jsx
@@ -55,7 +55,7 @@ const messages = defineMessages({
unmuteConversation: { id: 'status.unmute_conversation', defaultMessage: 'Unmute conversation' },
pin: { id: 'status.pin', defaultMessage: 'Pin on profile' },
unpin: { id: 'status.unpin', defaultMessage: 'Unpin from profile' },
- embed: { id: 'status.embed', defaultMessage: 'Embed' },
+ embed: { id: 'status.embed', defaultMessage: 'Get embed code' },
admin_account: { id: 'status.admin_account', defaultMessage: 'Open moderation interface for @{name}' },
admin_status: { id: 'status.admin_status', defaultMessage: 'Open this post in the moderation interface' },
admin_domain: { id: 'status.admin_domain', defaultMessage: 'Open moderation interface for {domain}' },
diff --git a/app/javascript/mastodon/containers/status_container.jsx b/app/javascript/mastodon/containers/status_container.jsx
index 58c5aac8f8..0fb5f25560 100644
--- a/app/javascript/mastodon/containers/status_container.jsx
+++ b/app/javascript/mastodon/containers/status_container.jsx
@@ -6,7 +6,6 @@ import {
unmuteAccount,
unblockAccount,
} from '../actions/accounts';
-import { showAlertForError } from '../actions/alerts';
import { initBlockModal } from '../actions/blocks';
import {
replyCompose,
@@ -100,10 +99,7 @@ const mapDispatchToProps = (dispatch, { contextType }) => ({
onEmbed (status) {
dispatch(openModal({
modalType: 'EMBED',
- modalProps: {
- id: status.get('id'),
- onError: error => dispatch(showAlertForError(error)),
- },
+ modalProps: { id: status.get('id') },
}));
},
diff --git a/app/javascript/mastodon/features/onboarding/share.jsx b/app/javascript/mastodon/features/onboarding/share.jsx
index 32a86ab6cc..9c720e9074 100644
--- a/app/javascript/mastodon/features/onboarding/share.jsx
+++ b/app/javascript/mastodon/features/onboarding/share.jsx
@@ -10,8 +10,8 @@ import { Link } from 'react-router-dom';
import SwipeableViews from 'react-swipeable-views';
import ArrowRightAltIcon from '@/material-icons/400-24px/arrow_right_alt.svg?react';
-import ContentCopyIcon from '@/material-icons/400-24px/content_copy.svg?react';
import { ColumnBackButton } from 'mastodon/components/column_back_button';
+import { CopyPasteText } from 'mastodon/components/copy_paste_text';
import { Icon } from 'mastodon/components/icon';
import { me, domain } from 'mastodon/initial_state';
import { useAppSelector } from 'mastodon/store';
@@ -20,67 +20,6 @@ const messages = defineMessages({
shareableMessage: { id: 'onboarding.share.message', defaultMessage: 'I\'m {username} on #Mastodon! Come follow me at {url}' },
});
-class CopyPasteText extends PureComponent {
-
- static propTypes = {
- value: PropTypes.string,
- };
-
- state = {
- copied: false,
- focused: false,
- };
-
- setRef = c => {
- this.input = c;
- };
-
- handleInputClick = () => {
- this.setState({ copied: false });
- this.input.focus();
- this.input.select();
- this.input.setSelectionRange(0, this.props.value.length);
- };
-
- handleButtonClick = e => {
- e.stopPropagation();
-
- const { value } = this.props;
- navigator.clipboard.writeText(value);
- this.input.blur();
- this.setState({ copied: true });
- this.timeout = setTimeout(() => this.setState({ copied: false }), 700);
- };
-
- handleFocus = () => {
- this.setState({ focused: true });
- };
-
- handleBlur = () => {
- this.setState({ focused: false });
- };
-
- componentWillUnmount () {
- if (this.timeout) clearTimeout(this.timeout);
- }
-
- render () {
- const { value } = this.props;
- const { copied, focused } = this.state;
-
- return (
- <div className={classNames('copy-paste-text', { copied, focused })} tabIndex='0' role='button' onClick={this.handleInputClick}>
- <textarea readOnly value={value} ref={this.setRef} onClick={this.handleInputClick} onFocus={this.handleFocus} onBlur={this.handleBlur} />
-
- <button className='button' onClick={this.handleButtonClick}>
- <Icon id='copy' icon={ContentCopyIcon} /> {copied ? <FormattedMessage id='copypaste.copied' defaultMessage='Copied' /> : <FormattedMessage id='copypaste.copy_to_clipboard' defaultMessage='Copy to clipboard' />}
- </button>
- </div>
- );
- }
-
-}
-
class TipCarousel extends PureComponent {
static propTypes = {
diff --git a/app/javascript/mastodon/features/status/components/action_bar.jsx b/app/javascript/mastodon/features/status/components/action_bar.jsx
index d90ca464a7..8ba2db7d8d 100644
--- a/app/javascript/mastodon/features/status/components/action_bar.jsx
+++ b/app/javascript/mastodon/features/status/components/action_bar.jsx
@@ -49,7 +49,7 @@ const messages = defineMessages({
share: { id: 'status.share', defaultMessage: 'Share' },
pin: { id: 'status.pin', defaultMessage: 'Pin on profile' },
unpin: { id: 'status.unpin', defaultMessage: 'Unpin from profile' },
- embed: { id: 'status.embed', defaultMessage: 'Embed' },
+ embed: { id: 'status.embed', defaultMessage: 'Get embed code' },
admin_account: { id: 'status.admin_account', defaultMessage: 'Open moderation interface for @{name}' },
admin_status: { id: 'status.admin_status', defaultMessage: 'Open this post in the moderation interface' },
admin_domain: { id: 'status.admin_domain', defaultMessage: 'Open moderation interface for {domain}' },
diff --git a/app/javascript/mastodon/features/ui/components/embed_modal.jsx b/app/javascript/mastodon/features/ui/components/embed_modal.jsx
deleted file mode 100644
index a4e5fc9dfb..0000000000
--- a/app/javascript/mastodon/features/ui/components/embed_modal.jsx
+++ /dev/null
@@ -1,101 +0,0 @@
-import PropTypes from 'prop-types';
-
-import { defineMessages, FormattedMessage, injectIntl } from 'react-intl';
-
-import ImmutablePureComponent from 'react-immutable-pure-component';
-
-import CloseIcon from '@/material-icons/400-24px/close.svg?react';
-import api from 'mastodon/api';
-import { IconButton } from 'mastodon/components/icon_button';
-
-const messages = defineMessages({
- close: { id: 'lightbox.close', defaultMessage: 'Close' },
-});
-
-class EmbedModal extends ImmutablePureComponent {
-
- static propTypes = {
- id: PropTypes.string.isRequired,
- onClose: PropTypes.func.isRequired,
- onError: PropTypes.func.isRequired,
- intl: PropTypes.object.isRequired,
- };
-
- state = {
- loading: false,
- oembed: null,
- };
-
- componentDidMount () {
- const { id } = this.props;
-
- this.setState({ loading: true });
-
- api().get(`/api/web/embeds/${id}`).then(res => {
- this.setState({ loading: false, oembed: res.data });
-
- const iframeDocument = this.iframe.contentWindow.document;
-
- iframeDocument.open();
- iframeDocument.write(res.data.html);
- iframeDocument.close();
-
- iframeDocument.body.style.margin = 0;
- this.iframe.width = iframeDocument.body.scrollWidth;
- this.iframe.height = iframeDocument.body.scrollHeight;
- }).catch(error => {
- this.props.onError(error);
- });
- }
-
- setIframeRef = c => {
- this.iframe = c;
- };
-
- handleTextareaClick = (e) => {
- e.target.select();
- };
-
- render () {
- const { intl, onClose } = this.props;
- const { oembed } = this.state;
-
- return (
- <div className='modal-root__modal report-modal embed-modal'>
- <div className='report-modal__target'>
- <IconButton className='media-modal__close' title={intl.formatMessage(messages.close)} icon='times' iconComponent={CloseIcon} onClick={onClose} size={16} />
- <FormattedMessage id='status.embed' defaultMessage='Embed' />
- </div>
-
- <div className='report-modal__container embed-modal__container' style={{ display: 'block' }}>
- <p className='hint'>
- <FormattedMessage id='embed.instructions' defaultMessage='Embed this status on your website by copying the code below.' />
- </p>
-
- <input
- type='text'
- className='embed-modal__html'
- readOnly
- value={oembed && oembed.html || ''}
- onClick={this.handleTextareaClick}
- />
-
- <p className='hint'>
- <FormattedMessage id='embed.preview' defaultMessage='Here is what it will look like:' />
- </p>
-
- <iframe
- className='embed-modal__iframe'
- frameBorder='0'
- ref={this.setIframeRef}
- sandbox='allow-scripts allow-same-origin'
- title='preview'
- />
- </div>
- </div>
- );
- }
-
-}
-
-export default injectIntl(EmbedModal);
diff --git a/app/javascript/mastodon/features/ui/components/embed_modal.tsx b/app/javascript/mastodon/features/ui/components/embed_modal.tsx
new file mode 100644
index 0000000000..8f623e62b5
--- /dev/null
+++ b/app/javascript/mastodon/features/ui/components/embed_modal.tsx
@@ -0,0 +1,116 @@
+import { useRef, useState, useEffect } from 'react';
+
+import { FormattedMessage } from 'react-intl';
+
+import { showAlertForError } from 'mastodon/actions/alerts';
+import api from 'mastodon/api';
+import { Button } from 'mastodon/components/button';
+import { CopyPasteText } from 'mastodon/components/copy_paste_text';
+import { useAppDispatch } from 'mastodon/store';
+
+interface OEmbedResponse {
+ html: string;
+}
+
+const EmbedModal: React.FC<{
+ id: string;
+ onClose: () => void;
+}> = ({ id, onClose }) => {
+ const iframeRef = useRef<HTMLIFrameElement>(null);
+ const intervalRef = useRef<ReturnType<typeof setInterval>>();
+ const [oembed, setOembed] = useState<OEmbedResponse | null>(null);
+ const dispatch = useAppDispatch();
+
+ useEffect(() => {
+ api()
+ .get(`/api/web/embeds/${id}`)
+ .then((res) => {
+ const data = res.data as OEmbedResponse;
+
+ setOembed(data);
+
+ const iframeDocument = iframeRef.current?.contentWindow?.document;
+
+ if (!iframeDocument) {
+ return '';
+ }
+
+ iframeDocument.open();
+ iframeDocument.write(data.html);
+ iframeDocument.close();
+
+ iframeDocument.body.style.margin = '0px';
+
+ // This is our best chance to ensure the parent iframe has the correct height...
+ intervalRef.current = setInterval(
+ () =>
+ window.requestAnimationFrame(() => {
+ if (iframeRef.current) {
+ iframeRef.current.width = `${iframeDocument.body.scrollWidth}px`;
+ iframeRef.current.height = `${iframeDocument.body.scrollHeight}px`;
+ }
+ }),
+ 100,
+ );
+
+ return '';
+ })
+ .catch((error: unknown) => {
+ dispatch(showAlertForError(error));
+ });
+ }, [dispatch, id, setOembed]);
+
+ useEffect(
+ () => () => {
+ if (intervalRef.current) {
+ clearInterval(intervalRef.current);
+ }
+ },
+ [],
+ );
+
+ return (
+ <div className='modal-root__modal dialog-modal'>
+ <div className='dialog-modal__header'>
+ <Button onClick={onClose}>
+ <FormattedMessage id='report.close' defaultMessage='Done' />
+ </Button>
+ <span className='dialog-modal__header__title'>
+ <FormattedMessage id='status.embed' defaultMessage='Get embed code' />
+ </span>
+ <Button secondary onClick={onClose}>
+ <FormattedMessage
+ id='confirmation_modal.cancel'
+ defaultMessage='Cancel'
+ />
+ </Button>
+ </div>
+
+ <div className='dialog-modal__content'>
+ <div className='dialog-modal__content__form'>
+ <FormattedMessage
+ id='embed.instructions'
+ defaultMessage='Embed this status on your website by copying the code below.'
+ />
+
+ <CopyPasteText value={oembed?.html ?? ''} />
+
+ <FormattedMessage
+ id='embed.preview'
+ defaultMessage='Here is what it will look like:'
+ />
+
+ <iframe
+ frameBorder='0'
+ ref={iframeRef}
+ sandbox='allow-scripts allow-same-origin'
+ title='Preview'
+ />
+ </div>
+ </div>
+ </div>
+ );
+};
+
+// eslint-disable-next-line import/no-default-export
+export default EmbedModal;
diff --git a/app/javascript/mastodon/locales/en.json b/app/javascript/mastodon/locales/en.json
index 39ee7b858f..1de2dce440 100644
--- a/app/javascript/mastodon/locales/en.json
+++ b/app/javascript/mastodon/locales/en.json
@@ -789,7 +789,7 @@
"status.edit": "Edit",
"status.edited": "Last edited {date}",
"status.edited_x_times": "Edited {count, plural, one {{count} time} other {{count} times}}",
- "status.embed": "Embed",
+ "status.embed": "Get embed code",
"status.favourite": "Favorite",
"status.favourites": "{count, plural, one {favorite} other {favorites}}",
"status.filter": "Filter this post",
diff --git a/app/javascript/styles/mastodon/components.scss b/app/javascript/styles/mastodon/components.scss
index c6ce8f55ab..8adad2441a 100644
--- a/app/javascript/styles/mastodon/components.scss
+++ b/app/javascript/styles/mastodon/components.scss
@@ -1730,6 +1730,10 @@ body > [data-popper-placement] {
width: 100%;
height: 100%;
}
+
+ .detailed-status {
+ border-top: 0;
+ }
}
.scrollable > div:first-child .detailed-status {
@@ -6289,6 +6293,50 @@ a.status-card {
}
}
+.dialog-modal {
+ width: 588px;
+ max-height: 80vh;
+ flex-direction: column;
+ background: var(--modal-background-color);
+ backdrop-filter: var(--background-filter);
+ border: 1px solid var(--modal-border-color);
+ border-radius: 16px;
+
+ &__header {
+ border-bottom: 1px solid var(--modal-border-color);
+ display: flex;
+ align-items: center;
+ justify-content: space-between;
+ flex-direction: row-reverse;
+ padding: 12px 24px;
+
+ &__title {
+ font-size: 16px;
+ line-height: 24px;
+ font-weight: 500;
+ letter-spacing: 0.15px;
+ }
+ }
+
+ &__content {
+ font-size: 14px;
+ line-height: 20px;
+ letter-spacing: 0.25px;
+ overflow-y: auto;
+
+ &__form {
+ display: flex;
+ flex-direction: column;
+ gap: 16px;
+ padding: 24px;
+ }
+ }
+
+ .copy-paste-text {
+ margin-bottom: 0;
+ }
+}
+
.hotkey-combination {
display: inline-flex;
align-items: center;
@@ -7737,69 +7785,6 @@ noscript {
}
}
-.embed-modal {
- width: auto;
- max-width: 80vw;
- max-height: 80vh;
-
- h4 {
- padding: 30px;
- font-weight: 500;
- font-size: 16px;
- text-align: center;
- }
-
- .embed-modal__container {
- padding: 10px;
-
- .hint {
- margin-bottom: 15px;
- }
-
- .embed-modal__html {
- outline: 0;
- box-sizing: border-box;
- display: block;
- width: 100%;
- border: 0;
- padding: 10px;
- font-family: $font-monospace, monospace;
- background: $ui-base-color;
- color: $primary-text-color;
- font-size: 14px;
- margin: 0;
- margin-bottom: 15px;
- border-radius: 4px;
-
- &::-moz-focus-inner {
- border: 0;
- }
-
- &::-moz-focus-inner,
- &:focus,
- &:active {
- outline: 0 !important;
- }
-
- &:focus {
- background: lighten($ui-base-color, 4%);
- }
-
- @media screen and (width <= 600px) {
- font-size: 16px;
- }
- }
-
- .embed-modal__iframe {
- width: 400px;
- max-width: 100%;
- overflow: hidden;
- border: 0;
- border-radius: 4px;
- }
- }
-}
-
.moved-account-banner,
.follow-request-banner,
.account-memorial-banner {
diff --git a/app/serializers/oembed_serializer.rb b/app/serializers/oembed_serializer.rb
index 3882b0e305..19fa5ddec7 100644
--- a/app/serializers/oembed_serializer.rb
+++ b/app/serializers/oembed_serializer.rb
@@ -1,6 +1,13 @@
# frozen_string_literal: true
class OEmbedSerializer < ActiveModel::Serializer
+ INLINE_STYLES = {
+ blockquote: 'max-width: 540px; min-width: 270px; background:#FCF8FF; border: 1px solid #C9C4DA; border-radius: 8px; overflow: hidden; margin: 0; padding: 0;',
+ a: "color: #1C1A25; text-decoration: none; display: flex; align-items: center; justify-content: center; flex-direction: column; padding: 24px; font-size: 14px; line-height: 20px; letter-spacing: 0.25px; font-family: system-ui, -apple-system, BlinkMacSystemFont, 'Segoe UI', Oxygen, Ubuntu, Cantarell, 'Fira Sans', 'Droid Sans', 'Helvetica Neue', Roboto, sans-serif;", # rubocop:disable Layout/LineLength
+ div0: 'margin-top: 16px; color: #787588;',
+ div1: 'font-weight: 500;',
+ }.freeze
+
include RoutingHelper
include ActionView::Helpers::TagHelper
@@ -38,14 +45,14 @@ class OEmbedSerializer < ActiveModel::Serializer
def html
<<~HTML.squish
- <blockquote class="mastodon-embed" data-embed-url="#{embed_short_account_status_url(object.account, object)}" style="max-width: 540px; min-width: 270px; background:#FCF8FF; border: 1px solid #C9C4DA; border-radius: 8px; overflow: hidden; margin: 0; padding: 0;">
- <a href="#{short_account_status_url(object.account, object)}" target="_blank" style="color: #1C1A25; text-decoration: none; display: flex; align-items: center; justify-content: center; flex-direction: column; padding: 24px; font-size: 14px; line-height: 20px; letter-spacing: 0.25px; font-family: system-ui, -apple-system, BlinkMacSystemFont, 'Segoe UI', Oxygen, Ubuntu, Cantarell, 'Fira Sans', 'Droid Sans', 'Helvetica Neue', Roboto, sans-serif;">
+ <blockquote class="mastodon-embed" data-embed-url="#{embed_short_account_status_url(object.account, object)}" style="#{INLINE_STYLES[:blockquote]}">
+ <a href="#{short_account_status_url(object.account, object)}" target="_blank" style="#{INLINE_STYLES[:a]}">
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="32" height="32" viewBox="0 0 79 75"><path d="M74.7135 16.6043C73.6199 8.54587 66.5351 2.19527 58.1366 0.964691C56.7196 0.756754 51.351 0 38.9148 0H38.822C26.3824 0 23.7135 0.756754 22.2966 0.964691C14.1319 2.16118 6.67571 7.86752 4.86669 16.0214C3.99657 20.0369 3.90371 24.4888 4.06535 28.5726C4.29578 34.4289 4.34049 40.275 4.877 46.1075C5.24791 49.9817 5.89495 53.8251 6.81328 57.6088C8.53288 64.5968 15.4938 70.4122 22.3138 72.7848C29.6155 75.259 37.468 75.6697 44.9919 73.971C45.8196 73.7801 46.6381 73.5586 47.4475 73.3063C49.2737 72.7302 51.4164 72.086 52.9915 70.9542C53.0131 70.9384 53.0308 70.9178 53.0433 70.8942C53.0558 70.8706 53.0628 70.8445 53.0637 70.8179V65.1661C53.0634 65.1412 53.0574 65.1167 53.0462 65.0944C53.035 65.0721 53.0189 65.0525 52.9992 65.0371C52.9794 65.0218 52.9564 65.011 52.9318 65.0056C52.9073 65.0002 52.8819 65.0003 52.8574 65.0059C48.0369 66.1472 43.0971 66.7193 38.141 66.7103C29.6118 66.7103 27.3178 62.6981 26.6609 61.0278C26.1329 59.5842 25.7976 58.0784 25.6636 56.5486C25.6622 56.5229 25.667 56.4973 25.6775 56.4738C25.688 56.4502 25.7039 56.4295 25.724 56.4132C25.7441 56.397 25.7678 56.3856 25.7931 56.3801C25.8185 56.3746 25.8448 56.3751 25.8699 56.3816C30.6101 57.5151 35.4693 58.0873 40.3455 58.086C41.5183 58.086 42.6876 58.086 43.8604 58.0553C48.7647 57.919 53.9339 57.6701 58.7591 56.7361C58.8794 56.7123 58.9998 56.6918 59.103 56.6611C66.7139 55.2124 73.9569 50.665 74.6929 39.1501C74.7204 38.6967 74.7892 34.4016 74.7892 33.9312C74.7926 32.3325 75.3085 22.5901 74.7135 16.6043ZM62.9996 45.3371H54.9966V25.9069C54.9966 21.8163 53.277 19.7302 49.7793 19.7302C45.9343 19.7302 44.0083 22.1981 44.0083 27.0727V37.7082H36.0534V27.0727C36.0534 22.1981 34.124 19.7302 30.279 19.7302C26.8019 19.7302 25.0651 21.8163 25.0617 25.9069V45.3371H17.0656V25.3172C17.0656 21.2266 18.1191 17.9769 20.2262 15.568C22.3998 13.1648 25.2509 11.9308 28.7898 11.9308C32.8859 11.9308 35.9812 13.492 38.0447 16.6111L40.036 19.9245L42.0308 16.6111C44.0943 13.492 47.1896 11.9308 51.2788 11.9308C54.8143 11.9308 57.6654 13.1648 59.8459 15.568C61.9529 17.9746 63.0065 21.2243 63.0065 25.3172L62.9996 45.3371Z" fill="currentColor"/></svg>
- <div style="margin-top: 16px; color: #787588;">Post by @#{object.account.pretty_acct}@#{provider_name}</div>
- <div style="font-weight: 500;">View on Mastodon</div>
+ <div style="#{INLINE_STYLES[:div0]}">Post by @#{object.account.pretty_acct}@#{provider_name}</div>
+ <div style="#{INLINE_STYLES[:div1]}">View on Mastodon</div>
</a>
</blockquote>
- <script data-allowed-prefixes="#{root_url}" src="#{full_asset_url('embed.js', skip_pipeline: true)}" async="true"></script>
+ <script data-allowed-prefixes="#{root_url}" async src="#{full_asset_url('embed.js', skip_pipeline: true)}"></script>
HTML
end
diff --git a/app/views/layouts/embedded.html.haml b/app/views/layouts/embedded.html.haml
index 0237e04515..c3de1bcd01 100644
--- a/app/views/layouts/embedded.html.haml
+++ b/app/views/layouts/embedded.html.haml
@@ -11,7 +11,7 @@
- if storage_host?
%link{ rel: 'dns-prefetch', href: storage_host }/
- = theme_style_tags Setting.theme # Use the admin-configured theme here, even if logged in
+ = theme_style_tags 'mastodon-light'
= javascript_pack_tag 'common', integrity: true, crossorigin: 'anonymous'
= preload_pack_asset "locale/#{I18n.locale}-json.js"
= render_initial_state
diff --git a/config/initializers/content_security_policy.rb b/config/initializers/content_security_policy.rb
index e43e38786c..7f34d93eee 100644
--- a/config/initializers/content_security_policy.rb
+++ b/config/initializers/content_security_policy.rb
@@ -38,17 +38,16 @@ Rails.application.config.content_security_policy do |p|
p.img_src :self, :data, :blob, *media_hosts
p.style_src :self, assets_host
p.media_src :self, :data, *media_hosts
- p.frame_src :self, :https
p.manifest_src :self, assets_host
if sso_host.present?
- p.form_action :self, sso_host
+ p.form_action :self, sso_host
else
- p.form_action :self
+ p.form_action :self
end
- p.child_src :self, :blob, assets_host
- p.worker_src :self, :blob, assets_host
+ p.child_src :self, :blob, assets_host
+ p.worker_src :self, :blob, assets_host
if Rails.env.development?
webpacker_public_host = ENV.fetch('WEBPACKER_DEV_SERVER_PUBLIC', Webpacker.config.dev_server[:public])
@@ -56,9 +55,11 @@ Rails.application.config.content_security_policy do |p|
p.connect_src :self, :data, :blob, *media_hosts, Rails.configuration.x.streaming_api_base_url, *front_end_build_urls
p.script_src :self, :unsafe_inline, :unsafe_eval, assets_host
+ p.frame_src :self, :https, :http
else
p.connect_src :self, :data, :blob, *media_hosts, Rails.configuration.x.streaming_api_base_url
p.script_src :self, assets_host, "'wasm-unsafe-eval'"
+ p.frame_src :self, :https
end
end
--
GitLab