diff --git a/thumbnailing/i/01-factories.go b/thumbnailing/i/01-factories.go index 4e2fc6e08a2cbfc2d61b8992fe92db6e6824e639..4ad58e3fa35ea0a980a4765eb0196229626580b0 100644 --- a/thumbnailing/i/01-factories.go +++ b/thumbnailing/i/01-factories.go @@ -23,7 +23,7 @@ type AudioGenerator interface { var generators = make([]Generator, 0) -func GetGenerator(img io.Reader, contentType string, needsAnimation bool) (Generator, *readers.PrefixedReader) { +func GetGenerator(img io.Reader, contentType string, needsAnimation bool) (Generator, io.Reader) { br := readers.NewBufferReadsReader(img) for _, g := range generators { if needsAnimation && !g.supportsAnimation() { diff --git a/thumbnailing/thumbnail.go b/thumbnailing/thumbnail.go index 6759ce27ca09b1b25e4631c719616898230e85d1..e1fc5df8db225f3edf3f6191f91dd2388f457e69 100644 --- a/thumbnailing/thumbnail.go +++ b/thumbnailing/thumbnail.go @@ -54,7 +54,7 @@ func GenerateThumbnail(imgStream io.ReadCloser, contentType string, width int, h return generator.GenerateThumbnail(buffered.GetRewoundReader(), contentType, width, height, method, animated, ctx) } -func GetGenerator(imgStream io.Reader, contentType string, animated bool) (i.Generator, *readers.PrefixedReader, error) { +func GetGenerator(imgStream io.Reader, contentType string, animated bool) (i.Generator, io.Reader, error) { generator, reconstructed := i.GetGenerator(imgStream, contentType, animated) if generator == nil { return nil, reconstructed, ErrUnsupported diff --git a/util/readers/buffer_reads_reader.go b/util/readers/buffer_reads_reader.go index 84918f39a4c10f71f955d5e11c9dc4d9af1621a0..8382029c4608185337a18e7478640243b14f1967 100644 --- a/util/readers/buffer_reads_reader.go +++ b/util/readers/buffer_reads_reader.go @@ -11,7 +11,7 @@ type BufferReadsReader struct { r io.Reader original io.Reader b *bytes.Buffer - pr *PrefixedReader + pr io.Reader } func NewBufferReadsReader(r io.Reader) *BufferReadsReader { @@ -32,15 +32,15 @@ func (r *BufferReadsReader) Read(p []byte) (int, error) { return r.r.Read(p) } -func (r *BufferReadsReader) MakeRewoundReader() (*PrefixedReader, error) { +func (r *BufferReadsReader) MakeRewoundReader() (io.Reader, error) { if r.pr != nil { return r.pr, errors.New("prefixed reader already created from this reader") } - r.pr = NewPrefixedReader(r.b, r.original) + r.pr = io.MultiReader(r.b, r.original) return r.pr, nil } -func (r *BufferReadsReader) GetRewoundReader() *PrefixedReader { +func (r *BufferReadsReader) GetRewoundReader() io.Reader { pr, _ := r.MakeRewoundReader() return pr } diff --git a/util/readers/prefixed_reader.go b/util/readers/prefixed_reader.go deleted file mode 100644 index 6079da31c2a5ca657a243e2a1f1054f2eda91530..0000000000000000000000000000000000000000 --- a/util/readers/prefixed_reader.go +++ /dev/null @@ -1,36 +0,0 @@ -package readers - -import ( - "bytes" - "io" -) - -type PrefixedReader struct { - io.Reader - b *bytes.Buffer - r io.Reader - inBuffer bool -} - -func NewPrefixedReader(prefix *bytes.Buffer, r io.Reader) *PrefixedReader { - return &PrefixedReader{ - b: prefix, - r: r, - inBuffer: prefix.Len() > 0, - } -} - -func (r *PrefixedReader) Read(p []byte) (int, error) { - if r.inBuffer { - read, err := r.b.Read(p) - if err == io.EOF { - r.inBuffer = false - return read, nil - } - if r.b.Len() <= 0 { - r.inBuffer = false - } - return read, err - } - return r.r.Read(p) -}