From 04473c0f0eac203364c8c3f64b253286226d0c86 Mon Sep 17 00:00:00 2001
From: Vincent Petry <vincent@nextcloud.com>
Date: Tue, 2 Feb 2021 16:32:24 +0100
Subject: [PATCH] Fix duplicate tag info view registration
Only register the tag info view once as it's stored in a singleton.
This fixes an issue where the tag info view did not get rendered after
swiching between different file views.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
---
apps/systemtags/js/systemtags.js | Bin 14711 -> 14732 bytes
apps/systemtags/js/systemtags.js.map | Bin 53587 -> 53826 bytes
apps/systemtags/src/filesplugin.js | 11 ++++++++---
3 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/apps/systemtags/js/systemtags.js b/apps/systemtags/js/systemtags.js
index 9e30b855400cadb32f15c60531092da2a43f1775..68da665a20dc77d0f7a98f82d983d1c9969c87c7 100644
GIT binary patch
delta 34
pcmexf)Kk1+wSj0&jlZ*_UT|e`NosCLVtTP&SY~SZ=G6vgH~<4t4nY6_
delta 12
TcmeAv{$8|UwZY~C24^?`Eindb
diff --git a/apps/systemtags/js/systemtags.js.map b/apps/systemtags/js/systemtags.js.map
index 0712748b1be7bbf1a4bdc5834b012fea9828a063..2c3d6cf87e121451dd0656b02c815235a0512e11 100644
GIT binary patch
delta 413
zcmY+AJxjwt7=WqO!Lf*)Uk5)5p|zEwb-Nt>xRwy1Vja3%lS^}$=Gx?Jts?yi4%r<<
zoP~^a690kVzYyGAyx67X;CMft_qmt*d`iDRr(biK^$X4>(OyQ6MP{owGjDKM*9bxc
zYaN6-)23!1WM~-STRo{8SgRs5`j5#`a|taqwSkUs1s^vOq<zvzax~CuS{>oCz5*+6
z3n3G$+brrHQ3$H{arCY4uMKgO#k0*xYw=P!e#Ac;sZ#VnvZ-?XLcT_`LIH&DO~DEn
zl?<qF1C^3mt}0us>vv^x6jdXaM)ee=%R>lVaqZdQ@hhfAdkk#hGc^DdZ0<NLV7>%P
z*bIhLy5Nh+lE@K(vM>m_&3c5YL@ZWt>6ihR5U@TErIOeyJ8%aMc1(=&?WyVx&S^i)
eCtsd}yTl%i=V#H!yb}G+57S+FAMd{9xBmdx;EG%T
delta 195
zcmX@Kg!%F!<_(&HlMMvzH)jY+874cLJL@<*dOGTOIy(BM2kN*wIu<&CIG%=HV9Hr1
z+|e=Iz)L6B$<f);+0+B1B-qRY#CObfa?^2lbT)NDQEcL+<L&6^?*SxztDLeX|8&x4
z(s!Dy<y_BM>J72Mc=IOb53CXpV}Uk00)?}@i$HG4^>#Pjyvy@i;pDhIUXxetF`xW+
QkKW{z$-<j;_lk-F0Ofx@$^ZZW
diff --git a/apps/systemtags/src/filesplugin.js b/apps/systemtags/src/filesplugin.js
index 0263fe6beb9..ac6fe4174b6 100644
--- a/apps/systemtags/src/filesplugin.js
+++ b/apps/systemtags/src/filesplugin.js
@@ -31,9 +31,14 @@
return
}
- const systemTagsInfoView = new OCA.SystemTags.SystemTagsInfoView()
- fileList.registerDetailView(systemTagsInfoView)
- OCA.SystemTags.View = systemTagsInfoView
+ // only create and attach once
+ // FIXME: this should likely be done on a different code path now
+ // for the sidebar to only have it registered once
+ if (!OCA.SystemTags.View) {
+ const systemTagsInfoView = new OCA.SystemTags.SystemTagsInfoView()
+ fileList.registerDetailView(systemTagsInfoView)
+ OCA.SystemTags.View = systemTagsInfoView
+ }
},
}
--
GitLab