From 04a4df50657aafaef03756474fde34da8bff74a8 Mon Sep 17 00:00:00 2001
From: Jan-Christoph Borchardt <hey@jancborchardt.net>
Date: Wed, 25 Mar 2015 09:34:13 +0100
Subject: [PATCH] only show connection checks results if there are errors, fix
 #11476

---
 settings/css/settings.css    | 7 -------
 settings/js/admin.js         | 3 +--
 settings/templates/admin.php | 1 -
 3 files changed, 1 insertion(+), 10 deletions(-)

diff --git a/settings/css/settings.css b/settings/css/settings.css
index e400fc2ab48..814eb665428 100644
--- a/settings/css/settings.css
+++ b/settings/css/settings.css
@@ -394,16 +394,9 @@ doesnotexist:-o-prefocus, .strengthify-wrapper {
 
 #postsetupchecks .loading {
 	height: 50px;
-}
-
-#postsetupchecks.section .loading {
 	background-position: left center;
 }
 
-#postsetupchecks .hint {
-	margin-top: 15px;
-}
-
 #admin-tips li {
 	list-style: initial;
 }
diff --git a/settings/js/admin.js b/settings/js/admin.js
index a3c941f08a4..6ec1a061fc9 100644
--- a/settings/js/admin.js
+++ b/settings/js/admin.js
@@ -140,11 +140,10 @@ $(document).ready(function(){
 		var $errorsEl;
 		$el.find('.loading').addClass('hidden');
 		if (errors.length === 0) {
-			$el.find('.success').removeClass('hidden');
 		} else {
 			$errorsEl = $el.find('.errors');
 			for (var i = 0; i < errors.length; i++ ) {
-				$errorsEl.append('<li class="setupwarning">' + errors[i] + '</li>');
+				$errorsEl.append('<li>' + errors[i] + '</li>');
 			}
 			$errorsEl.removeClass('hidden');
 			$el.find('.hint').removeClass('hidden');
diff --git a/settings/templates/admin.php b/settings/templates/admin.php
index 548b541dbec..7813babf5c5 100644
--- a/settings/templates/admin.php
+++ b/settings/templates/admin.php
@@ -172,7 +172,6 @@ if ($_['cronErrors']) {
 
 <div id="postsetupchecks">
 	<div class="loading"></div>
-	<div class="success hidden"><?php p($l->t('No problems found'));?></div>
 	<ul class="errors hidden"></ul>
 	<p class="hint hidden">
 		<?php print_unescaped($l->t('Please double check the <a target="_blank" href="%s">installation guides ↗</a>, and check for any errors or warnings in the <a href="#log-section">log</a>.', link_to_docs('admin-install'))); ?>
-- 
GitLab