From 0e72d38747b12913c7524e07f8f9adc11f75f407 Mon Sep 17 00:00:00 2001
From: Roeland Jago Douma <roeland@famdouma.nl>
Date: Fri, 15 Feb 2019 23:06:21 +0100
Subject: [PATCH] Catch Request exception in testRemoteUrl
Else the background job fails hard if the remote has for example an
invalid certificate.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
---
apps/files_sharing/lib/External/Storage.php | 3 +++
1 file changed, 3 insertions(+)
diff --git a/apps/files_sharing/lib/External/Storage.php b/apps/files_sharing/lib/External/Storage.php
index 7411d3c51b6..58da8456394 100644
--- a/apps/files_sharing/lib/External/Storage.php
+++ b/apps/files_sharing/lib/External/Storage.php
@@ -32,6 +32,7 @@ namespace OCA\Files_Sharing\External;
use GuzzleHttp\Exception\ClientException;
use GuzzleHttp\Exception\ConnectException;
+use GuzzleHttp\Exception\RequestException;
use OC\Files\Storage\DAV;
use OC\ForbiddenException;
use OCA\Files_Sharing\ISharedStorage;
@@ -280,6 +281,8 @@ class Storage extends DAV implements ISharedStorage, IDisableEncryptionStorage {
$returnValue = false;
} catch (ClientException $e) {
$returnValue = false;
+ } catch (RequestException $e) {
+ $returnValue = false;
}
$cache->set($url, $returnValue, 60*60*24);
--
GitLab