From 219905b9c881eb72b0e6398e022e80bc6763159b Mon Sep 17 00:00:00 2001
From: Robin Appelman <robin@icewind.nl>
Date: Fri, 18 Oct 2019 18:20:25 +0200
Subject: [PATCH] Dont cache empty url for not found routes

Signed-off-by: Robin Appelman <robin@icewind.nl>
---
 lib/private/Route/CachingRouter.php | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/private/Route/CachingRouter.php b/lib/private/Route/CachingRouter.php
index cb1b98d77e6..a37bbf5b701 100644
--- a/lib/private/Route/CachingRouter.php
+++ b/lib/private/Route/CachingRouter.php
@@ -58,7 +58,9 @@ class CachingRouter extends Router {
 			return $cachedKey;
 		} else {
 			$url = parent::generate($name, $parameters, $absolute);
-			$this->cache->set($key, $url, 3600);
+			if ($url) {
+				$this->cache->set($key, $url, 3600);
+			}
 			return $url;
 		}
 	}
-- 
GitLab