From 329ffa257e1b91a544f0e2d98af4e2ebfbcc6283 Mon Sep 17 00:00:00 2001
From: Joas Schilling <coding@schilljs.com>
Date: Tue, 15 Dec 2020 11:18:30 +0100
Subject: [PATCH] Log an error when setting a custom header on "Not Modified"
responses
Signed-off-by: Joas Schilling <coding@schilljs.com>
---
lib/public/AppFramework/Http/Response.php | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/lib/public/AppFramework/Http/Response.php b/lib/public/AppFramework/Http/Response.php
index ff6b97f87b1..fc3ee739773 100644
--- a/lib/public/AppFramework/Http/Response.php
+++ b/lib/public/AppFramework/Http/Response.php
@@ -38,6 +38,8 @@ namespace OCP\AppFramework\Http;
use OCP\AppFramework\Http;
use OCP\AppFramework\Utility\ITimeFactory;
+use OCP\IConfig;
+use Psr\Log\LoggerInterface;
/**
* Base class for responses. Also used to just send headers.
@@ -203,6 +205,18 @@ class Response {
// to be able to reliably check for security
// headers
+ if ($this->status === Http::STATUS_NOT_MODIFIED
+ && stripos($name, 'x-') === 0) {
+ /** @var IConfig $config */
+ $config = \OC::$server->get(IConfig::class);
+
+ if ($config->getSystemValueBool('debug', false)) {
+ \OC::$server->get(LoggerInterface::class)->error(
+ 'Setting a custom header on a 204 or 304 is not supported'
+ );
+ }
+ }
+
if (is_null($value)) {
unset($this->headers[$name]);
} else {
--
GitLab