Merge pull request #24038 from nextcloud/techdebt/noid/remove-unused-static-methods-files_external

Remove unused and deprecated methods from files_external MountConfig

apps/files_external/lib/MountConfig.php

@@ -43,10 +43,7 @@ namespace OCA\Files_External;
 use OCA\Files_External\AppInfo\Application;
 use OCA\Files_External\Config\IConfigHandler;
 use OCA\Files_External\Config\UserContext;
-use OCA\Files_External\Config\UserPlaceholderHandler;
-use OCA\Files_External\Lib\Auth\Builtin;
 use OCA\Files_External\Lib\Backend\Backend;
-use OCA\Files_External\Lib\Backend\LegacyBackend;
 use OCA\Files_External\Lib\StorageConfig;
 use OCA\Files_External\Service\BackendService;
 use OCA\Files_External\Service\GlobalStoragesService;
@@ -73,21 +70,6 @@ class MountConfig {
 	/** @var Application */
 	public static $app;
 
-	/**
-	 * @param string $class
-	 * @param array $definition
-	 * @return bool
-	 * @deprecated 8.2.0 use \OCA\Files_External\Service\BackendService::registerBackend()
-	 */
-	public static function registerBackend($class, $definition) {
-		$backendService = self::$app->getContainer()->query(BackendService::class);
-		$auth = self::$app->getContainer()->query(Builtin::class);
-
-		$backendService->registerBackend(new LegacyBackend($class, $definition, $auth));
-
-		return true;
-	}
-
 	/**
 	 * Returns the mount points for the given user.
 	 * The mount point is relative to the data directory.
@@ -150,24 +132,6 @@ class MountConfig {
 		return $mountPoints;
 	}
 
-	/**
-	 * Get the personal mount points of the current user
-	 *
-	 * @return array
-	 *
-	 * @deprecated 8.2.0 use UserStoragesService::getStorages()
-	 */
-	public static function getPersonalMountPoints() {
-		$mountPoints = [];
-		$service = self::$app->getContainer()->query(UserStoragesService::class);
-
-		foreach ($service->getStorages() as $storage) {
-			$mountPoints[] = self::prepareMountPointEntry($storage, true);
-		}
-
-		return $mountPoints;
-	}
-
 	/**
 	 * Convert a StorageConfig to the legacy mountPoints array format
 	 * There's a lot of extra information in here, to satisfy all of the legacy functions
@@ -201,19 +165,6 @@ class MountConfig {
 		return $mountEntry;
 	}
 
-	/**
-	 * fill in the correct values for $user
-	 *
-	 * @param string $user user value
-	 * @param string|array $input
-	 * @return string
-	 * @deprecated use self::substitutePlaceholdersInConfig($input)
-	 */
-	public static function setUserVars($user, $input) {
-		$handler = self::$app->getContainer()->query(UserPlaceholderHandler::class);
-		return $handler->handle($input);
-	}
-
 	/**
 	 * @param mixed $input
 	 * @param string|null $userId