From 4717605d22f5f60e887b5584e8da25b8ef69cdf4 Mon Sep 17 00:00:00 2001
From: Robin McCorkell <robin@mccorkell.me.uk>
Date: Wed, 13 Apr 2016 23:18:07 +0100
Subject: [PATCH] Fix storage backend class namespaces and move to subdir
All classes that were previously \OC\Files\Storage\FooBar are now
\OCA\Files_External\Lib\Storage\FooBar
---
apps/files_external/appinfo/app.php | 9 -------
apps/files_external/lib/backend/amazons3.php | 2 +-
apps/files_external/lib/backend/dropbox.php | 2 +-
apps/files_external/lib/backend/ftp.php | 2 +-
apps/files_external/lib/backend/google.php | 2 +-
apps/files_external/lib/backend/owncloud.php | 2 +-
apps/files_external/lib/backend/sftp.php | 2 +-
apps/files_external/lib/backend/sftp_key.php | 2 +-
apps/files_external/lib/backend/smb.php | 2 +-
apps/files_external/lib/backend/smb_oc.php | 2 +-
apps/files_external/lib/backend/swift.php | 2 +-
.../lib/{ => storage}/amazons3.php | 2 +-
.../lib/{ => storage}/dropbox.php | 4 +--
apps/files_external/lib/{ => storage}/ftp.php | 6 ++---
.../lib/{ => storage}/google.php | 4 +--
.../lib/{ => storage}/owncloud.php | 2 +-
.../files_external/lib/{ => storage}/sftp.php | 2 +-
apps/files_external/lib/{ => storage}/smb.php | 4 +--
.../lib/{ => storage}/streamwrapper.php | 4 +--
.../lib/{ => storage}/swift.php | 2 +-
.../tests/amazons3migration.php | 10 ++++---
.../controller/storagescontrollertest.php | 14 +++++-----
.../controller/userstoragescontrollertest.php | 4 +--
.../tests/owncloudfunctions.php | 6 ++---
.../tests/service/storagesservicetest.php | 6 ++---
.../amazons3.php => storage/amazons3test.php} | 12 +++++----
.../dropbox.php => storage/dropboxtest.php} | 12 +++++----
.../{backends/ftp.php => storage/ftptest.php} | 26 ++++++++++---------
.../google.php => storage/googletest.php} | 12 ++++-----
.../owncloud.php => storage/owncloudtest.php} | 12 +++++----
.../sftp_key.php => storage/sftp_keytest.php} | 12 +++++----
.../sftp.php => storage/sftptest.php} | 16 +++++++-----
.../{backends/smb.php => storage/smbtest.php} | 14 +++++-----
.../swift.php => storage/swifttest.php} | 12 +++++----
.../webdav.php => storage/webdavtest.php} | 12 +++++----
autotest-external.sh | 7 ++---
tests/phpunit-autotest-external.xml | 2 +-
37 files changed, 130 insertions(+), 118 deletions(-)
rename apps/files_external/lib/{ => storage}/amazons3.php (99%)
rename apps/files_external/lib/{ => storage}/dropbox.php (98%)
rename apps/files_external/lib/{ => storage}/ftp.php (96%)
rename apps/files_external/lib/{ => storage}/google.php (99%)
rename apps/files_external/lib/{ => storage}/owncloud.php (97%)
rename apps/files_external/lib/{ => storage}/sftp.php (99%)
rename apps/files_external/lib/{ => storage}/smb.php (99%)
rename apps/files_external/lib/{ => storage}/streamwrapper.php (96%)
rename apps/files_external/lib/{ => storage}/swift.php (99%)
rename apps/files_external/tests/{backends/amazons3.php => storage/amazons3test.php} (85%)
rename apps/files_external/tests/{backends/dropbox.php => storage/dropboxtest.php} (88%)
rename apps/files_external/tests/{backends/ftp.php => storage/ftptest.php} (83%)
rename apps/files_external/tests/{backends/google.php => storage/googletest.php} (85%)
rename apps/files_external/tests/{backends/owncloud.php => storage/owncloudtest.php} (84%)
rename apps/files_external/tests/{backends/sftp_key.php => storage/sftp_keytest.php} (90%)
rename apps/files_external/tests/{backends/sftp.php => storage/sftptest.php} (92%)
rename apps/files_external/tests/{backends/smb.php => storage/smbtest.php} (89%)
rename apps/files_external/tests/{backends/swift.php => storage/swifttest.php} (88%)
rename apps/files_external/tests/{backends/webdav.php => storage/webdavtest.php} (87%)
diff --git a/apps/files_external/appinfo/app.php b/apps/files_external/appinfo/app.php
index 46a4ecf0793..c98e772aa40 100644
--- a/apps/files_external/appinfo/app.php
+++ b/apps/files_external/appinfo/app.php
@@ -26,15 +26,6 @@
*
*/
-OC::$CLASSPATH['OC\Files\Storage\StreamWrapper'] = 'files_external/lib/streamwrapper.php';
-OC::$CLASSPATH['OC\Files\Storage\FTP'] = 'files_external/lib/ftp.php';
-OC::$CLASSPATH['OC\Files\Storage\OwnCloud'] = 'files_external/lib/owncloud.php';
-OC::$CLASSPATH['OC\Files\Storage\Google'] = 'files_external/lib/google.php';
-OC::$CLASSPATH['OC\Files\Storage\Swift'] = 'files_external/lib/swift.php';
-OC::$CLASSPATH['OC\Files\Storage\SMB'] = 'files_external/lib/smb.php';
-OC::$CLASSPATH['OC\Files\Storage\AmazonS3'] = 'files_external/lib/amazons3.php';
-OC::$CLASSPATH['OC\Files\Storage\Dropbox'] = 'files_external/lib/dropbox.php';
-OC::$CLASSPATH['OC\Files\Storage\SFTP'] = 'files_external/lib/sftp.php';
OC::$CLASSPATH['OC_Mount_Config'] = 'files_external/lib/config.php';
OC::$CLASSPATH['OCA\Files\External\Api'] = 'files_external/lib/api.php';
diff --git a/apps/files_external/lib/backend/amazons3.php b/apps/files_external/lib/backend/amazons3.php
index b2dedc10e4a..449b6c0379d 100644
--- a/apps/files_external/lib/backend/amazons3.php
+++ b/apps/files_external/lib/backend/amazons3.php
@@ -38,7 +38,7 @@ class AmazonS3 extends Backend {
$this
->setIdentifier('amazons3')
->addIdentifierAlias('\OC\Files\Storage\AmazonS3') // legacy compat
- ->setStorageClass('\OC\Files\Storage\AmazonS3')
+ ->setStorageClass('\OCA\Files_External\Lib\Storage\AmazonS3')
->setText($l->t('Amazon S3'))
->addParameters([
(new DefinitionParameter('bucket', $l->t('Bucket'))),
diff --git a/apps/files_external/lib/backend/dropbox.php b/apps/files_external/lib/backend/dropbox.php
index 7a414731192..f9156082515 100644
--- a/apps/files_external/lib/backend/dropbox.php
+++ b/apps/files_external/lib/backend/dropbox.php
@@ -38,7 +38,7 @@ class Dropbox extends Backend {
$this
->setIdentifier('dropbox')
->addIdentifierAlias('\OC\Files\Storage\Dropbox') // legacy compat
- ->setStorageClass('\OC\Files\Storage\Dropbox')
+ ->setStorageClass('\OCA\Files_External\Lib\Storage\Dropbox')
->setText($l->t('Dropbox'))
->addParameters([
// all parameters handled in OAuth1 mechanism
diff --git a/apps/files_external/lib/backend/ftp.php b/apps/files_external/lib/backend/ftp.php
index b2b83a27405..3960592d0bc 100644
--- a/apps/files_external/lib/backend/ftp.php
+++ b/apps/files_external/lib/backend/ftp.php
@@ -38,7 +38,7 @@ class FTP extends Backend {
$this
->setIdentifier('ftp')
->addIdentifierAlias('\OC\Files\Storage\FTP') // legacy compat
- ->setStorageClass('\OC\Files\Storage\FTP')
+ ->setStorageClass('\OCA\Files_External\Lib\Storage\FTP')
->setText($l->t('FTP'))
->addParameters([
(new DefinitionParameter('host', $l->t('Host'))),
diff --git a/apps/files_external/lib/backend/google.php b/apps/files_external/lib/backend/google.php
index 93a8cd2177d..b2b48a0e402 100644
--- a/apps/files_external/lib/backend/google.php
+++ b/apps/files_external/lib/backend/google.php
@@ -38,7 +38,7 @@ class Google extends Backend {
$this
->setIdentifier('googledrive')
->addIdentifierAlias('\OC\Files\Storage\Google') // legacy compat
- ->setStorageClass('\OC\Files\Storage\Google')
+ ->setStorageClass('\OCA\Files_External\Lib\Storage\Google')
->setText($l->t('Google Drive'))
->addParameters([
// all parameters handled in OAuth2 mechanism
diff --git a/apps/files_external/lib/backend/owncloud.php b/apps/files_external/lib/backend/owncloud.php
index e7da328c5f1..e92288b1354 100644
--- a/apps/files_external/lib/backend/owncloud.php
+++ b/apps/files_external/lib/backend/owncloud.php
@@ -35,7 +35,7 @@ class OwnCloud extends Backend {
$this
->setIdentifier('owncloud')
->addIdentifierAlias('\OC\Files\Storage\OwnCloud') // legacy compat
- ->setStorageClass('\OC\Files\Storage\OwnCloud')
+ ->setStorageClass('\OCA\Files_External\Lib\Storage\OwnCloud')
->setText($l->t('ownCloud'))
->addParameters([
(new DefinitionParameter('host', $l->t('URL'))),
diff --git a/apps/files_external/lib/backend/sftp.php b/apps/files_external/lib/backend/sftp.php
index 3e5ecb90131..fa33caeb576 100644
--- a/apps/files_external/lib/backend/sftp.php
+++ b/apps/files_external/lib/backend/sftp.php
@@ -35,7 +35,7 @@ class SFTP extends Backend {
$this
->setIdentifier('sftp')
->addIdentifierAlias('\OC\Files\Storage\SFTP') // legacy compat
- ->setStorageClass('\OC\Files\Storage\SFTP')
+ ->setStorageClass('\OCA\Files_External\Lib\Storage\SFTP')
->setText($l->t('SFTP'))
->addParameters([
(new DefinitionParameter('host', $l->t('Host'))),
diff --git a/apps/files_external/lib/backend/sftp_key.php b/apps/files_external/lib/backend/sftp_key.php
index 58dddedf784..838cf6c52b2 100644
--- a/apps/files_external/lib/backend/sftp_key.php
+++ b/apps/files_external/lib/backend/sftp_key.php
@@ -34,7 +34,7 @@ class SFTP_Key extends Backend {
public function __construct(IL10N $l, RSA $legacyAuth, SFTP $sftpBackend) {
$this
->setIdentifier('\OC\Files\Storage\SFTP_Key')
- ->setStorageClass('\OC\Files\Storage\SFTP')
+ ->setStorageClass('\OCA\Files_External\Lib\Storage\SFTP')
->setText($l->t('SFTP with secret key login'))
->addParameters([
(new DefinitionParameter('host', $l->t('Host'))),
diff --git a/apps/files_external/lib/backend/smb.php b/apps/files_external/lib/backend/smb.php
index 9b71636936a..7ea30dd11bd 100644
--- a/apps/files_external/lib/backend/smb.php
+++ b/apps/files_external/lib/backend/smb.php
@@ -40,7 +40,7 @@ class SMB extends Backend {
$this
->setIdentifier('smb')
->addIdentifierAlias('\OC\Files\Storage\SMB') // legacy compat
- ->setStorageClass('\OC\Files\Storage\SMB')
+ ->setStorageClass('\OCA\Files_External\Lib\Storage\SMB')
->setText($l->t('SMB / CIFS'))
->addParameters([
(new DefinitionParameter('host', $l->t('Host'))),
diff --git a/apps/files_external/lib/backend/smb_oc.php b/apps/files_external/lib/backend/smb_oc.php
index ba38754ce5a..c543a19bdd8 100644
--- a/apps/files_external/lib/backend/smb_oc.php
+++ b/apps/files_external/lib/backend/smb_oc.php
@@ -42,7 +42,7 @@ class SMB_OC extends Backend {
public function __construct(IL10N $l, SessionCredentials $legacyAuth, SMB $smbBackend) {
$this
->setIdentifier('\OC\Files\Storage\SMB_OC')
- ->setStorageClass('\OC\Files\Storage\SMB')
+ ->setStorageClass('\OCA\Files_External\Lib\Storage\SMB')
->setText($l->t('SMB / CIFS using OC login'))
->addParameters([
(new DefinitionParameter('host', $l->t('Host'))),
diff --git a/apps/files_external/lib/backend/swift.php b/apps/files_external/lib/backend/swift.php
index d6e4ac12f9a..58677575f52 100644
--- a/apps/files_external/lib/backend/swift.php
+++ b/apps/files_external/lib/backend/swift.php
@@ -38,7 +38,7 @@ class Swift extends Backend {
$this
->setIdentifier('swift')
->addIdentifierAlias('\OC\Files\Storage\Swift') // legacy compat
- ->setStorageClass('\OC\Files\Storage\Swift')
+ ->setStorageClass('\OCA\Files_External\Lib\Storage\Swift')
->setText($l->t('OpenStack Object Storage'))
->addParameters([
(new DefinitionParameter('service_name', $l->t('Service name')))
diff --git a/apps/files_external/lib/amazons3.php b/apps/files_external/lib/storage/amazons3.php
similarity index 99%
rename from apps/files_external/lib/amazons3.php
rename to apps/files_external/lib/storage/amazons3.php
index cb2082ee38b..42df1deffb0 100644
--- a/apps/files_external/lib/amazons3.php
+++ b/apps/files_external/lib/storage/amazons3.php
@@ -33,7 +33,7 @@
*
*/
-namespace OC\Files\Storage;
+namespace OCA\Files_External\Lib\Storage;
set_include_path(get_include_path() . PATH_SEPARATOR .
\OC_App::getAppPath('files_external') . '/3rdparty/aws-sdk-php');
diff --git a/apps/files_external/lib/dropbox.php b/apps/files_external/lib/storage/dropbox.php
similarity index 98%
rename from apps/files_external/lib/dropbox.php
rename to apps/files_external/lib/storage/dropbox.php
index 8381ccbae59..2d83fdbe0cb 100644
--- a/apps/files_external/lib/dropbox.php
+++ b/apps/files_external/lib/storage/dropbox.php
@@ -27,7 +27,7 @@
*
*/
-namespace OC\Files\Storage;
+namespace OCA\Files_External\Lib\Storage;
use GuzzleHttp\Exception\RequestException;
use Icewind\Streams\IteratorDirectory;
@@ -59,7 +59,7 @@ class Dropbox extends \OC\Files\Storage\Common {
// note: Dropbox_API connection is lazy
$this->dropbox = new \Dropbox_API($this->oauth, 'auto');
} else {
- throw new \Exception('Creating \OC\Files\Storage\Dropbox storage failed');
+ throw new \Exception('Creating Dropbox storage failed');
}
}
diff --git a/apps/files_external/lib/ftp.php b/apps/files_external/lib/storage/ftp.php
similarity index 96%
rename from apps/files_external/lib/ftp.php
rename to apps/files_external/lib/storage/ftp.php
index 7249aeceb5d..051c1873009 100644
--- a/apps/files_external/lib/ftp.php
+++ b/apps/files_external/lib/storage/ftp.php
@@ -28,11 +28,11 @@
*
*/
-namespace OC\Files\Storage;
+namespace OCA\Files_External\Lib\Storage;
use Icewind\Streams\RetryWrapper;
-class FTP extends \OC\Files\Storage\StreamWrapper{
+class FTP extends StreamWrapper{
private $password;
private $user;
private $host;
@@ -59,7 +59,7 @@ class FTP extends \OC\Files\Storage\StreamWrapper{
$this->root .= '/';
}
} else {
- throw new \Exception('Creating \OC\Files\Storage\FTP storage failed');
+ throw new \Exception('Creating FTP storage failed');
}
}
diff --git a/apps/files_external/lib/google.php b/apps/files_external/lib/storage/google.php
similarity index 99%
rename from apps/files_external/lib/google.php
rename to apps/files_external/lib/storage/google.php
index 62d264dfeef..8d1fe808130 100644
--- a/apps/files_external/lib/google.php
+++ b/apps/files_external/lib/storage/google.php
@@ -31,7 +31,7 @@
*
*/
-namespace OC\Files\Storage;
+namespace OCA\Files_External\Lib\Storage;
use GuzzleHttp\Exception\RequestException;
use Icewind\Streams\IteratorDirectory;
@@ -79,7 +79,7 @@ class Google extends \OC\Files\Storage\Common {
$token = json_decode($params['token'], true);
$this->id = 'google::'.substr($params['client_id'], 0, 30).$token['created'];
} else {
- throw new \Exception('Creating \OC\Files\Storage\Google storage failed');
+ throw new \Exception('Creating Google storage failed');
}
}
diff --git a/apps/files_external/lib/owncloud.php b/apps/files_external/lib/storage/owncloud.php
similarity index 97%
rename from apps/files_external/lib/owncloud.php
rename to apps/files_external/lib/storage/owncloud.php
index c4824e6bd14..22ecb4c806a 100644
--- a/apps/files_external/lib/owncloud.php
+++ b/apps/files_external/lib/storage/owncloud.php
@@ -21,7 +21,7 @@
*
*/
-namespace OC\Files\Storage;
+namespace OCA\Files_External\Lib\Storage;
/**
* ownCloud backend for external storage based on DAV backend.
diff --git a/apps/files_external/lib/sftp.php b/apps/files_external/lib/storage/sftp.php
similarity index 99%
rename from apps/files_external/lib/sftp.php
rename to apps/files_external/lib/storage/sftp.php
index a6984f3b4e0..2375f84dcda 100644
--- a/apps/files_external/lib/sftp.php
+++ b/apps/files_external/lib/storage/sftp.php
@@ -29,7 +29,7 @@
* along with this program. If not, see <http://www.gnu.org/licenses/>
*
*/
-namespace OC\Files\Storage;
+namespace OCA\Files_External\Lib\Storage;
use Icewind\Streams\IteratorDirectory;
use Icewind\Streams\RetryWrapper;
diff --git a/apps/files_external/lib/smb.php b/apps/files_external/lib/storage/smb.php
similarity index 99%
rename from apps/files_external/lib/smb.php
rename to apps/files_external/lib/storage/smb.php
index 08c4b25a088..4249d13168c 100644
--- a/apps/files_external/lib/smb.php
+++ b/apps/files_external/lib/storage/smb.php
@@ -28,7 +28,7 @@
*
*/
-namespace OC\Files\Storage;
+namespace OCA\Files_External\Lib\Storage;
use Icewind\SMB\Exception\ConnectException;
use Icewind\SMB\Exception\Exception;
@@ -42,7 +42,7 @@ use OC\Cache\CappedMemoryCache;
use OC\Files\Filesystem;
use OCP\Files\StorageNotAvailableException;
-class SMB extends Common {
+class SMB extends \OC\Files\Storage\Common {
/**
* @var \Icewind\SMB\Server
*/
diff --git a/apps/files_external/lib/streamwrapper.php b/apps/files_external/lib/storage/streamwrapper.php
similarity index 96%
rename from apps/files_external/lib/streamwrapper.php
rename to apps/files_external/lib/storage/streamwrapper.php
index efb51f32ba4..0b4dff78c4f 100644
--- a/apps/files_external/lib/streamwrapper.php
+++ b/apps/files_external/lib/storage/streamwrapper.php
@@ -24,9 +24,9 @@
*
*/
-namespace OC\Files\Storage;
+namespace OCA\Files_External\Lib\Storage;
-abstract class StreamWrapper extends Common {
+abstract class StreamWrapper extends \OC\Files\Storage\Common {
/**
* @param string $path
diff --git a/apps/files_external/lib/swift.php b/apps/files_external/lib/storage/swift.php
similarity index 99%
rename from apps/files_external/lib/swift.php
rename to apps/files_external/lib/storage/swift.php
index 9282fe28669..4578cd9a5c7 100644
--- a/apps/files_external/lib/swift.php
+++ b/apps/files_external/lib/storage/swift.php
@@ -32,7 +32,7 @@
*
*/
-namespace OC\Files\Storage;
+namespace OCA\Files_External\Lib\Storage;
use Guzzle\Http\Url;
use Guzzle\Http\Exception\ClientErrorResponseException;
diff --git a/apps/files_external/tests/amazons3migration.php b/apps/files_external/tests/amazons3migration.php
index d4ea9e2c261..614d6ca33df 100644
--- a/apps/files_external/tests/amazons3migration.php
+++ b/apps/files_external/tests/amazons3migration.php
@@ -24,14 +24,16 @@
*/
-namespace Test\Files\Storage;
+namespace OCA\Files_External\Tests;
+
+use OCA\Files_External\Lib\Storage\AmazonS3;
/**
* Class AmazonS3Migration
*
* @group DB
*
- * @package Test\Files\Storage
+ * @package OCA\Files_External\Tests
*/
class AmazonS3Migration extends \Test\TestCase {
@@ -77,7 +79,7 @@ class AmazonS3Migration extends \Test\TestCase {
$fileId = $oldCache->put('foobar', array('size' => 0, 'mtime' => time(), 'mimetype' => 'httpd/directory'));
try {
- $this->instance = new \OC\Files\Storage\AmazonS3($this->params);
+ $this->instance = new AmazonS3($this->params);
} catch (\Exception $e) {
//ignore
}
@@ -103,7 +105,7 @@ class AmazonS3Migration extends \Test\TestCase {
$fileId = $oldCache->put('/', array('size' => 0, 'mtime' => time(), 'mimetype' => 'httpd/directory'));
try {
- $this->instance = new \OC\Files\Storage\AmazonS3($this->params);
+ $this->instance = new AmazonS3($this->params);
} catch (\Exception $e) {
//ignore
}
diff --git a/apps/files_external/tests/controller/storagescontrollertest.php b/apps/files_external/tests/controller/storagescontrollertest.php
index 5854cb00fee..4c3c62d5d6f 100644
--- a/apps/files_external/tests/controller/storagescontrollertest.php
+++ b/apps/files_external/tests/controller/storagescontrollertest.php
@@ -51,7 +51,7 @@ abstract class StoragesControllerTest extends \Test\TestCase {
/**
* @return \OCA\Files_External\Lib\Backend\Backend
*/
- protected function getBackendMock($class = '\OCA\Files_External\Lib\Backend\SMB', $storageClass = '\OC\Files\Storage\SMB') {
+ protected function getBackendMock($class = '\OCA\Files_External\Lib\Backend\SMB', $storageClass = '\OCA\Files_External\Lib\Storage\SMB') {
$backend = $this->getMockBuilder('\OCA\Files_External\Lib\Backend\Backend')
->disableOriginalConstructor()
->getMock();
@@ -104,7 +104,7 @@ abstract class StoragesControllerTest extends \Test\TestCase {
$response = $this->controller->create(
'mount',
- '\OC\Files\Storage\SMB',
+ '\OCA\Files_External\Lib\Storage\SMB',
'\OCA\Files_External\Lib\Auth\NullMechanism',
array(),
[],
@@ -146,7 +146,7 @@ abstract class StoragesControllerTest extends \Test\TestCase {
$response = $this->controller->update(
1,
'mount',
- '\OC\Files\Storage\SMB',
+ '\OCA\Files_External\Lib\Storage\SMB',
'\OCA\Files_External\Lib\Auth\NullMechanism',
array(),
[],
@@ -188,7 +188,7 @@ abstract class StoragesControllerTest extends \Test\TestCase {
$response = $this->controller->create(
$mountPoint,
- '\OC\Files\Storage\SMB',
+ '\OCA\Files_External\Lib\Storage\SMB',
'\OCA\Files_External\Lib\Auth\NullMechanism',
array(),
[],
@@ -202,7 +202,7 @@ abstract class StoragesControllerTest extends \Test\TestCase {
$response = $this->controller->update(
1,
$mountPoint,
- '\OC\Files\Storage\SMB',
+ '\OCA\Files_External\Lib\Storage\SMB',
'\OCA\Files_External\Lib\Auth\NullMechanism',
array(),
[],
@@ -279,7 +279,7 @@ abstract class StoragesControllerTest extends \Test\TestCase {
$response = $this->controller->update(
255,
'mount',
- '\OC\Files\Storage\SMB',
+ '\OCA\Files_External\Lib\Storage\SMB',
'\OCA\Files_External\Lib\Auth\NullMechanism',
array(),
[],
@@ -375,7 +375,7 @@ abstract class StoragesControllerTest extends \Test\TestCase {
$response = $this->controller->create(
'mount',
- '\OC\Files\Storage\SMB',
+ '\OCA\Files_External\Lib\Storage\SMB',
'\OCA\Files_External\Lib\Auth\NullMechanism',
array(),
[],
diff --git a/apps/files_external/tests/controller/userstoragescontrollertest.php b/apps/files_external/tests/controller/userstoragescontrollertest.php
index a7e854471b5..804b752b6af 100644
--- a/apps/files_external/tests/controller/userstoragescontrollertest.php
+++ b/apps/files_external/tests/controller/userstoragescontrollertest.php
@@ -78,7 +78,7 @@ class UserStoragesControllerTest extends StoragesControllerTest {
$response = $this->controller->create(
'mount',
- '\OC\Files\Storage\SMB',
+ '\OCA\Files_External\Lib\Storage\SMB',
'\Auth\Mechanism',
array(),
[],
@@ -92,7 +92,7 @@ class UserStoragesControllerTest extends StoragesControllerTest {
$response = $this->controller->update(
1,
'mount',
- '\OC\Files\Storage\SMB',
+ '\OCA\Files_External\Lib\Storage\SMB',
'\Auth\Mechanism',
array(),
[],
diff --git a/apps/files_external/tests/owncloudfunctions.php b/apps/files_external/tests/owncloudfunctions.php
index 019f988275e..25aaa90d178 100644
--- a/apps/files_external/tests/owncloudfunctions.php
+++ b/apps/files_external/tests/owncloudfunctions.php
@@ -23,14 +23,14 @@
*
*/
-namespace Test\Files\Storage;
+namespace OCA\Files_External\Tests;
/**
* Class OwnCloudFunctions
*
* @group DB
*
- * @package Test\Files\Storage
+ * @package OCA\Files_External\Tests
*/
class OwnCloudFunctions extends \Test\TestCase {
@@ -109,7 +109,7 @@ class OwnCloudFunctions extends \Test\TestCase {
public function testConfig($config, $expectedUri) {
$config['user'] = 'someuser';
$config['password'] = 'somepassword';
- $instance = new \OC\Files\Storage\OwnCloud($config);
+ $instance = new \OCA\Files_External\Lib\Storage\OwnCloud($config);
$this->assertEquals($expectedUri, $instance->createBaseUri());
}
}
diff --git a/apps/files_external/tests/service/storagesservicetest.php b/apps/files_external/tests/service/storagesservicetest.php
index 3fbe3b755e1..f93c0134814 100644
--- a/apps/files_external/tests/service/storagesservicetest.php
+++ b/apps/files_external/tests/service/storagesservicetest.php
@@ -121,9 +121,9 @@ abstract class StoragesServiceTest extends \Test\TestCase {
$this->backendService->method('getAuthMechanisms')
->will($this->returnValue($authMechanisms));
- $sftpBackend = $this->getBackendMock('\OCA\Files_External\Lib\Backend\SFTP', '\OC\Files\Storage\SFTP');
+ $sftpBackend = $this->getBackendMock('\OCA\Files_External\Lib\Backend\SFTP', '\OCA\Files_External\Lib\Storage\SFTP');
$backends = [
- 'identifier:\OCA\Files_External\Lib\Backend\SMB' => $this->getBackendMock('\OCA\Files_External\Lib\Backend\SMB', '\OC\Files\Storage\SMB'),
+ 'identifier:\OCA\Files_External\Lib\Backend\SMB' => $this->getBackendMock('\OCA\Files_External\Lib\Backend\SMB', '\OCA\Files_External\Lib\Storage\SMB'),
'identifier:\OCA\Files_External\Lib\Backend\SFTP' => $sftpBackend,
'identifier:sftp_alias' => $sftpBackend,
];
@@ -171,7 +171,7 @@ abstract class StoragesServiceTest extends \Test\TestCase {
}
}
- protected function getBackendMock($class = '\OCA\Files_External\Lib\Backend\SMB', $storageClass = '\OC\Files\Storage\SMB') {
+ protected function getBackendMock($class = '\OCA\Files_External\Lib\Backend\SMB', $storageClass = '\OCA\Files_External\Lib\Storage\SMB') {
$backend = $this->getMockBuilder('\OCA\Files_External\Lib\Backend\Backend')
->disableOriginalConstructor()
->getMock();
diff --git a/apps/files_external/tests/backends/amazons3.php b/apps/files_external/tests/storage/amazons3test.php
similarity index 85%
rename from apps/files_external/tests/backends/amazons3.php
rename to apps/files_external/tests/storage/amazons3test.php
index 3b43f81a926..eb0e410764c 100644
--- a/apps/files_external/tests/backends/amazons3.php
+++ b/apps/files_external/tests/storage/amazons3test.php
@@ -24,16 +24,18 @@
*
*/
-namespace Test\Files\Storage;
+namespace OCA\Files_External\Tests\Storage;
+
+use \OCA\Files_External\Lib\Storage\AmazonS3;
/**
- * Class AmazonS3
+ * Class AmazonS3Test
*
* @group DB
*
- * @package Test\Files\Storage
+ * @package OCA\Files_External\Tests\Storage
*/
-class AmazonS3 extends Storage {
+class AmazonS3Test extends \Test\Files\Storage\Storage {
private $config;
@@ -44,7 +46,7 @@ class AmazonS3 extends Storage {
if ( ! is_array($this->config) or ! $this->config['run']) {
$this->markTestSkipped('AmazonS3 backend not configured');
}
- $this->instance = new \OC\Files\Storage\AmazonS3($this->config);
+ $this->instance = new AmazonS3($this->config);
}
protected function tearDown() {
diff --git a/apps/files_external/tests/backends/dropbox.php b/apps/files_external/tests/storage/dropboxtest.php
similarity index 88%
rename from apps/files_external/tests/backends/dropbox.php
rename to apps/files_external/tests/storage/dropboxtest.php
index 1bf8b4171fb..d466d4b1b44 100644
--- a/apps/files_external/tests/backends/dropbox.php
+++ b/apps/files_external/tests/storage/dropboxtest.php
@@ -24,16 +24,18 @@
*
*/
-namespace Test\Files\Storage;
+namespace OCA\Files_External\Tests\Storage;
+
+use \OCA\Files_External\Lib\Storage\Dropbox;
/**
- * Class Dropbox
+ * Class DropboxTest
*
* @group DB
*
- * @package Test\Files\Storage
+ * @package OCA\Files_External\Tests\Storage
*/
-class Dropbox extends Storage {
+class DropboxTest extends \Test\Files\Storage\Storage {
private $config;
protected function setUp() {
@@ -45,7 +47,7 @@ class Dropbox extends Storage {
$this->markTestSkipped('Dropbox backend not configured');
}
$this->config['dropbox']['root'] .= '/' . $id; //make sure we have an new empty folder to work in
- $this->instance = new \OC\Files\Storage\Dropbox($this->config['dropbox']);
+ $this->instance = new Dropbox($this->config['dropbox']);
}
protected function tearDown() {
diff --git a/apps/files_external/tests/backends/ftp.php b/apps/files_external/tests/storage/ftptest.php
similarity index 83%
rename from apps/files_external/tests/backends/ftp.php
rename to apps/files_external/tests/storage/ftptest.php
index 868a022d38f..9af9ccff012 100644
--- a/apps/files_external/tests/backends/ftp.php
+++ b/apps/files_external/tests/storage/ftptest.php
@@ -24,16 +24,18 @@
*
*/
-namespace Test\Files\Storage;
+namespace OCA\Files_External\Tests\Storage;
+
+use \OCA\Files_External\Lib\Storage\FTP;
/**
- * Class FTP
+ * Class FTPTest
*
* @group DB
*
- * @package Test\Files\Storage
+ * @package OCA\Files_External\Tests\Storage
*/
-class FTP extends Storage {
+class FTPTest extends \Test\Files\Storage\Storage {
private $config;
protected function setUp() {
@@ -45,7 +47,7 @@ class FTP extends Storage {
$this->markTestSkipped('FTP backend not configured');
}
$this->config['root'] .= '/' . $id; //make sure we have an new empty folder to work in
- $this->instance = new \OC\Files\Storage\FTP($this->config);
+ $this->instance = new FTP($this->config);
$this->instance->mkdir('/');
}
@@ -63,31 +65,31 @@ class FTP extends Storage {
'password' => 'ftp',
'root' => '/',
'secure' => false );
- $instance = new \OC\Files\Storage\FTP($config);
+ $instance = new FTP($config);
$this->assertEquals('ftp://ftp:ftp@localhost/', $instance->constructUrl(''));
$config['secure'] = true;
- $instance = new \OC\Files\Storage\FTP($config);
+ $instance = new FTP($config);
$this->assertEquals('ftps://ftp:ftp@localhost/', $instance->constructUrl(''));
$config['secure'] = 'false';
- $instance = new \OC\Files\Storage\FTP($config);
+ $instance = new FTP($config);
$this->assertEquals('ftp://ftp:ftp@localhost/', $instance->constructUrl(''));
$config['secure'] = 'true';
- $instance = new \OC\Files\Storage\FTP($config);
+ $instance = new FTP($config);
$this->assertEquals('ftps://ftp:ftp@localhost/', $instance->constructUrl(''));
$config['root'] = '';
- $instance = new \OC\Files\Storage\FTP($config);
+ $instance = new FTP($config);
$this->assertEquals('ftps://ftp:ftp@localhost/somefile.txt', $instance->constructUrl('somefile.txt'));
$config['root'] = '/abc';
- $instance = new \OC\Files\Storage\FTP($config);
+ $instance = new FTP($config);
$this->assertEquals('ftps://ftp:ftp@localhost/abc/somefile.txt', $instance->constructUrl('somefile.txt'));
$config['root'] = '/abc/';
- $instance = new \OC\Files\Storage\FTP($config);
+ $instance = new FTP($config);
$this->assertEquals('ftps://ftp:ftp@localhost/abc/somefile.txt', $instance->constructUrl('somefile.txt'));
}
}
diff --git a/apps/files_external/tests/backends/google.php b/apps/files_external/tests/storage/googletest.php
similarity index 85%
rename from apps/files_external/tests/backends/google.php
rename to apps/files_external/tests/storage/googletest.php
index 7622f796407..46aa4555b12 100644
--- a/apps/files_external/tests/backends/google.php
+++ b/apps/files_external/tests/storage/googletest.php
@@ -25,18 +25,18 @@
*
*/
-namespace Test\Files\Storage;
+namespace OCA\Files_External\Tests\Storage;
-require_once 'files_external/lib/google.php';
+use \OCA\Files_External\Lib\Storage\Google;
/**
- * Class Google
+ * Class GoogleTest
*
* @group DB
*
- * @package Test\Files\Storage
+ * @package OCA\Files_External\Tests\Storage
*/
-class Google extends Storage {
+class GoogleTest extends \Test\Files\Storage\Storage {
private $config;
@@ -49,7 +49,7 @@ class Google extends Storage {
) {
$this->markTestSkipped('Google Drive backend not configured');
}
- $this->instance = new \OC\Files\Storage\Google($this->config['google']);
+ $this->instance = new Google($this->config['google']);
}
protected function tearDown() {
diff --git a/apps/files_external/tests/backends/owncloud.php b/apps/files_external/tests/storage/owncloudtest.php
similarity index 84%
rename from apps/files_external/tests/backends/owncloud.php
rename to apps/files_external/tests/storage/owncloudtest.php
index a56e9b2a186..cbc25e46fa0 100644
--- a/apps/files_external/tests/backends/owncloud.php
+++ b/apps/files_external/tests/storage/owncloudtest.php
@@ -22,16 +22,18 @@
*
*/
-namespace Test\Files\Storage;
+namespace OCA\Files_External\Tests\Storage;
+
+use \OCA\Files_External\Lib\Storage\OwnCloud;
/**
- * Class OwnCloud
+ * Class OwnCloudTest
*
* @group DB
*
- * @package Test\Files\Storage
+ * @package OCA\Files_External\Tests\Storage
*/
-class OwnCloud extends Storage {
+class OwnCloudTest extends \Test\Files\Storage\Storage {
private $config;
@@ -44,7 +46,7 @@ class OwnCloud extends Storage {
$this->markTestSkipped('ownCloud backend not configured');
}
$this->config['owncloud']['root'] .= '/' . $id; //make sure we have an new empty folder to work in
- $this->instance = new \OC\Files\Storage\OwnCloud($this->config['owncloud']);
+ $this->instance = new OwnCloud($this->config['owncloud']);
$this->instance->mkdir('/');
}
diff --git a/apps/files_external/tests/backends/sftp_key.php b/apps/files_external/tests/storage/sftp_keytest.php
similarity index 90%
rename from apps/files_external/tests/backends/sftp_key.php
rename to apps/files_external/tests/storage/sftp_keytest.php
index 73c6a0b6432..b974f88555f 100644
--- a/apps/files_external/tests/backends/sftp_key.php
+++ b/apps/files_external/tests/storage/sftp_keytest.php
@@ -22,16 +22,18 @@
*
*/
-namespace Test\Files\Storage;
+namespace OCA\Files_External\Tests\Storage;
+
+use \OCA\Files_External\Lib\Storage\SFTP_Key;
/**
- * Class SFTP_Key
+ * Class SFTP_KeyTest
*
* @group DB
*
- * @package Test\Files\Storage
+ * @package OCA\Files_External\Tests\Storage
*/
-class SFTP_Key extends Storage {
+class SFTP_KeyTest extends \Test\Files\Storage\Storage {
private $config;
protected function setUp() {
@@ -44,7 +46,7 @@ class SFTP_Key extends Storage {
}
// Make sure we have an new empty folder to work in
$this->config['sftp_key']['root'] .= '/' . $id;
- $this->instance = new \OC\Files\Storage\SFTP_Key($this->config['sftp_key']);
+ $this->instance = new SFTP_Key($this->config['sftp_key']);
$this->instance->mkdir('/');
}
diff --git a/apps/files_external/tests/backends/sftp.php b/apps/files_external/tests/storage/sftptest.php
similarity index 92%
rename from apps/files_external/tests/backends/sftp.php
rename to apps/files_external/tests/storage/sftptest.php
index 608982adbc4..329e93819fc 100644
--- a/apps/files_external/tests/backends/sftp.php
+++ b/apps/files_external/tests/storage/sftptest.php
@@ -24,18 +24,20 @@
*
*/
-namespace Test\Files\Storage;
+namespace OCA\Files_External\Tests\Storage;
+
+use \OCA\Files_External\Lib\Storage\SFTP;
/**
- * Class SFTP
+ * Class SFTPTest
*
* @group DB
*
- * @package Test\Files\Storage
+ * @package OCA\Files_External\Tests\Storage
*/
-class SFTP extends Storage {
+class SFTPTest extends \Test\Files\Storage\Storage {
/**
- * @var \OC\Files\Storage\SFTP instance
+ * @var SFTP instance
*/
protected $instance;
@@ -50,7 +52,7 @@ class SFTP extends Storage {
$this->markTestSkipped('SFTP backend not configured');
}
$this->config['root'] .= '/' . $id; //make sure we have an new empty folder to work in
- $this->instance = new \OC\Files\Storage\SFTP($this->config);
+ $this->instance = new SFTP($this->config);
$this->instance->mkdir('/');
}
@@ -66,7 +68,7 @@ class SFTP extends Storage {
* @dataProvider configProvider
*/
public function testStorageId($config, $expectedStorageId) {
- $instance = new \OC\Files\Storage\SFTP($config);
+ $instance = new SFTP($config);
$this->assertEquals($expectedStorageId, $instance->getId());
}
diff --git a/apps/files_external/tests/backends/smb.php b/apps/files_external/tests/storage/smbtest.php
similarity index 89%
rename from apps/files_external/tests/backends/smb.php
rename to apps/files_external/tests/storage/smbtest.php
index f9a377c271b..fc2795702c6 100644
--- a/apps/files_external/tests/backends/smb.php
+++ b/apps/files_external/tests/storage/smbtest.php
@@ -23,16 +23,18 @@
*
*/
-namespace Test\Files\Storage;
+namespace OCA\Files_External\Tests\Storage;
+
+use \OCA\Files_External\Lib\Storage\SMB;
/**
- * Class SMB
+ * Class SMBTest
*
* @group DB
*
- * @package Test\Files\Storage
+ * @package OCA\Files_External\Tests\Storage
*/
-class SMB extends Storage {
+class SMBTest extends \Test\Files\Storage\Storage {
protected function setUp() {
parent::setUp();
@@ -46,7 +48,7 @@ class SMB extends Storage {
$config['root'] .= '/';
}
$config['root'] .= $id; //make sure we have an new empty folder to work in
- $this->instance = new \OC\Files\Storage\SMB($config);
+ $this->instance = new SMB($config);
$this->instance->mkdir('/');
}
@@ -71,7 +73,7 @@ class SMB extends Storage {
}
public function testStorageId() {
- $this->instance = new \OC\Files\Storage\SMB([
+ $this->instance = new SMB([
'host' => 'testhost',
'user' => 'testuser',
'password' => 'somepass',
diff --git a/apps/files_external/tests/backends/swift.php b/apps/files_external/tests/storage/swifttest.php
similarity index 88%
rename from apps/files_external/tests/backends/swift.php
rename to apps/files_external/tests/storage/swifttest.php
index 9bdcd48ee68..1bcbb815067 100644
--- a/apps/files_external/tests/backends/swift.php
+++ b/apps/files_external/tests/storage/swifttest.php
@@ -24,16 +24,18 @@
*
*/
-namespace Test\Files\Storage;
+namespace OCA\Files_External\Tests\Storage;
+
+use \OCA\Files_External\Lib\Storage\Swift;
/**
- * Class Swift
+ * Class SwiftTest
*
* @group DB
*
- * @package Test\Files\Storage
+ * @package OCA\Files_External\Tests\Storage
*/
-class Swift extends Storage {
+class SwiftTest extends \Test\Files\Storage\Storage {
private $config;
@@ -44,7 +46,7 @@ class Swift extends Storage {
if (!is_array($this->config) or !$this->config['run']) {
$this->markTestSkipped('OpenStack Object Storage backend not configured');
}
- $this->instance = new \OC\Files\Storage\Swift($this->config);
+ $this->instance = new Swift($this->config);
}
protected function tearDown() {
diff --git a/apps/files_external/tests/backends/webdav.php b/apps/files_external/tests/storage/webdavtest.php
similarity index 87%
rename from apps/files_external/tests/backends/webdav.php
rename to apps/files_external/tests/storage/webdavtest.php
index e1a710c94b4..f8c5b19e04f 100644
--- a/apps/files_external/tests/backends/webdav.php
+++ b/apps/files_external/tests/storage/webdavtest.php
@@ -23,16 +23,18 @@
*
*/
-namespace Test\Files\Storage;
+namespace OCA\Files_External\Tests\Storage;
+
+use \OC\Files\Storage\DAV;
/**
- * Class DAV
+ * Class WebDAVTest
*
* @group DB
*
- * @package Test\Files\Storage
+ * @package OCA\Files_External\Tests\Storage
*/
-class DAV extends Storage {
+class WebDAVTest extends \Test\Files\Storage\Storage {
protected function setUp() {
parent::setUp();
@@ -46,7 +48,7 @@ class DAV extends Storage {
$this->waitDelay = $config['wait'];
}
$config['root'] .= '/' . $id; //make sure we have an new empty folder to work in
- $this->instance = new \OC\Files\Storage\DAV($config);
+ $this->instance = new DAV($config);
$this->instance->mkdir('/');
}
diff --git a/autotest-external.sh b/autotest-external.sh
index ef6516c0721..9705980aa2b 100755
--- a/autotest-external.sh
+++ b/autotest-external.sh
@@ -178,7 +178,7 @@ EOF
return;
fi
- FILES_EXTERNAL_BACKEND_PATH=../apps/files_external/tests/backends
+ FILES_EXTERNAL_BACKEND_PATH=../apps/files_external/tests/storage
FILES_EXTERNAL_BACKEND_ENV_PATH=../apps/files_external/tests/env
for startFile in `ls -1 $FILES_EXTERNAL_BACKEND_ENV_PATH | grep start`; do
@@ -198,16 +198,17 @@ EOF
# getting backend to test from filename
# it's the part between the dots startSomething.TestToRun.sh
testToRun=`echo $startFile | cut -d '-' -f 2`
+ testToRun="${testToRun}test.php"
# run the specific test
if [ -z "$NOCOVERAGE" ]; then
rm -rf "coverage-external-html-$1-$name"
mkdir "coverage-external-html-$1-$name"
- "$PHPUNIT" --configuration phpunit-autotest-external.xml --log-junit "autotest-external-results-$1-$name.xml" --coverage-clover "autotest-external-clover-$1-$name.xml" --coverage-html "coverage-external-html-$1-$name" "$FILES_EXTERNAL_BACKEND_PATH/$testToRun.php"
+ "$PHPUNIT" --configuration phpunit-autotest-external.xml --log-junit "autotest-external-results-$1-$name.xml" --coverage-clover "autotest-external-clover-$1-$name.xml" --coverage-html "coverage-external-html-$1-$name" "$FILES_EXTERNAL_BACKEND_PATH/$testToRun"
RESULT=$?
else
echo "No coverage"
- "$PHPUNIT" --configuration phpunit-autotest-external.xml --log-junit "autotest-external-results-$1-$name.xml" "$FILES_EXTERNAL_BACKEND_PATH/$testToRun.php"
+ "$PHPUNIT" --configuration phpunit-autotest-external.xml --log-junit "autotest-external-results-$1-$name.xml" "$FILES_EXTERNAL_BACKEND_PATH/$testToRun"
RESULT=$?
fi
else
diff --git a/tests/phpunit-autotest-external.xml b/tests/phpunit-autotest-external.xml
index 31d2e395a01..1b48c4dc11e 100644
--- a/tests/phpunit-autotest-external.xml
+++ b/tests/phpunit-autotest-external.xml
@@ -8,7 +8,7 @@
<testsuite name='ownCloud files external'>
<directory suffix=".php">../apps/files_external/tests</directory>
<!-- exclude backends as they are called separately -->
- <exclude>../apps/files_external/tests/backends/</exclude>
+ <exclude>../apps/files_external/tests/storage/</exclude>
</testsuite>
<!-- filters for code coverage -->
<filter>
--
GitLab