From 4ff11e395519987af95ffc62d7a8f0094b6978ff Mon Sep 17 00:00:00 2001
From: Christoph Wurst <christoph@winzerhof-wurst.at>
Date: Thu, 19 Dec 2019 09:38:22 +0100
Subject: [PATCH] Do not generate tokens for editor IDs that do not exist
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
---
lib/private/DirectEditing/Manager.php | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/lib/private/DirectEditing/Manager.php b/lib/private/DirectEditing/Manager.php
index a739402d629..a514eaea482 100644
--- a/lib/private/DirectEditing/Manager.php
+++ b/lib/private/DirectEditing/Manager.php
@@ -45,6 +45,8 @@ use OCP\IUserSession;
use OCP\L10N\IFactory;
use OCP\Security\ISecureRandom;
use OCP\Share\IShare;
+use function array_key_exists;
+use function in_array;
class Manager implements IManager {
@@ -140,6 +142,9 @@ class Manager implements IManager {
if ($editorId === null) {
$editorId = $this->findEditorForFile($file);
}
+ if (!array_key_exists($editorId, $this->editors)) {
+ throw new \RuntimeException("Editor $editorId is unknown");
+ }
return $this->createToken($editorId, $file, $filePath);
}
--
GitLab