From 5f1713f9db76ee62bcd7cbe4a0f1227c75b00e3d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= <danxuliu@gmail.com>
Date: Thu, 27 Feb 2020 10:25:58 +0100
Subject: [PATCH] Set loading image on replaced elements instead of on their
descendants
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Replaced elements do not have "::after" nor "::before" pseudo-elements,
so the regular loading icon needs to be shown using a background image
instead of the default "::after" pseudo-element approach. However, the
CSS rules were not applied on the replaced elements themselves, but on
their descendants. As the descendants might have support for
pseudo-elements the rules were fixed to be applied on the replaced
elements, and only on the replaced elements.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
---
core/css/icons.scss | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/core/css/icons.scss b/core/css/icons.scss
index 2dbd08f61d9..53ae4d77118 100644
--- a/core/css/icons.scss
+++ b/core/css/icons.scss
@@ -82,16 +82,16 @@
/* Css replaced elements don't have ::after nor ::before */
img, object, video, button, textarea, input, select, div[contenteditable='true'] {
- .icon-loading {
+ &.icon-loading {
background-image: url('../img/loading.gif');
}
- .icon-loading-dark {
+ &.icon-loading-dark {
background-image: url('../img/loading-dark.gif');
}
- .icon-loading-small {
+ &.icon-loading-small {
background-image: url('../img/loading-small.gif');
}
- .icon-loading-small-dark {
+ &.icon-loading-small-dark {
background-image: url('../img/loading-small-dark.gif');
}
}
--
GitLab