diff --git a/apps/files_external/lib/Controller/AjaxController.php b/apps/files_external/lib/Controller/AjaxController.php index 9c2953851f53697b588fa5ccf8f5db0018a240d5..66cbcae3e8fa74eebf3259211207a1aebe7ddcd6 100644 --- a/apps/files_external/lib/Controller/AjaxController.php +++ b/apps/files_external/lib/Controller/AjaxController.php @@ -110,9 +110,7 @@ class AjaxController extends Controller { $currentUser = $this->userSession->getUser(); // Non-admins can only edit their own credentials - $allowedToEdit = ( - $this->groupManager->isAdmin($currentUser->getUID()) || $currentUser->getUID() === $uid - ) ? true : false; + $allowedToEdit = ($this->groupManager->isAdmin($currentUser->getUID()) || $currentUser->getUID() === $uid); if ($allowedToEdit) { $this->globalAuth->saveAuth($uid, $user, $password); diff --git a/apps/files_sharing/lib/Controller/ShareController.php b/apps/files_sharing/lib/Controller/ShareController.php index c51bc1a75ddabfad5eee77c59907cc0586ca02a4..fdd69987658a65341503c772b1a3c33e003d98bd 100644 --- a/apps/files_sharing/lib/Controller/ShareController.php +++ b/apps/files_sharing/lib/Controller/ShareController.php @@ -348,7 +348,7 @@ class ShareController extends Controller { $freeSpace = (INF > 0) ? INF: PHP_INT_MAX; // work around https://bugs.php.net/bug.php?id=69188 } - $hideFileList = $share->getPermissions() & \OCP\Constants::PERMISSION_READ ? false : true; + $hideFileList = !($share->getPermissions() & \OCP\Constants::PERMISSION_READ); $maxUploadFilesize = $freeSpace; $folder = new Template('files', 'list', ''); diff --git a/apps/user_ldap/lib/Jobs/CleanUp.php b/apps/user_ldap/lib/Jobs/CleanUp.php index 14682c65ce1f5038aed2ff8b8501048dda2bb941..df7d888a9028433653a9a3f1e30d1d6a35fb1db5 100644 --- a/apps/user_ldap/lib/Jobs/CleanUp.php +++ b/apps/user_ldap/lib/Jobs/CleanUp.php @@ -156,7 +156,7 @@ class CleanUp extends TimedJob { * @return bool */ public function isOffsetResetNecessary($resultCount) { - return ($resultCount < $this->limit) ? true : false; + return $resultCount < $this->limit; } /** diff --git a/lib/private/Encryption/Util.php b/lib/private/Encryption/Util.php index 047ef1626df707d338c6306cce2d8d21eb0ba47a..fc0adbbd47b1a79b67b0296248b69a1f2a9beea0 100644 --- a/lib/private/Encryption/Util.php +++ b/lib/private/Encryption/Util.php @@ -384,7 +384,7 @@ class Util { public function recoveryEnabled($uid) { $enabled = $this->config->getUserValue($uid, 'encryption', 'recovery_enabled', '0'); - return ($enabled === '1') ? true : false; + return $enabled === '1'; } /** diff --git a/lib/private/Files/Storage/Wrapper/Encryption.php b/lib/private/Files/Storage/Wrapper/Encryption.php index d443ccfd49b77e575912d6c234c83d08683b4b74..e40a48309537db1ba346fc0e851193aa4ef292cd 100644 --- a/lib/private/Files/Storage/Wrapper/Encryption.php +++ b/lib/private/Files/Storage/Wrapper/Encryption.php @@ -379,7 +379,7 @@ class Encryption extends Wrapper { $shouldEncrypt = false; $encryptionModule = null; $header = $this->getHeader($path); - $signed = (isset($header['signed']) && $header['signed'] === 'true') ? true : false; + $signed = isset($header['signed']) && $header['signed'] === 'true'; $fullPath = $this->getFullPath($path); $encryptionModuleId = $this->util->getEncryptionModuleId($header); @@ -544,7 +544,7 @@ class Encryption extends Wrapper { return 0; } - $signed = (isset($header['signed']) && $header['signed'] === 'true') ? true : false; + $signed = isset($header['signed']) && $header['signed'] === 'true'; $unencryptedBlockSize = $encryptionModule->getUnencryptedBlockSize($signed); // calculate last chunk nr diff --git a/lib/private/Memcache/Redis.php b/lib/private/Memcache/Redis.php index 9cc61114b0025e329194fb96e3727510d20c03cb..adf3c5050bd0a9209716f8e6b9a19ffcd4b81ca9 100644 --- a/lib/private/Memcache/Redis.php +++ b/lib/private/Memcache/Redis.php @@ -145,7 +145,7 @@ class Redis extends Cache implements IMemcacheTTL { $result = self::$cache->multi() ->set($this->getNameSpace() . $key, $new) ->exec(); - return ($result === false) ? false : true; + return $result !== false; } self::$cache->unwatch(); return false; @@ -164,7 +164,7 @@ class Redis extends Cache implements IMemcacheTTL { $result = self::$cache->multi() ->del($this->getNameSpace() . $key) ->exec(); - return ($result === false) ? false : true; + return $result !== false; } self::$cache->unwatch(); return false; diff --git a/lib/private/Settings/Admin/Sharing.php b/lib/private/Settings/Admin/Sharing.php index a99ba453d67f1b297dd4439a0f816c5aa1a6bc9d..dbdacf78dab0f5740db2b68c9a7e9adcebe44aa0 100644 --- a/lib/private/Settings/Admin/Sharing.php +++ b/lib/private/Settings/Admin/Sharing.php @@ -64,7 +64,7 @@ class Sharing implements ISettings { 'shareDefaultExpireDateSet' => $this->config->getAppValue('core', 'shareapi_default_expire_date', 'no'), 'shareExpireAfterNDays' => $this->config->getAppValue('core', 'shareapi_expire_after_n_days', '7'), 'shareEnforceExpireDate' => $this->config->getAppValue('core', 'shareapi_enforce_expire_date', 'no'), - 'shareExcludeGroups' => $this->config->getAppValue('core', 'shareapi_exclude_groups', 'no') === 'yes' ? true : false, + 'shareExcludeGroups' => $this->config->getAppValue('core', 'shareapi_exclude_groups', 'no') === 'yes', 'shareExcludedGroupsList' => $excludeGroupsList, 'publicShareDisclaimerText' => $this->config->getAppValue('core', 'shareapi_public_link_disclaimertext', null), 'enableLinkPasswordByDefault' => $this->config->getAppValue('core', 'shareapi_enable_link_password_by_default', 'no'), diff --git a/lib/private/Share/Helper.php b/lib/private/Share/Helper.php index a1a56077d40b60ca12b5cf7e99a3ef152c17f95e..2eba67004dd8eb661956d7cd73cd7380b868282e 100644 --- a/lib/private/Share/Helper.php +++ b/lib/private/Share/Helper.php @@ -169,7 +169,7 @@ class Helper extends \OC\Share\Constants { $enforceExpireDate = $config->getAppValue('core', 'shareapi_enforce_expire_date', 'no'); $defaultExpireSettings['defaultExpireDateSet'] = true; $defaultExpireSettings['expireAfterDays'] = (int)($config->getAppValue('core', 'shareapi_expire_after_n_days', '7')); - $defaultExpireSettings['enforceExpireDate'] = $enforceExpireDate === 'yes' ? true : false; + $defaultExpireSettings['enforceExpireDate'] = $enforceExpireDate === 'yes'; } return $defaultExpireSettings; diff --git a/lib/private/Share/Share.php b/lib/private/Share/Share.php index 8812399c812a03d5badecd2f11ffc98d3be9351e..35d84307548be25c567b6942e9083675e9eb352d 100644 --- a/lib/private/Share/Share.php +++ b/lib/private/Share/Share.php @@ -1416,7 +1416,7 @@ class Share extends Constants { */ protected static function groupItems($items, $itemType) { - $fileSharing = ($itemType === 'file' || $itemType === 'folder') ? true : false; + $fileSharing = $itemType === 'file' || $itemType === 'folder'; $result = array(); @@ -2070,7 +2070,7 @@ class Share extends Constants { */ public static function shareWithGroupMembersOnly() { $value = \OC::$server->getConfig()->getAppValue('core', 'shareapi_only_share_with_group_members', 'no'); - return ($value === 'yes') ? true : false; + return $value === 'yes'; } /** @@ -2078,7 +2078,7 @@ class Share extends Constants { */ public static function isDefaultExpireDateEnabled() { $defaultExpireDateEnabled = \OC::$server->getConfig()->getAppValue('core', 'shareapi_default_expire_date', 'no'); - return ($defaultExpireDateEnabled === "yes") ? true : false; + return $defaultExpireDateEnabled === 'yes'; } /** @@ -2119,7 +2119,7 @@ class Share extends Constants { */ public static function enforcePassword(IConfig $config) { $enforcePassword = $config->getAppValue('core', 'shareapi_enforce_links_password', 'no'); - return ($enforcePassword === "yes") ? true : false; + return $enforcePassword === 'yes'; } /** diff --git a/lib/private/SubAdmin.php b/lib/private/SubAdmin.php index d92c8d016058b47767eb14d14b9df916baed63a3..cd16d07e43d90c56b4a7d562ef4fd57e7efded69 100644 --- a/lib/private/SubAdmin.php +++ b/lib/private/SubAdmin.php @@ -230,9 +230,7 @@ class SubAdmin extends PublicEmitter { $isSubAdmin = $result->fetch(); $result->closeCursor(); - $result = $isSubAdmin === false ? false : true; - - return $result; + return $isSubAdmin !== false; } /** diff --git a/lib/private/Template/JSConfigHelper.php b/lib/private/Template/JSConfigHelper.php index 65068973e40b6a4781a29df1bc9412dbfcc6cac4..ab52704d1e2d944b6bc9a4ab2bd1287e3e6d7ad6 100644 --- a/lib/private/Template/JSConfigHelper.php +++ b/lib/private/Template/JSConfigHelper.php @@ -122,7 +122,7 @@ class JSConfigHelper { $enableLinkPasswordByDefault = $this->config->getAppValue('core', 'shareapi_enable_link_password_by_default', 'no'); - $enableLinkPasswordByDefault = ($enableLinkPasswordByDefault === 'yes') ? true : false; + $enableLinkPasswordByDefault = $enableLinkPasswordByDefault === 'yes'; $defaultExpireDateEnabled = $this->config->getAppValue('core', 'shareapi_default_expire_date', 'no') === 'yes'; $defaultExpireDate = $enforceDefaultExpireDate = null; if ($defaultExpireDateEnabled) { diff --git a/lib/private/legacy/util.php b/lib/private/legacy/util.php index 776a879e7318977cf06690921af3eb2bc8d5d962..efa488b434deddf8de111f4f8256729e5e6b1693 100644 --- a/lib/private/legacy/util.php +++ b/lib/private/legacy/util.php @@ -301,7 +301,7 @@ class OC_Util { */ public static function isPublicLinkPasswordRequired() { $enforcePassword = \OC::$server->getConfig()->getAppValue('core', 'shareapi_enforce_links_password', 'no'); - return ($enforcePassword === 'yes') ? true : false; + return $enforcePassword === 'yes'; } /** @@ -344,7 +344,7 @@ class OC_Util { $enforceDefaultExpireDate = false; if ($isDefaultExpireDateEnabled === 'yes') { $value = \OC::$server->getConfig()->getAppValue('core', 'shareapi_enforce_expire_date', 'no'); - $enforceDefaultExpireDate = ($value === 'yes') ? true : false; + $enforceDefaultExpireDate = $value === 'yes'; } return $enforceDefaultExpireDate; diff --git a/settings/Controller/AppSettingsController.php b/settings/Controller/AppSettingsController.php index f2a92b52f6d179a0b83ffa470ec96b456c2eb297..cd34edf567ce784b246f9b187b47683eca0d8cb7 100644 --- a/settings/Controller/AppSettingsController.php +++ b/settings/Controller/AppSettingsController.php @@ -205,7 +205,7 @@ class AppSettingsController extends Controller { $nextCloudVersionDependencies['nextcloud']['@attributes']['max-version'] = $nextCloudVersion->getMaximumVersion(); } $phpVersion = $versionParser->getVersion($app['releases'][0]['rawPhpVersionSpec']); - $existsLocally = (\OC_App::getAppPath($app['id']) !== false) ? true : false; + $existsLocally = \OC_App::getAppPath($app['id']) !== false; $phpDependencies = []; if($phpVersion->getMinimumVersion() !== '') { $phpDependencies['php']['@attributes']['min-version'] = $phpVersion->getMinimumVersion();