From 70ae7fa091cb396f82005e17a849d3d0ac8c9751 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thomas=20M=C3=BCller?= <thomas.mueller@tmit.eu>
Date: Tue, 3 Jun 2014 19:10:18 +0200
Subject: [PATCH] Fix casing and PHPDoc
---
apps/user_ldap/appinfo/register_command.php | 6 +++---
apps/user_ldap/command/setconfig.php | 6 +++---
apps/user_ldap/command/showconfig.php | 1 -
apps/user_ldap/command/testconfig.php | 2 +-
4 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/apps/user_ldap/appinfo/register_command.php b/apps/user_ldap/appinfo/register_command.php
index 57e0ccbdad4..10d992531c4 100644
--- a/apps/user_ldap/appinfo/register_command.php
+++ b/apps/user_ldap/appinfo/register_command.php
@@ -6,6 +6,6 @@
* See the COPYING-README file.
*/
-$application->add(new OCA\user_ldap\Command\showConfig());
-$application->add(new OCA\user_ldap\Command\setConfig());
-$application->add(new OCA\user_ldap\Command\testConfig());
+$application->add(new OCA\user_ldap\Command\ShowConfig());
+$application->add(new OCA\user_ldap\Command\SetConfig());
+$application->add(new OCA\user_ldap\Command\TestConfig());
diff --git a/apps/user_ldap/command/setconfig.php b/apps/user_ldap/command/setconfig.php
index 5326c3a648d..ab1c8d39ead 100644
--- a/apps/user_ldap/command/setconfig.php
+++ b/apps/user_ldap/command/setconfig.php
@@ -57,9 +57,9 @@ class SetConfig extends Command {
/**
* save the configuration value as provided
- * @param string configID
- * @param string configKey
- * @param string configValue
+ * @param string $configID
+ * @param string $configKey
+ * @param string $configValue
*/
protected function setValue($configID, $key, $value) {
$configHolder = new Configuration($configID);
diff --git a/apps/user_ldap/command/showconfig.php b/apps/user_ldap/command/showconfig.php
index e15ec4a2387..f51d641beec 100644
--- a/apps/user_ldap/command/showconfig.php
+++ b/apps/user_ldap/command/showconfig.php
@@ -52,7 +52,6 @@ class ShowConfig extends Command {
* @param OutputInterface $output
*/
protected function renderConfigs($configIDs, $output) {
- $ldapWrapper = new \OCA\user_ldap\lib\LDAP();
foreach($configIDs as $id) {
$configHolder = new Configuration($id);
$configuration = $configHolder->getConfiguration();
diff --git a/apps/user_ldap/command/testconfig.php b/apps/user_ldap/command/testconfig.php
index e393e5dd9b8..00b4acf2f66 100644
--- a/apps/user_ldap/command/testconfig.php
+++ b/apps/user_ldap/command/testconfig.php
@@ -52,7 +52,7 @@ class TestConfig extends Command {
/**
* tests the specified connection
- * @param string configID
+ * @param string $configID
* @return int
*/
protected function testConfig($configID) {
--
GitLab