From 87ec729f3444808f9e43a64d6925d977db7cab6d Mon Sep 17 00:00:00 2001
From: Christoph Wurst <christoph@winzerhof-wurst.at>
Date: Tue, 28 Jan 2020 14:29:41 +0100
Subject: [PATCH] Do not encode contacts menu mailto links
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
---
lib/private/Contacts/ContactsMenu/ActionFactory.php | 2 +-
tests/lib/Contacts/ContactsMenu/ActionFactoryTest.php | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/private/Contacts/ContactsMenu/ActionFactory.php b/lib/private/Contacts/ContactsMenu/ActionFactory.php
index 899ce31ecbd..2c216bf2592 100644
--- a/lib/private/Contacts/ContactsMenu/ActionFactory.php
+++ b/lib/private/Contacts/ContactsMenu/ActionFactory.php
@@ -50,7 +50,7 @@ class ActionFactory implements IActionFactory {
* @return ILinkAction
*/
public function newEMailAction($icon, $name, $email) {
- return $this->newLinkAction($icon, $name, 'mailto:' . urlencode($email));
+ return $this->newLinkAction($icon, $name, 'mailto:' . $email);
}
}
diff --git a/tests/lib/Contacts/ContactsMenu/ActionFactoryTest.php b/tests/lib/Contacts/ContactsMenu/ActionFactoryTest.php
index 54106bbb642..8e7f64ff9d1 100644
--- a/tests/lib/Contacts/ContactsMenu/ActionFactoryTest.php
+++ b/tests/lib/Contacts/ContactsMenu/ActionFactoryTest.php
@@ -61,7 +61,7 @@ class ActionFactoryTest extends TestCase {
$this->assertInstanceOf(IAction::class, $action);
$this->assertEquals($name, $action->getName());
$this->assertEquals(10, $action->getPriority());
- $this->assertEquals('mailto:user%40example.com', $action->getHref());
+ $this->assertEquals('mailto:user@example.com', $action->getHref());
}
}
--
GitLab