From 89e3860e1ab2c5528f0f63c3192f458dc290b12e Mon Sep 17 00:00:00 2001
From: Vincent Petry <pvince81@owncloud.com>
Date: Wed, 21 Oct 2015 10:50:06 +0200
Subject: [PATCH] Disable app icon preview in apps page for IE
All IE versions are not able to properly upscale SVG icons unless the
said SVG files contain a "viewBox" attribute, which is not always the
case. Also we cannot guarantee that all third party apps will have this
attribute in their icons.
So for now, app icons will not be displayed in IE instead of broken
ones.
---
core/js/js.js | 9 +++++++++
settings/js/apps.js | 4 ++--
2 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/core/js/js.js b/core/js/js.js
index 00a775b8027..3eafb3d9d6d 100644
--- a/core/js/js.js
+++ b/core/js/js.js
@@ -1632,6 +1632,15 @@ OC.Util = {
return $el;
},
+ /**
+ * Returns whether this is IE
+ *
+ * @return {bool} true if this is IE, false otherwise
+ */
+ isIE: function() {
+ return $('html').hasClass('ie');
+ },
+
/**
* Returns whether this is IE8
*
diff --git a/settings/js/apps.js b/settings/js/apps.js
index d51c642c9c9..987153b778c 100644
--- a/settings/js/apps.js
+++ b/settings/js/apps.js
@@ -161,8 +161,8 @@ OC.Settings.Apps = OC.Settings.Apps || {
var page = $('#app-' + app.id);
- // image loading kung-fu
- if (app.preview) {
+ // image loading kung-fu (IE doesn't properly scale SVGs, so disable app icons)
+ if (app.preview && !OC.Util.isIE()) {
var currentImage = new Image();
currentImage.src = app.preview;
--
GitLab