From aeffd511459bbefc4b2a338e67494786e14a6eee Mon Sep 17 00:00:00 2001
From: Roeland Jago Douma <rullzer@owncloud.com>
Date: Tue, 20 Oct 2015 21:47:37 +0200
Subject: [PATCH] Fix scrutinizer issues
* PHPDoc
* Proper array initialization
---
apps/provisioning_api/tests/testcase.php | 2 +-
apps/provisioning_api/tests/userstest.php | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/apps/provisioning_api/tests/testcase.php b/apps/provisioning_api/tests/testcase.php
index cc8f5c1d16d..6135a6d2f96 100644
--- a/apps/provisioning_api/tests/testcase.php
+++ b/apps/provisioning_api/tests/testcase.php
@@ -46,7 +46,7 @@ abstract class TestCase extends \Test\TestCase {
/**
* Generates a temp user
* @param int $num number of users to generate
- * @return array
+ * @return IUser[]|Iuser
*/
protected function generateUsers($num = 1) {
$users = array();
diff --git a/apps/provisioning_api/tests/userstest.php b/apps/provisioning_api/tests/userstest.php
index 3869af87e5a..673383edae6 100644
--- a/apps/provisioning_api/tests/userstest.php
+++ b/apps/provisioning_api/tests/userstest.php
@@ -234,7 +234,7 @@ class UsersTest extends TestCase {
$user = $this->generateUsers();
$user->setDisplayName('foobar');
$this->userSession->setUser($user);
- $params['userid'] = $user->getUID();
+ $params = ['userid' => $user->getUID()];
$result = $this->api->getUser($params);
$this->assertInstanceOf('OC_OCS_Result', $result);
$this->assertTrue($result->succeeded());
@@ -261,7 +261,7 @@ class UsersTest extends TestCase {
public function testGetUserOnOtherUser() {
$users = $this->generateUsers(2);
- $params['userid'] = $users[0];
+ $params = ['userid' => $users[0]->getUID()];
$this->userSession->setUser($users[1]);
$result = $this->api->getUser($params);
$this->assertInstanceOf('OC_OCS_Result', $result);
--
GitLab