diff --git a/apps/files/js/fileactions.js b/apps/files/js/fileactions.js index 3623663ed6c8eaedda413e495314e7403a519515..ac3afba038d0756f2515f4f5c543963754a17733 100644 --- a/apps/files/js/fileactions.js +++ b/apps/files/js/fileactions.js @@ -558,7 +558,13 @@ } }); - this._renderMenuTrigger($tr, context); + var menuActions = Object.values(this.actions.all).filter(function (action) { + return action.type !== OCA.Files.FileActions.TYPE_INLINE; + }); + // do not render the menu if nothing is in it + if (menuActions.length > 0) { + this._renderMenuTrigger($tr, context); + } if (triggerEvent){ fileList.$fileList.trigger(jQuery.Event("fileActionsReady", {fileList: fileList, $files: $tr})); diff --git a/apps/files_sharing/js/share.js b/apps/files_sharing/js/share.js index 0f8dc58a85e931159a74cb1e3e92c1e429fc8031..68529fd882fa4731d9ab850aeca83bfecff0be16 100644 --- a/apps/files_sharing/js/share.js +++ b/apps/files_sharing/js/share.js @@ -42,14 +42,16 @@ var fileActions = fileList.fileActions; var oldCreateRow = fileList._createRow; fileList._createRow = function(fileData) { + + var tr = oldCreateRow.apply(this, arguments); + var sharePermissions = OCA.Sharing.Util.getSharePermissions(fileData); if (fileData.permissions === 0) { // no permission, disabling sidebar + delete fileActions.actions.all.Comment; delete fileActions.actions.all.Details; + delete fileActions.actions.all.Goto; } - - var tr = oldCreateRow.apply(this, arguments); - var sharePermissions = OCA.Sharing.Util.getSharePermissions(fileData); tr.attr('data-share-permissions', sharePermissions); if (fileData.shareOwner) { tr.attr('data-share-owner', fileData.shareOwner);