From c7ff0c71b4d7d78e1da6901ef6820eea70dfa82a Mon Sep 17 00:00:00 2001
From: Morris Jobke <hey@morrisjobke.de>
Date: Wed, 4 Nov 2020 09:59:32 +0100
Subject: [PATCH] Shortcut to avoid file system setup when generating the logo
URL
If an SVG is requested and the app config value for logoMime is set then the logo is there. Otherwise we need to check it and maybe also generate a PNG from the SVG (that's done in getImage() which needs to be called then).
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
---
apps/theming/lib/ThemingDefaults.php | 19 ++++++++++++++-----
apps/theming/tests/ThemingDefaultsTest.php | 6 ------
2 files changed, 14 insertions(+), 11 deletions(-)
diff --git a/apps/theming/lib/ThemingDefaults.php b/apps/theming/lib/ThemingDefaults.php
index 3f0a94e244a..01af4d1b177 100644
--- a/apps/theming/lib/ThemingDefaults.php
+++ b/apps/theming/lib/ThemingDefaults.php
@@ -225,11 +225,20 @@ class ThemingDefaults extends \OC_Defaults {
public function getLogo($useSvg = true): string {
$logo = $this->config->getAppValue('theming', 'logoMime', false);
- $logoExists = true;
- try {
- $this->imageManager->getImage('logo', $useSvg);
- } catch (\Exception $e) {
- $logoExists = false;
+ // short cut to avoid setting up the filesystem just to check if the logo is there
+ //
+ // explanation: if an SVG is requested and the app config value for logoMime is set then the logo is there.
+ // otherwise we need to check it and maybe also generate a PNG from the SVG (that's done in getImage() which
+ // needs to be called then)
+ if ($useSvg === true && $logo !== false) {
+ $logoExists = true;
+ } else {
+ try {
+ $this->imageManager->getImage('logo', $useSvg);
+ $logoExists = true;
+ } catch (\Exception $e) {
+ $logoExists = false;
+ }
}
$cacheBusterCounter = $this->config->getAppValue('theming', 'cachebuster', '0');
diff --git a/apps/theming/tests/ThemingDefaultsTest.php b/apps/theming/tests/ThemingDefaultsTest.php
index 066b8b8ff8d..341a1b24887 100644
--- a/apps/theming/tests/ThemingDefaultsTest.php
+++ b/apps/theming/tests/ThemingDefaultsTest.php
@@ -40,7 +40,6 @@ use OCA\Theming\Util;
use OCP\App\IAppManager;
use OCP\Files\IAppData;
use OCP\Files\NotFoundException;
-use OCP\Files\SimpleFS\ISimpleFile;
use OCP\ICache;
use OCP\ICacheFactory;
use OCP\IConfig;
@@ -617,11 +616,6 @@ class ThemingDefaultsTest extends TestCase {
}
public function testGetLogoCustom() {
- $file = $this->createMock(ISimpleFile::class);
- $this->imageManager->expects($this->once())
- ->method('getImage')
- ->with('logo')
- ->willReturn($file);
$this->config
->expects($this->at(0))
->method('getAppValue')
--
GitLab