From c9ce96ff054788f31d45d774dcfa008c0de095c5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= <danxuliu@gmail.com>
Date: Wed, 5 Sep 2018 08:36:35 +0200
Subject: [PATCH] Show avatar using "span" instead of "div"
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Visually it makes no difference, but as the ".avatar" element is inside
a "span" element it can not be a block element to be compliant with the
HTML specification.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
---
apps/comments/js/commentstabview.js | Bin 24202 -> 24209 bytes
apps/comments/tests/js/commentstabviewSpec.js | 2 +-
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/apps/comments/js/commentstabview.js b/apps/comments/js/commentstabview.js
index 8b20bac571b0153a8779296ba3c3d2bcede2a88f..11b33e9f0cc9c67516c22c7ec8b7f82ce2d73b36 100644
GIT binary patch
delta 76
zcmeC$%Q$f_<Az|V$!bzUlT)Owu@o01=1sPhK7uabx7kwGmk}(zxl=AeZt@jrp~;_Y
M7C}U&+kRF605eM*#Q*>R
delta 68
zcmbQZm$7Rv<Az`<=9J8`$>CB@z_h*e5oG@6_cF5?K?0lm<Raw2GOuhlfCc8+epUbg
DnKK(%
diff --git a/apps/comments/tests/js/commentstabviewSpec.js b/apps/comments/tests/js/commentstabviewSpec.js
index c90ad04e419..bd1353cc43d 100644
--- a/apps/comments/tests/js/commentstabviewSpec.js
+++ b/apps/comments/tests/js/commentstabviewSpec.js
@@ -309,7 +309,7 @@ describe('OCA.Comments.CommentsTabView tests', function() {
expect(createStub.calledOnce).toEqual(false);
expect($newCommentForm.find('.message').html()).toContain('Mention to <span');
- expect($newCommentForm.find('.message').html()).toContain('<div class="avatar"');
+ expect($newCommentForm.find('.message').html()).toContain('<span class="avatar"');
expect($newCommentForm.find('.message').html()).toContain('<strong>User Name</strong>');
expect($newCommentForm.find('.message').text()).not.toContain('@');
// In this case the default behaviour is prevented by the
--
GitLab