From ceffbe9f6de99a467f1efbe66a8e1aef4ee4f5dd Mon Sep 17 00:00:00 2001
From: Christoph Wurst <christoph@winzerhof-wurst.at>
Date: Thu, 27 Aug 2020 13:19:12 +0200
Subject: [PATCH] Hide error if a background request fails during navigation
If you open the dashboard but quickly navigate somewhere else, a toast
will show telling you that the weather status could not be fetched. As a
user I don't care about this. This is only relevant if the user intents
to no leave the page.
So let's not show a toast for aborted connections. This makes the UX a
tad smoother.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
---
apps/weather_status/js/weather-status.js | Bin 932478 -> 932680 bytes
apps/weather_status/js/weather-status.js.map | Bin 2927132 -> 2927328 bytes
apps/weather_status/src/App.vue | 6 +++++-
3 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/apps/weather_status/js/weather-status.js b/apps/weather_status/js/weather-status.js
index 0451dcf3720c5ade1dbcebb14f3aa08f906bfe8c..342da5d5b08a65d42ca8ffd08ab37e74f4fecc73 100644
GIT binary patch
delta 354
zcmXw!%}N6?9K@;LpL^-aUK;nbD<y1bZMQ8!{OGj>=?i4D|Jv0hsY$jKtkgr^q4*wx
zPat^qS;T_}aZBrI80H5v^ZONke234rVAt%r-LRW>%Wm5pyKDFCzCEyqug?3?ENn*#
z*j<}54Tz9dGVlZ*DHu~iDgv8;3e1_|Loe_vZs)Ss?VexsuKS%U_n1;oWNAui&X{02
z9m^y}!OEU3U273xE@SZhM}Y-A7)t8P(kBHolPQ6?6k4W$6ETpU+aCg&05d~SNE>D{
zjTGExpbeTZjW`n=(iCD80cTl0J10@D3JEq&ZkPd$T|XbsB9)Dd=PFpVxc=&7z153u
zfg4X^J^w)tnV*!LY7vx@DnD<6e=wXE%8vi`QgS}a#X)?^noY)|8fi4DalKiCKd|R@
A)&Kwi
delta 116
zcmV-)0E_>~_Bj6ZIDmu!gaU*Egam{Iga(8Mgb0KQgbIWUgbaiYv<}4?88tg%a%Ev_
zJ7ZyUWgsyzI&Lm-a%FZsF)^1LB@RrN^coH`mmVSx2A8QH4h#V`m&+dxDYs)A4$>bJ
WF*0E>G-hHmWMyS!WjJ9uGBr2zKP038
diff --git a/apps/weather_status/js/weather-status.js.map b/apps/weather_status/js/weather-status.js.map
index 03c304d8d781f0d07674d875fe0df311fab6ced7..0641d8049ea181bf5ee66ea1d1386a90fdf5f845 100644
GIT binary patch
delta 782
zcmYk&OHUI~6bJC2VDT}cqM}muqCi`@;ZfSbCPj0m9l#iAps$$J#W1~PDs{>{N;Sr~
zaKTz#+>HyjCN7js{Rn&j*|;*UHSr_(pHZWk{LbXwbM8GS_s!?MzOM&+eIF*Qesj)D
zzB0#OzuoMAv1aYAS$%K_4nsc-z!8YRARL8baJ;u>ow)Tq>*UEKK9#3B@vcUKxU)nJ
z;z^CRG~(Ve<%qX6vawL}<l$GQ9mFbi<j0bd7_?AOrOllDR#N7Nx9<^OCI_)VE}~AJ
zjF**YaV|_G!^C`;P!WybdXx09;T?3!{oZg_gKIp*GWm!)br2tEv`qXy&E$iYQ&N_d
zY~(Qx7pW`1lodUaE(EozoUABnWML`DsM4$`T4V<&i<tR+MM;d#V1b!e!nQb%i(6P!
zX=_FPtSFht_IhxSBWJ5hJo6BPA%&RI|2zlI;I&+A70E#ipQ#xR?`T2IU0%><dM~TW
z_{eaho;ETW!`w*CEiBB})l5q4?%N8SgdsQur{N3?!&x{7=V1gcz(u$OqY#D5a0RXc
zgE6=U*I^tcU=m^whXmZ{?b}nIemrkBSX{X7?P;@J7i@8Hk;U{}VRe<X!g@*1#}e#m
z&93=>KeKIn?UtBs+KqNRR<Z=^3d6UA%RJxkJ05d|(-EG}x`xM0!!|{$CF*QLm`2AF
z43!Ljm)XWnbJOs}m^U3u{NKP8e#f={?L3pV;90p><Jkes*>)wfc(gb4fY+jfNs+p#
Nrqf2xd&1w%{sL2P2xb5P
delta 594
zcmXZYy>HV%7zS{qq&O{HTUttiw0x9=HuMH!r->~^i1!*3J_J!{9SeyLp>b*_B&7lh
zsl>$49fn&Nx*`_nV*UaaMqo#sVPj<Axf8?hk!-*B`0jrGI7qzvevtT>4U<hL-+Hr=
zdAq-vd|eOs>R|$g;0PpP7><GgDHwrKI2PB#<JW%8cPq3({Ara|h;IpM6E9Y%D~Nm4
zNBY#0U)NYJwX7csLjGN2mI&_>uTq4pQ3vT#7r7+JCH_EF6<1V7LZwg7^!Rf<zN5zn
za@%9+Z0DZp=^{OPjC84o><Ox>9;>1joAQ&#%El8^uhN$M<1yEGSyQtEdA-4k#_kRE
zWguTQm@xWSxr$AHX|P<{!h=r*q^Y-tVn@HSt8&z5juGBhJ(0Zavqh(LQ%&2*g8TnE
z@Xr^5I=573gw)p*>9cL?v)$n}*NQ**EHg8eH=FrF`;pZOf>vNR9do&~ci3kz2IDXR
zCtwn$;3Q1LDVTxNa0bpo8fIY*&cS)O02g5%E<pyea2Xb05pr-PKI|`j{w>RGZpxi?
gUY7f9J}D<cJ|2Ht=MQI7rKV-uP7uVUUH<;+KVh)SIsgCw
diff --git a/apps/weather_status/src/App.vue b/apps/weather_status/src/App.vue
index aed774cb98d..6aaef4aaf6d 100644
--- a/apps/weather_status/src/App.vue
+++ b/apps/weather_status/src/App.vue
@@ -236,8 +236,12 @@ export default {
this.startLoop()
}
} catch (err) {
+ if (err?.code === 'ECONNABORTED') {
+ console.info('The weather status request was cancelled because the user navigates.')
+ return
+ }
showError(t('weather_status', 'There was an error getting the weather status information.'))
- console.debug(err)
+ console.error(err)
}
},
startLoop() {
--
GitLab