diff --git a/apps/files_external/lib/sftp.php b/apps/files_external/lib/sftp.php index fc74d5b2a90ebadd1934f266b7edeb9790c66d67..0cec250778fad0903ec6a0b2d20adb87e595d82d 100644 --- a/apps/files_external/lib/sftp.php +++ b/apps/files_external/lib/sftp.php @@ -54,12 +54,8 @@ class SFTP extends \OC\Files\Storage\Common { $hostKeys = $this->readHostKeys(); $this->client = new \Net_SFTP($this->host); - if (!$this->client->login($this->user, $this->password)) { - throw new \Exception('Login failed'); - } - + // The SSH Host Key MUST be verified before login(). $currentHostKey = $this->client->getServerPublicHostKey(); - if (array_key_exists($this->host, $hostKeys)) { if ($hostKeys[$this->host] != $currentHostKey) { throw new \Exception('Host public key does not match known key'); @@ -68,6 +64,10 @@ class SFTP extends \OC\Files\Storage\Common { $hostKeys[$this->host] = $currentHostKey; $this->writeHostKeys($hostKeys); } + + if (!$this->client->login($this->user, $this->password)) { + throw new \Exception('Login failed'); + } } public function test() {