From e6712c47a6f6e4991e90b8bbb89eb71345f6df1b Mon Sep 17 00:00:00 2001
From: Roeland Jago Douma <rullzer@owncloud.com>
Date: Thu, 10 Mar 2016 21:35:22 +0100
Subject: [PATCH] Fix some scrutinizer warning in the sharing code
* Better phpdoc
* Promper use statements
* Unused parameter
---
apps/files_sharing/api/ocssharewrapper.php | 2 +-
apps/files_sharing/api/share20ocs.php | 2 +-
lib/public/share/imanager.php | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/apps/files_sharing/api/ocssharewrapper.php b/apps/files_sharing/api/ocssharewrapper.php
index 9f63e864cec..a51ad1eb2c9 100644
--- a/apps/files_sharing/api/ocssharewrapper.php
+++ b/apps/files_sharing/api/ocssharewrapper.php
@@ -36,7 +36,7 @@ class OCSShareWrapper {
\OC::$server->getUserSession()->getUser());
}
- public function getAllShares($params) {
+ public function getAllShares() {
return $this->getShare20OCS()->getShares();
}
diff --git a/apps/files_sharing/api/share20ocs.php b/apps/files_sharing/api/share20ocs.php
index 0c9e5473d9c..d5928b50ba7 100644
--- a/apps/files_sharing/api/share20ocs.php
+++ b/apps/files_sharing/api/share20ocs.php
@@ -50,7 +50,7 @@ class Share20OCS {
private $request;
/** @var IRootFolder */
private $rootFolder;
- /** @var IUrlGenerator */
+ /** @var IURLGenerator */
private $urlGenerator;
/** @var IUser */
private $currentUser;
diff --git a/lib/public/share/imanager.php b/lib/public/share/imanager.php
index f926104dde0..edb76c46de4 100644
--- a/lib/public/share/imanager.php
+++ b/lib/public/share/imanager.php
@@ -23,7 +23,7 @@ namespace OCP\Share;
use OCP\IUser;
-use OC\Share20\Exception\ShareNotFound;
+use OCP\Share\Exceptions\ShareNotFound;
/**
* Interface IManager
@@ -106,7 +106,7 @@ interface IManager {
*
* @param string $userId
* @param int $shareType
- * @param File|Folder|null $node
+ * @param \OCP\Files\File|\OCP\Files\Folder|null $node
* @param int $limit The maximum number of shares returned, -1 for all
* @param int $offset
* @return IShare[]
--
GitLab