From 5125aac91c4e6b0730a7a9f9d4c8c72a109fb83e Mon Sep 17 00:00:00 2001
From: Philipp Heckel <pheckel@datto.com>
Date: Wed, 30 Mar 2022 14:23:57 -0400
Subject: [PATCH] Remove upx for arm64/armv7, more translation credits
---
.goreleaser.yml | 10 ++++------
docs/releases.md | 3 ++-
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/.goreleaser.yml b/.goreleaser.yml
index 695a381..2800263 100644
--- a/.goreleaser.yml
+++ b/.goreleaser.yml
@@ -28,9 +28,8 @@ builds:
goos: [linux]
goarch: [arm]
goarm: [7]
- hooks:
- post:
- - upx "{{ .Path }}" # apt install upx
+ # No "upx", since it causes random core dumps, see
+ # https://github.com/binwiederhier/ntfy/issues/191#issuecomment-1083406546
-
id: ntfy_arm64
binary: ntfy
@@ -42,9 +41,8 @@ builds:
- "-linkmode=external -extldflags=-static -s -w -X main.version={{.Version}} -X main.commit={{.Commit}} -X main.date={{.Date}}"
goos: [linux]
goarch: [arm64]
- hooks:
- post:
- - upx "{{ .Path }}" # apt install upx
+ # No "upx", since it causes random core dumps, see
+ # https://github.com/binwiederhier/ntfy/issues/191#issuecomment-1083406546
nfpms:
-
package_name: ntfy
diff --git a/docs/releases.md b/docs/releases.md
index ffa4456..818bb42 100644
--- a/docs/releases.md
+++ b/docs/releases.md
@@ -24,7 +24,7 @@ and the [ntfy Android app](https://github.com/binwiederhier/ntfy-android/release
* English language improvements (thanks to [@comradekingu](https://github.com/comradekingu))
* Bulgarian (thanks to [@StoyanDimitrov](https://github.com/StoyanDimitrov))
* Dutch (*incomplete*, thanks to [@diony](https://hosted.weblate.org/user/diony))
-* Chinese (*incomplete*, thanks to [@poi](https://hosted.weblate.org/user/poi))
+* Chinese/Simplified (thanks to [@poi](https://hosted.weblate.org/user/poi) and [@PeterCxy](https://hosted.weblate.org/user/PeterCxy))
* French (*incomplete*, thanks to [@Kusoneko](https://kusoneko.moe/))
* German (thanks to [@cmeis](https://github.com/cmeis))
* Italian (thanks to [@theTranslator](https://hosted.weblate.org/user/theTranslator/))
@@ -42,6 +42,7 @@ and the [ntfy Android app](https://github.com/binwiederhier/ntfy-android/release
**Bugs:**
+* Do not pack binary with `upx` for armv7/arm64 due to `illegal instruction` errors ([#191](https://github.com/binwiederhier/ntfy/issues/191), thanks to [@iexos](https://github.com/iexos))
* Do not allow comma in topic name in publish via GET endpoint (no ticket)
* Add "Access-Control-Allow-Origin: *" for attachments (no ticket, thanks to @FrameXX)
* Make pruning run again in web app ([#186](https://github.com/binwiederhier/ntfy/issues/186))
--
GitLab