From 0bb8e418a41c6f583ca9d705b400e37e2308a534 Mon Sep 17 00:00:00 2001
From: David Robertson <davidr@element.io>
Date: Tue, 5 Dec 2023 11:08:40 +0000
Subject: [PATCH] Fix postgres schema after dropping old tables (#16730)

---
 changelog.d/16730.misc                                           | 1 +
 .../main/delta/83/10_replica_identity_batch_events.sql.postgres  | 1 -
 .../main/delta/83/10_replica_identity_event_txn_id.sql.postgres  | 1 -
 .../83/10_replica_identity_insertion_event_edges.sql.postgres    | 1 -
 .../10_replica_identity_insertion_event_extremities.sql.postgres | 1 -
 .../delta/83/10_replica_identity_insertion_events.sql.postgres   | 1 -
 6 files changed, 1 insertion(+), 5 deletions(-)
 create mode 100644 changelog.d/16730.misc
 delete mode 100644 synapse/storage/schema/main/delta/83/10_replica_identity_batch_events.sql.postgres
 delete mode 100644 synapse/storage/schema/main/delta/83/10_replica_identity_event_txn_id.sql.postgres
 delete mode 100644 synapse/storage/schema/main/delta/83/10_replica_identity_insertion_event_edges.sql.postgres
 delete mode 100644 synapse/storage/schema/main/delta/83/10_replica_identity_insertion_event_extremities.sql.postgres
 delete mode 100644 synapse/storage/schema/main/delta/83/10_replica_identity_insertion_events.sql.postgres

diff --git a/changelog.d/16730.misc b/changelog.d/16730.misc
new file mode 100644
index 0000000000..baee042f2f
--- /dev/null
+++ b/changelog.d/16730.misc
@@ -0,0 +1 @@
+Add a Postgres `REPLICA IDENTITY` to tables that do not have an implicit one. This should allow use of Postgres logical replication.
\ No newline at end of file
diff --git a/synapse/storage/schema/main/delta/83/10_replica_identity_batch_events.sql.postgres b/synapse/storage/schema/main/delta/83/10_replica_identity_batch_events.sql.postgres
deleted file mode 100644
index cd4471f4d7..0000000000
--- a/synapse/storage/schema/main/delta/83/10_replica_identity_batch_events.sql.postgres
+++ /dev/null
@@ -1 +0,0 @@
-ALTER TABLE batch_events REPLICA IDENTITY USING INDEX chunk_events_event_id;
diff --git a/synapse/storage/schema/main/delta/83/10_replica_identity_event_txn_id.sql.postgres b/synapse/storage/schema/main/delta/83/10_replica_identity_event_txn_id.sql.postgres
deleted file mode 100644
index a2bacbc96d..0000000000
--- a/synapse/storage/schema/main/delta/83/10_replica_identity_event_txn_id.sql.postgres
+++ /dev/null
@@ -1 +0,0 @@
-ALTER TABLE event_txn_id REPLICA IDENTITY USING INDEX event_txn_id_event_id;
diff --git a/synapse/storage/schema/main/delta/83/10_replica_identity_insertion_event_edges.sql.postgres b/synapse/storage/schema/main/delta/83/10_replica_identity_insertion_event_edges.sql.postgres
deleted file mode 100644
index 8322722b1a..0000000000
--- a/synapse/storage/schema/main/delta/83/10_replica_identity_insertion_event_edges.sql.postgres
+++ /dev/null
@@ -1 +0,0 @@
-ALTER TABLE insertion_event_edges REPLICA IDENTITY FULL;
diff --git a/synapse/storage/schema/main/delta/83/10_replica_identity_insertion_event_extremities.sql.postgres b/synapse/storage/schema/main/delta/83/10_replica_identity_insertion_event_extremities.sql.postgres
deleted file mode 100644
index 1816ce5a49..0000000000
--- a/synapse/storage/schema/main/delta/83/10_replica_identity_insertion_event_extremities.sql.postgres
+++ /dev/null
@@ -1 +0,0 @@
-ALTER TABLE insertion_event_extremities REPLICA IDENTITY USING INDEX insertion_event_extremities_event_id;
diff --git a/synapse/storage/schema/main/delta/83/10_replica_identity_insertion_events.sql.postgres b/synapse/storage/schema/main/delta/83/10_replica_identity_insertion_events.sql.postgres
deleted file mode 100644
index 1fdbd597c7..0000000000
--- a/synapse/storage/schema/main/delta/83/10_replica_identity_insertion_events.sql.postgres
+++ /dev/null
@@ -1 +0,0 @@
-ALTER TABLE insertion_events REPLICA IDENTITY USING INDEX insertion_events_event_id;
-- 
GitLab