diff --git a/classes/pref/prefs.php b/classes/pref/prefs.php index 592bdb70560eedda76c737145e5d4c06087f252d..7dc1e9a1f1d539b7e07fbcb910c0158c5a74c8a8 100644 --- a/classes/pref/prefs.php +++ b/classes/pref/prefs.php @@ -1009,7 +1009,7 @@ class Pref_Prefs extends Handler_Protected { function setplugins() { $plugins = array_filter($_REQUEST["plugins"], 'clean') ?? []; - set_pref(Prefs::_ENABLED_PLUGINS, implode(",", $plugins)); + //set_pref(Prefs::_ENABLED_PLUGINS, implode(",", $plugins)); } function _get_plugin_version(Plugin $plugin) { diff --git a/js/PrefHelpers.js b/js/PrefHelpers.js index d9b17a698c11c48eed2ca6968aeeff2461f52a0a..04ee10a41a26ca0037cd3117397427bfa72f2060 100644 --- a/js/PrefHelpers.js +++ b/js/PrefHelpers.js @@ -356,6 +356,7 @@ const Helpers = { ++results_rendered; + // only user-enabled actually counts in the checkbox when saving because system plugin checkboxes are disabled (see below) container.innerHTML += ` <li data-row-value="${App.escapeHtml(plugin.name)}" data-plugin-name="${App.escapeHtml(plugin.name)}" title="${plugin.is_system ? __("System plugins are enabled using global configuration.") : ""}"> <label class="checkbox ${plugin.is_system ? "system text-info" : ""}"> @@ -387,11 +388,14 @@ const Helpers = { <div class='version text-muted'>${plugin.version}</div> </li> `; + } else { + // if plugin is outside of search scope, keep current value in case of saving (only user-enabled is needed) + container.innerHTML += App.FormFields.checkbox_tag("plugins[]", plugin.user_enabled, plugin.name, {style: 'display : none'}); } }); if (results_rendered == 0) { - container.innerHTML = `<li class='text-center text-info'>${__("Could not find any plugins for this search query.")}</li>`; + container.innerHTML += `<li class='text-center text-info'>${__("Could not find any plugins for this search query.")}</li>`; } dojo.parser.parse(container);