From dd7299b6d070d26ff97194ef14be349f08776e2a Mon Sep 17 00:00:00 2001
From: Andrew Dolgov <noreply@fakecake.org>
Date: Sun, 14 Nov 2021 17:19:35 +0300
Subject: [PATCH] deal with a few more phpstan warnings re: base plugin class
---
classes/plugin.php | 48 ++++++++++++++++++++++++++++++++-
plugins/af_readability/init.php | 1 +
2 files changed, 48 insertions(+), 1 deletion(-)
diff --git a/classes/plugin.php b/classes/plugin.php
index 96541d033..ac234f081 100644
--- a/classes/plugin.php
+++ b/classes/plugin.php
@@ -226,8 +226,18 @@ abstract class Plugin {
return "";
}
+ /**
+ * @param DOMDocument $doc
+ * @param string $site_url
+ * @param array<string> $allowed_elements
+ * @param array<string> $disallowed_attributes
+ * @param int $article_id
+ * @return DOMDocument
+ */
function hook_sanitize($doc, $site_url, $allowed_elements, $disallowed_attributes, $article_id) {
user_error("Dummy method invoked.", E_USER_ERROR);
+
+ return $doc;
}
/**
@@ -301,8 +311,20 @@ abstract class Plugin {
user_error("Dummy method invoked.", E_USER_ERROR);
}
+ /**
+ * @param string $feed_data
+ * @param string $fetch_url
+ * @param int $owner_uid
+ * @param int $feed
+ * @param int $last_article_timestamp
+ * @param string $auth_login
+ * @param string $auth_pass
+ * @return string (possibly mangled feed data)
+ */
function hook_fetch_feed($feed_data, $fetch_url, $owner_uid, $feed, $last_article_timestamp, $auth_login, $auth_pass) {
user_error("Dummy method invoked.", E_USER_ERROR);
+
+ return "";
}
/**
@@ -331,8 +353,19 @@ abstract class Plugin {
return [];
}
- function hook_format_enclosures($rv, $result, $id, $always_display_enclosures, $article_content, $hide_images) {
+ /**
+ * @param string $enclosures_formatted
+ * @param array<int, array<string, mixed>> $enclosures
+ * @param int $article_id
+ * @param bool $always_display_enclosures
+ * @param string $article_content
+ * @param bool $hide_images
+ * @return string|array<string,array<int, array<string, mixed>>> ($enclosures_formatted, $enclosures)
+ */
+ function hook_format_enclosures($enclosures_formatted, $enclosures, $article_id, $always_display_enclosures, $article_content, $hide_images) {
user_error("Dummy method invoked.", E_USER_ERROR);
+
+ return "";
}
/**
@@ -344,6 +377,8 @@ abstract class Plugin {
*/
function hook_subscribe_feed($contents, $url, $auth_login, $auth_pass) {
user_error("Dummy method invoked.", E_USER_ERROR);
+
+ return "";
}
/**
@@ -366,10 +401,19 @@ abstract class Plugin {
*/
function hook_render_enclosure($entry, $article_id, $rv) {
user_error("Dummy method invoked.", E_USER_ERROR);
+
+ return "";
}
+ /**
+ * @param array<string,mixed> $article
+ * @param string $action
+ * @return array<string,mixed> ($article)
+ */
function hook_article_filter_action($article, $action) {
user_error("Dummy method invoked.", E_USER_ERROR);
+
+ return [];
}
/**
@@ -409,6 +453,8 @@ abstract class Plugin {
*/
function hook_format_article($html, $row) {
user_error("Dummy method invoked.", E_USER_ERROR);
+
+ return "";
}
function hook_feed_basic_info($basic_info, $fetch_url, $owner_uid, $feed_id, $auth_login, $auth_pass) {
diff --git a/plugins/af_readability/init.php b/plugins/af_readability/init.php
index 05b229eae..8e75d0c2e 100755
--- a/plugins/af_readability/init.php
+++ b/plugins/af_readability/init.php
@@ -187,6 +187,7 @@ class Af_Readability extends Plugin {
case "action_append":
return $this->process_article($article, true);
}
+ return $article;
}
public function extract_content($url) {
--
GitLab