Skip to content
Snippets Groups Projects
  1. Nov 25, 2024
  2. Nov 20, 2024
    • Mathijs van Veluw's avatar
      Fix editing members which have access-all rights (#5213) · 96813b13
      Mathijs van Veluw authored
      
      With web-vault v2024.6.2 and lower, if a user has access-all rights either as an org-member or via a group it shouldn't return individual collections.
      
      This probably needs to be changed with newer versions which do not support the `access-all` feature anymore and work with manage.
      But with the current version this should solve access right issues.
      
      Fixes #5212
      
      Signed-off-by: default avatarBlackDex <black.dex@gmail.com>
      Unverified
      96813b13
    • Mathijs van Veluw's avatar
      Fix push not working (#5214) · b0b953f3
      Mathijs van Veluw authored
      
      The new native mobile clients seem to use PascalCase for the push payload.
      Also the date/time could cause issues.
      
      This PR fixes this by formatting the date/time correctly and use PascalCase for the payload key's
      I now receive cipher updates and login-with-device requests again.
      
      Fixes #5182
      
      Signed-off-by: default avatarBlackDex <black.dex@gmail.com>
      Unverified
      b0b953f3
  3. Nov 17, 2024
  4. Nov 15, 2024
  5. Nov 13, 2024
  6. Nov 12, 2024
  7. Nov 11, 2024
    • Mathijs van Veluw's avatar
      Add dynamic CSS support (#4940) · 294b4294
      Mathijs van Veluw authored
      * Add dynamic CSS support
      
      Together with https://github.com/dani-garcia/bw_web_builds/pull/180
      
       this PR will add support for dynamic CSS changes.
      
      For example, we could hide the register link if signups are not allowed.
      In the future show or hide the SSO button depending on if it is enabled or not.
      
      There also is a special `user.vaultwarden.scss` file so that users can add custom CSS without the need to modify the default (static) changes.
      This will prevent future changes from not being applied and still have the custom user changes to be added.
      
      Also added a special redirect when someone goes directly to `/index.html` as that might cause issues with loading other scripts and files.
      
      Signed-off-by: default avatarBlackDex <black.dex@gmail.com>
      
      * Add versions and fallback to built-in
      
      - Add both Vaultwarden and web-vault versions to the css_options.
      - Fallback to the inner templates if rendering or compiling the scss fails.
        This ensures the basics are always working even if someone breaks the templates.
      
      Signed-off-by: default avatarBlackDex <black.dex@gmail.com>
      
      * Fix fallback code to actually work
      
      The fallback now works by using an alternative `reg!` macro.
      This adds an extra template register which prefixes the template with `fallback_`.
      
      Signed-off-by: default avatarBlackDex <black.dex@gmail.com>
      
      * Updated the wiki link in the user template
      
      ---------
      
      Signed-off-by: default avatarBlackDex <black.dex@gmail.com>
      Unverified
      294b4294
    • Daniel García's avatar
      More authrequest fixes (#5176) · 37c14c3c
      Daniel García authored
      Unverified
      37c14c3c
    • Mathijs van Veluw's avatar
      Fix if logic error (#5171) · d0581da6
      Mathijs van Veluw authored
      
      Fixing a logical error in an if statement where we used `&&` which should have been `||`.
      
      Signed-off-by: default avatarBlackDex <black.dex@gmail.com>
      Unverified
      d0581da6
  8. Nov 10, 2024
  9. Nov 02, 2024
  10. Oct 24, 2024
  11. Oct 20, 2024
  12. Oct 19, 2024
    • Mathijs van Veluw's avatar
      Hide user name on invite status (#5110) · 13f4b66e
      Mathijs van Veluw authored
      A possible user disclosure when you invite an user into an organization which already has an account on the same instance.
      This was because we always returned the user's name.
      To prevent this, this PR only returns the user's name if the status is accepted or higher, else we will return null.
      This is the same as Bitwarden does.
      
      Resolves a reported issue.
      
      Also resolved a new `nightly` reported clippy regarding a regex within a loop.
      Unverified
      13f4b66e
    • Daniel's avatar
      Add `extension-refresh` feature flag (#5106) · c967d0dd
      Daniel authored
      - in case people want to try out the new extension design
      Unverified
      c967d0dd
  13. Oct 18, 2024
  14. Oct 13, 2024
  15. Oct 11, 2024
    • Mathijs van Veluw's avatar
      Fix `--version` from failing without config (#5055) · cd195ff2
      Mathijs van Veluw authored
      
      * Fix `--version` from failing without config
      
      Since we added the option to show the web-vault version also when running `--version` this causes the config to always be validated.
      While this is not very bad in general, it could cause the command to quit during the config validation, and not show the version, but also errors.
      This is probably not very useful for this specific command, unlike the `--backup` for example.
      
      To fix this, and preventing the config from being validated, i added an AtomicBool to check if we need to validate the config on first load.
      This prevents errors, and will just show the Vaultwarden version, and if possible the web-vault version too.
      
      Fixes #5046
      
      Signed-off-by: default avatarBlackDex <black.dex@gmail.com>
      
      * Adjusted the code bsaed upon review
      
      Signed-off-by: default avatarBlackDex <black.dex@gmail.com>
      
      ---------
      
      Signed-off-by: default avatarBlackDex <black.dex@gmail.com>
    • Mathijs van Veluw's avatar
      Updates and collection management fixes (#5072) · e3541763
      Mathijs van Veluw authored
      * Fix collections not editable by managers
      
      Since a newer version of the web-vault we use manager were not able to create sub collections anymore.
      This was because of some missing details in the response of some json objects.
      
      This commit fixes this by using the `to_json_details` instead of the `to_json`
      
      Fixes #5066
      Fixes #5044
      
      * Update crates and GitHub Actions
      
      - Updated all the crates
      - Updated all the GHA dependencies
      - Configured the trivy workflow to only run on the main repo and not on forks
        Also selected a random new scheduled date so it will not run at the same time as all other forks.
        The two changes should help running this scan every day without failing, and also prevent the same for new or updated forks.
      Unverified
      e3541763
  16. Oct 06, 2024
    • Mathijs van Veluw's avatar
      Fix compiling for Windows targets (#5053) · f0efec7c
      Mathijs van Veluw authored
      The `unix::signal` was also included during Windows compilations.
      This of course will not work. Fix this by only including it for `unix` targets.
      
      Also changed all other conditional compilation options to use `cfg(unix)` instead of `cfg(not(windows))`.
      The latter may also include `wasm` for example, or any other future target family.
      This way we will only match `unix`
      
      Fixes #5052
      Unverified
      f0efec7c
  17. Sep 23, 2024
  18. Sep 20, 2024
  19. Sep 19, 2024
  20. Sep 18, 2024
  21. Sep 13, 2024
  22. Sep 10, 2024
  23. Sep 09, 2024
  24. Sep 07, 2024
Loading