- Nov 25, 2024
-
-
chuangjinglu authored
Signed-off-by:
chuangjinglu <chuangjinglu@outlook.com>
-
- Nov 20, 2024
-
-
Mathijs van Veluw authored
With web-vault v2024.6.2 and lower, if a user has access-all rights either as an org-member or via a group it shouldn't return individual collections. This probably needs to be changed with newer versions which do not support the `access-all` feature anymore and work with manage. But with the current version this should solve access right issues. Fixes #5212 Signed-off-by:
BlackDex <black.dex@gmail.com>
-
Mathijs van Veluw authored
The new native mobile clients seem to use PascalCase for the push payload. Also the date/time could cause issues. This PR fixes this by formatting the date/time correctly and use PascalCase for the payload key's I now receive cipher updates and login-with-device requests again. Fixes #5182 Signed-off-by:
BlackDex <black.dex@gmail.com>
-
- Nov 17, 2024
-
-
Mathijs van Veluw authored
This fixes an issue with collections be duplicated same as was an issue with folders. Also made some optimizations by using HashSet where possible and device the Vec/Hash capacity. And instead of passing objects only use the UUID which was the only value we needed. Also found an issue with importing a personal export via the Org import where folders are used. Since Org's do not use folder we needed to clear those out, same as Bitwarden does. Fixes #5193 Signed-off-by:
BlackDex <black.dex@gmail.com>
-
- Nov 15, 2024
-
-
Daniel García authored
* Support SSH keys on desktop 2024.12 * Document flags in .env.template * Validate key rotation contents
-
Daniel García authored
-
- Nov 13, 2024
-
-
Stefan Melmuk authored
the web-vault v2024.6.2 currently cannot deal with manage permission so instead of relying on the org user type this should just default to false
-
- Nov 12, 2024
-
-
Stefan Melmuk authored
* fix password hint check don't show password hints if you have disabled the hints with PASSWORD_HINTS_ALLOWED=false or if you have not configured mail and opted into showing password hints * update descriptions for pw hints options
-
Mathijs van Veluw authored
2FA is needed to login even when using login-with-device. If the user didn't saved the 2FA token they still need to provide this. We deleted the auth-request after validation the request, but before 2FA was triggered. Removing the deletion of this record from that point as it will get cleaned-up automatically anyways. Signed-off-by:
BlackDex <black.dex@gmail.com>
-
Mathijs van Veluw authored
* fix hibp username encoding Signed-off-by:
BlackDex <black.dex@gmail.com> * Fix password-hint check Signed-off-by:
BlackDex <black.dex@gmail.com> --------- Signed-off-by:
BlackDex <black.dex@gmail.com>
-
- Nov 11, 2024
-
-
Mathijs van Veluw authored
* Add dynamic CSS support Together with https://github.com/dani-garcia/bw_web_builds/pull/180 this PR will add support for dynamic CSS changes. For example, we could hide the register link if signups are not allowed. In the future show or hide the SSO button depending on if it is enabled or not. There also is a special `user.vaultwarden.scss` file so that users can add custom CSS without the need to modify the default (static) changes. This will prevent future changes from not being applied and still have the custom user changes to be added. Also added a special redirect when someone goes directly to `/index.html` as that might cause issues with loading other scripts and files. Signed-off-by:
BlackDex <black.dex@gmail.com> * Add versions and fallback to built-in - Add both Vaultwarden and web-vault versions to the css_options. - Fallback to the inner templates if rendering or compiling the scss fails. This ensures the basics are always working even if someone breaks the templates. Signed-off-by:
BlackDex <black.dex@gmail.com> * Fix fallback code to actually work The fallback now works by using an alternative `reg!` macro. This adds an extra template register which prefixes the template with `fallback_`. Signed-off-by:
BlackDex <black.dex@gmail.com> * Updated the wiki link in the user template --------- Signed-off-by:
BlackDex <black.dex@gmail.com>
-
Daniel García authored
-
Mathijs van Veluw authored
Fixing a logical error in an if statement where we used `&&` which should have been `||`. Signed-off-by:
BlackDex <black.dex@gmail.com>
-
- Nov 10, 2024
-
-
BlackDex authored
Signed-off-by:
BlackDex <black.dex@gmail.com>
- Nov 02, 2024
-
-
Mathijs van Veluw authored
Updating the Readme to be more modern and more clear. Added and moved several shields/badges and changed some default colors to have a better contrast. Added a Disclaimer section. Closes #4901 Closes #4930 Closes #4931 Closes #5024 Co-authored-by:
ipitio <21136719+ipitio@users.noreply.github.com> Co-authored-by:
Robert Schütz <github@dotlambda.de> Co-authored-by:
Yonas Yanfa <yonas.y@gmail.com> Co-authored-by:
KUSUMA RUSHIKESH <141169227+rushi-k12@users.noreply.github.com>
-
- Oct 24, 2024
-
-
Mathijs van Veluw authored
- Updated all the crates Including in this update is an update from lettre, which solves an issue with some specific SMTP mail providers.
-
- Oct 20, 2024
-
-
Daniel authored
-
- Oct 19, 2024
-
-
Mathijs van Veluw authored
A possible user disclosure when you invite an user into an organization which already has an account on the same instance. This was because we always returned the user's name. To prevent this, this PR only returns the user's name if the status is accepted or higher, else we will return null. This is the same as Bitwarden does. Resolves a reported issue. Also resolved a new `nightly` reported clippy regarding a regex within a loop.
-
Daniel authored
- in case people want to try out the new extension design
-
- Oct 18, 2024
-
-
Mathijs van Veluw authored
- Fixed collection management to be usable from the Password Manager UI - Checked and brought in-to-sync with upstream several json responses - Fixed a small issue with the `fields` response when it was empty Signed-off-by:
BlackDex <black.dex@gmail.com>
-
Daniel authored
- raise MSRV to 1.80.0 - also update the crates
-
Mathijs van Veluw authored
Ever since we changed to pass the full url as a template value handlebars now html-encodes this. This causes issues with the plain/text mails, but it also could potentially cause issues with the text/html templates. This PR encloses the template values inside triple braces `{{{ }}}` which prevents html-encoding. Since the URL is generated via the `url` crate the values are percent-encoded anyway. Fixes #5097 Signed-off-by:
BlackDex <black.dex@gmail.com>
-
- Oct 13, 2024
-
-
Mathijs van Veluw authored
In an oversight i forgot to set the type to a hidden type if converting the int was not possible. This fixes that. Signed-off-by:
BlackDex <black.dex@gmail.com>
-
Mathijs van Veluw authored
It seems the iOS clients are not able to handle the `type` key within the `fields` array when they are of the type string. All other clients seem to handle this just fine though. This PR fixes this by validating it is a number, if this is not the case, try to convert the string to a number, or return the default of `1`. `1` is used as this is the type `hidden` and should prevent accidental data disclosure. Fixes #5069 Possibly Fixes #5016 Possibly Fixes #5002 Signed-off-by:
BlackDex <black.dex@gmail.com>
-
- Oct 11, 2024
-
-
Mathijs van Veluw authored
* Fix `--version` from failing without config Since we added the option to show the web-vault version also when running `--version` this causes the config to always be validated. While this is not very bad in general, it could cause the command to quit during the config validation, and not show the version, but also errors. This is probably not very useful for this specific command, unlike the `--backup` for example. To fix this, and preventing the config from being validated, i added an AtomicBool to check if we need to validate the config on first load. This prevents errors, and will just show the Vaultwarden version, and if possible the web-vault version too. Fixes #5046 Signed-off-by:
BlackDex <black.dex@gmail.com> * Adjusted the code bsaed upon review Signed-off-by:
BlackDex <black.dex@gmail.com> --------- Signed-off-by:
BlackDex <black.dex@gmail.com>
-
Mathijs van Veluw authored
* Fix collections not editable by managers Since a newer version of the web-vault we use manager were not able to create sub collections anymore. This was because of some missing details in the response of some json objects. This commit fixes this by using the `to_json_details` instead of the `to_json` Fixes #5066 Fixes #5044 * Update crates and GitHub Actions - Updated all the crates - Updated all the GHA dependencies - Configured the trivy workflow to only run on the main repo and not on forks Also selected a random new scheduled date so it will not run at the same time as all other forks. The two changes should help running this scan every day without failing, and also prevent the same for new or updated forks.
-
- Oct 06, 2024
-
-
Mathijs van Veluw authored
The `unix::signal` was also included during Windows compilations. This of course will not work. Fix this by only including it for `unix` targets. Also changed all other conditional compilation options to use `cfg(unix)` instead of `cfg(not(windows))`. The latter may also include `wasm` for example, or any other future target family. This way we will only match `unix` Fixes #5052
-
- Sep 23, 2024
-
-
Mathijs van Veluw authored
* Add extra linting Added extra linting for some code styles. Also added the Rust Edition 2024 lints. Closes #4974 Signed-off-by:
BlackDex <black.dex@gmail.com> * Adjusted according to comments Signed-off-by:
BlackDex <black.dex@gmail.com> --------- Signed-off-by:
BlackDex <black.dex@gmail.com>
-
- Sep 20, 2024
-
-
Daniel García authored
* Avoid keyword collision with gen in Rust 2024 * Include new api/config setting to disable user registration, not yet used by clients * Actually qualify CONFIG
-
Mathijs van Veluw authored
It appears that some password histories have an encrypted value on the `lastUsedDate` Instead of only checking if it is a string, also check if it is a valid RFC Date/Time String. If not, set it also to epoch 0. Signed-off-by:
BlackDex <black.dex@gmail.com>
-
Mathijs van Veluw authored
-
- Sep 19, 2024
-
-
Stefan Melmuk authored
-
- Sep 18, 2024
-
-
Daniel authored
- match Bitwarden behaviour - add a different segment in mails for Device Name
-
Stefan Melmuk authored
-
Mathijs van Veluw authored
It seemed to have been possible to have `null` date values. This PR fixes this by setting the epoch start date if either the date does not exists or is not a string. This should solve sync issues with the new native mobile clients. Fixes https://github.com/dani-garcia/vaultwarden/pull/4932#issuecomment-2357581292 Signed-off-by:
BlackDex <black.dex@gmail.com>
-
- Sep 13, 2024
-
-
Stefan Melmuk authored
-
- Sep 10, 2024
-
-
Mathijs van Veluw authored
-
- Sep 09, 2024
-
-
Mathijs van Veluw authored
-
- Sep 07, 2024
-
-
Daniel authored
-