Skip to content
Snippets Groups Projects
  1. Nov 18, 2021
  2. Nov 17, 2021
  3. Nov 16, 2021
  4. Nov 14, 2021
  5. Nov 13, 2021
  6. Nov 12, 2021
  7. Nov 11, 2021
  8. Nov 06, 2021
  9. Nov 05, 2021
    • Claire's avatar
      Fix reviving revoked sessions and invalidating login (#16943) · 6da135a4
      Claire authored
      Up until now, we have used Devise's Rememberable mechanism to re-log users
      after the end of their browser sessions. This mechanism relies on a signed
      cookie containing a token. That token was stored on the user's record,
      meaning it was shared across all logged in browsers, meaning truly revoking
      a browser's ability to auto-log-in involves revoking the token itself, and
      revoking access from *all* logged-in browsers.
      
      We had a session mechanism that dynamically checks whether a user's session
      has been disabled, and would log out the user if so. However, this would only
      clear a session being actively used, and a new one could be respawned with
      the `remember_user_token` cookie.
      
      In practice, this caused two issues:
      - sessions could be revived after being closed from /auth/edit (security issue)
      - auto-log-in would be disabled for *all* browsers after logging out from one
        of them
      
      This PR removes the `remember_token` mechanism and treats the `_session_id`
      cookie/token as a browser-specific `remember_token`, fixing both issues.
      Unverified
      6da135a4
    • Claire's avatar
    • Eugen Rochko's avatar
      Add support for structured data and more OpenGraph tags to link cards (#16938) · 39cdf61a
      Eugen Rochko authored
      Save preview cards under their canonical URL
      
      Increase max redirects to follow from 2 to 3
      Unverified
      39cdf61a
    • Claire's avatar
      Fix handling announcements with links (#16941) · 989c67d2
      Claire authored
      Broken since #15827
      Unverified
      989c67d2
Loading