Skip to content
Snippets Groups Projects
  1. Dec 27, 2017
  2. Dec 15, 2017
  3. Dec 13, 2017
  4. Dec 10, 2017
  5. Dec 06, 2017
  6. Nov 30, 2017
    • Eugen Rochko's avatar
      Add semi-support for Video/Image objects in ActivityPub (#5848) · 4c6b5dbe
      Eugen Rochko authored
      * Add semi-support for Video/Image objects in ActivityPub
      
      Video and Image objects will create corresponding status records
      with manually crafted text contents (title + URL)
      
      * Extract html-url-finding logic into JsonLdHelper
      
      * Fallback to id when url missing, extract supported object types
      4c6b5dbe
    • Eugen Rochko's avatar
      Fix too many forwards (#5854) · 85e97eca
      Eugen Rochko authored
      * Avoid sending explicit Undo->Announce when original deleted
      
      * Do not forward a reply back to the server that sent it
      
      * Deduplicate inboxes of rebloggers' followers for delete forwarding
      
      * Adjust test
      
      * Fix wrong class, bad SQL, wrong variable, outdated comment
      85e97eca
  7. Nov 28, 2017
    • aschmitz's avatar
      Allow hiding of reblogs from followed users (#5762) · eeaec398
      aschmitz authored
      * Allow hiding of reblogs from followed users
      
      This adds a new entry to the account menu to allow users to hide
      future reblogs from a user (and then if they've done that, to show
      future reblogs instead).
      
      This does not remove or add historical reblogs from/to the user's
      timeline; it only affects new statuses.
      
      The API for this operates by sending a "reblogs" key to the follow
      endpoint. If this is sent when starting a new follow, it will be
      respected from the beginning of the follow relationship (even if
      the follow request must be approved by the followee). If this is
      sent when a follow relationship already exists, it will simply
      update the existing follow relationship. As with the notification
      muting, this will now return an object ({reblogs: [true|false]}) or
      false for each follow relationship when requesting relationship
      information for an account. This should cause few issues due to an
      object being truthy in many languages, but some modifications may
      need to be made in pickier languages.
      
      Database changes: adds a show_reblogs column (default true,
      non-nullable) to the follows and follow_requests tables. Because
      these are non-nullable, we use the existing MigrationHelpers to
      perform this change without locking those tables, although the
      tables are likely to be small anyway.
      
      Tests included.
      
      See also <https://github.com/glitch-soc/mastodon/pull/212>.
      
      * Rubocop fixes
      
      * Code review changes
      
      * Test fixes
      
      This patchset closes #648 and resolves #3271.
      
      * Rubocop fix
      
      * Revert reblogs defaulting in argument, fix tests
      
      It turns out we needed this for the same reason we needed it in muting:
      if nil gets passed in somehow (most usually by an API client not passing
      any value), we need to detect and handle it.
      
      We could specify a default in the parameter and then also catch nil, but
      there's no great reason to duplicate the default value.
      eeaec398
  8. Nov 18, 2017
    • Eugen Rochko's avatar
      Profile redirect notes (#5746) · 58cede48
      Eugen Rochko authored
      * Serialize moved accounts into REST and ActivityPub APIs
      
      * Parse federated moved accounts from ActivityPub
      
      * Add note about moved accounts to public profiles
      
      * Add moved account message to web UI
      
      * Fix code style issues
      58cede48
  9. Nov 17, 2017
    • Eugen Rochko's avatar
      Lists (#5703) · 24cafd73
      Eugen Rochko authored
      * Add structure for lists
      
      * Add list timeline streaming API
      
      * Add list APIs, bind list-account relation to follow relation
      
      * Add API for adding/removing accounts from lists
      
      * Add pagination to lists API
      
      * Add pagination to list accounts API
      
      * Adjust scopes for new APIs
      
      - Creating and modifying lists merely requires "write" scope
      - Fetching information about lists merely requires "read" scope
      
      * Add test for wrong user context on list timeline
      
      * Clean up tests
      24cafd73
    • Eugen Rochko's avatar
      Fix some rubocop style issues (#5730) · 3e90987c
      Eugen Rochko authored
      3e90987c
  10. Nov 16, 2017
    • Renato "Lond" Cerqueira's avatar
      Improve language filter (#5724) · ad207456
      Renato "Lond" Cerqueira authored
      * Scrub text of html before detecting language.
      
      * Detect language on statuses coming from activitypub.
      
      * Fix rubocop comments.
      
      * Remove custom emoji from text before language detection
      ad207456
  11. Nov 07, 2017
  12. Oct 27, 2017
  13. Oct 17, 2017
  14. Oct 16, 2017
    • Eugen Rochko's avatar
      Keep references to all reblogs of a status on home feed (#5419) · 34118169
      Eugen Rochko authored
      * Keep references to all reblogs of a status on home feed
      
      When inserting reblog: Add to set of reblogs of this status on
      the feed, if original status was present in the feed, add it to
      that set as well.
      
      When removing a reblog: Remove it from that set. Take random
      remaining item from the set. If one exists, re-insert it into feed,
      otherwise do not re-insert anything.
      
      Fix #4210
      
      * When original is removed, toss out reblog references
      34118169
    • Eugen Rochko's avatar
      Ensure that feed renegeration restores non-zero items (#5409) · 7cc71748
      Eugen Rochko authored
      Fix #5398
      
      Ordering the home timeline query by account_id meant that the first
      100 items belonged to a single account. There was also no reason to
      reverse-iterate over the statuses. Assuming the user accesses the
      feed halfway-through, it's better to have recent statuses already
      available at the top. Therefore working from newer->older is ideal.
      
      If the algorithm ends up filtering all items out during last-mile
      filtering, repeat again a page further. The algorithm terminates
      when either at least one item has been added, or if the database
      query returns nothing (end of data reached)
      7cc71748
    • unarist's avatar
      Fix un-reblogged status being at wrong position in the home timeline (#5418) · 6f490b4b
      unarist authored
      We've changed un-reblogging behavior when we implement Snowflake, to insert un-reblogged status at the position reblogging status existed.
      
      However, our API expects home timeline is ordered by status ids, and max_id/since_id filters by zset score. Due to this, un-reblogged status appears as a last item of result set, and timeline expansion may skips many statuses.
      
      So this reverts that change...reblogged status inserted at corresponding position to its id.
      6f490b4b
    • Nolan Lawson's avatar
      Add option to reduce motion (#5393) · fa0be3f8
      Nolan Lawson authored
      * Add option to reduce motion
      
      * Use HOC to wrap all Motion calls
      
      * fix case-sensitive issue
      
      * Avoid updating too frequently
      
      * Get rid of unnecessary change to _simple_status.html.haml
      fa0be3f8
  15. Oct 14, 2017
  16. Oct 13, 2017
  17. Oct 08, 2017
  18. Oct 07, 2017
  19. Oct 06, 2017
  20. Oct 05, 2017
  21. Oct 04, 2017
    • Yamagishi Kazutoshi's avatar
      Separate notifications preferences from general preferences (#4447) · 178f718a
      Yamagishi Kazutoshi authored
      * Separate notifications preferences from general preferences
      
      * Refine settings/notifications/show
      
      * remove preferences.notifications
      178f718a
    • aschmitz's avatar
      Non-Serial ("Snowflake") IDs (#4801) · 468523f4
      aschmitz authored
      * Use non-serial IDs
      
      This change makes a number of nontrivial tweaks to the data model in
      Mastodon:
      
      * All IDs are now 8 byte integers (rather than mixed 4- and 8-byte)
      * IDs are now assigned as:
        * Top 6 bytes: millisecond-resolution time from epoch
        * Bottom 2 bytes: serial (within the millisecond) sequence number
        * See /lib/tasks/db.rake's `define_timestamp_id` for details, but
          note that the purpose of these changes is to make it difficult to
          determine the number of objects in a table from the ID of any
          object.
      * The Redis sorted set used for the feed will have values used to look
        up toots, rather than scores. This is almost always the same as the
        existing behavior, except in the case of boosted toots. This change
        was made because Redis stores scores as double-precision floats,
        which cannot store the new ID format exactly. Note that this doesn't
        cause problems with sorting/pagination, because ZREVRANGEBYSCORE
        sorts lexicographically when scores are tied. (This will still cause
        sorting issues when the ID gains a new significant digit, but that's
        extraordinarily uncommon.)
      
      Note a couple of tradeoffs have been made in this commit:
      
      * lib/tasks/db.rake is used to enforce many/most column constraints,
        because this commit seems likely to take a while to bring upstream.
        Enforcing a post-migrate hook is an easier way to maintain the code
        in the interim.
      * Boosted toots will appear in the timeline as many times as they have
        been boosted. This is a tradeoff due to the way the feed is saved in
        Redis at the moment, but will be handled by a future commit.
      
      This would effectively close Mastodon's #1059, as it is a
      snowflake-like system of generating IDs. However, given how involved
      the changes were simply within Mastodon, it may have unexpected
      interactions with some clients, if they store IDs as doubles
      (or as 4-byte integers). This was a problem that Twitter ran into with
      their "snowflake" transition, particularly in JavaScript clients that
      treated IDs as JS integers, rather than strings. It therefore would be
      useful to test these changes at least in the web interface and popular
      clients before pushing them to all users.
      
      * Fix JavaScript interface with long IDs
      
      Somewhat predictably, the JS interface handled IDs as numbers, which in
      JS are IEEE double-precision floats. This loses some precision when
      working with numbers as large as those generated by the new ID scheme,
      so we instead handle them here as strings. This is relatively simple,
      and doesn't appear to have caused any problems, but should definitely
      be tested more thoroughly than the built-in tests. Several days of use
      appear to support this working properly.
      
      BREAKING CHANGE:
      
      The major(!) change here is that IDs are now returned as strings by the
      REST endpoints, rather than as integers. In practice, relatively few
      changes were required to make the existing JS UI work with this change,
      but it will likely hit API clients pretty hard: it's an entirely
      different type to consume. (The one API client I tested, Tusky, handles
      this with no problems, however.)
      
      Twitter ran into this issue when introducing Snowflake IDs, and decided
      to instead introduce an `id_str` field in JSON responses. I have opted
      to *not* do that, and instead force all IDs to 64-bit integers
      represented by strings in one go. (I believe Twitter exacerbated their
      problem by rolling out the changes three times: once for statuses, once
      for DMs, and once for user IDs, as well as by leaving an integer ID
      value in JSON. As they said, "If you’re using the `id` field with JSON
      in a Javascript-related language, there is a very high likelihood that
      the integers will be silently munged by Javascript interpreters. In most
      cases, this will result in behavior such as being unable to load or
      delete a specific direct message, because the ID you're sending to the
      API is different than the actual identifier associated with the
      message." [1]) However, given that this is a significant change for API
      users, alternatives or a transition time may be appropriate.
      
      1: https://blog.twitter.com/developer/en_us/a/2011/direct-messages-going-snowflake-on-sep-30-2011.html
      
      * Restructure feed pushes/unpushes
      
      This was necessary because the previous behavior used Redis zset scores
      to identify statuses, but those are IEEE double-precision floats, so we
      can't actually use them to identify all 64-bit IDs. However, it leaves
      the code in a much better state for refactoring reblog handling /
      coalescing.
      
      Feed-management code has been consolidated in FeedManager, including:
      
      * BatchedRemoveStatusService no longer directly manipulates feed zsets
      * RemoveStatusService no longer directly manipulates feed zsets
      * PrecomputeFeedService has moved its logic to FeedManager#populate_feed
      
      (PrecomputeFeedService largely made lots of calls to FeedManager, but
      didn't follow the normal adding-to-feed process.)
      
      This has the effect of unifying all of the feed push/unpush logic in
      FeedManager, making it much more tractable to update it in the future.
      
      Due to some additional checks that must be made during, for example,
      batch status removals, some Redis pipelining has been removed. It does
      not appear that this should cause significantly increased load, but if
      necessary, some optimizations are possible in batch cases. These were
      omitted in the pursuit of simplicity, but a batch_push and batch_unpush
      would be possible in the future.
      
      Tests were added to verify that pushes happen under expected conditions,
      and to verify reblog behavior (both on pushing and unpushing). In the
      case of unpushing, this includes testing behavior that currently leads
      to confusion such as Mastodon's #2817, but this codifies that the
      behavior is currently expected.
      
      * Rubocop fixes
      
      I could swear I made these changes already, but I must have lost them
      somewhere along the line.
      
      * Address review comments
      
      This addresses the first two comments from review of this feature:
      
      https://github.com/tootsuite/mastodon/pull/4801#discussion_r139336735
      https://github.com/tootsuite/mastodon/pull/4801#discussion_r139336931
      
      This adds an optional argument to FeedManager#key, the subtype of feed
      key to generate. It also tests to ensure that FeedManager's settings are
      such that reblogs won't be tracked forever.
      
      * Hardcode IdToBigints migration columns
      
      This addresses a comment during review:
      https://github.com/tootsuite/mastodon/pull/4801#discussion_r139337452
      
      This means we'll need to make sure that all _id columns going forward
      are bigints, but that should happen automatically in most cases.
      
      * Additional fixes for stringified IDs in JSON
      
      These should be the last two. These were identified using eslint to try
      to identify any plain casts to JavaScript numbers. (Some such casts are
      legitimate, but these were not.)
      
      Adding the following to .eslintrc.yml will identify casts to numbers:
      
      ~~~
        no-restricted-syntax:
        - warn
        - selector: UnaryExpression[operator='+'] > :not(Literal)
          message: Avoid the use of unary +
        - selector: CallExpression[callee.name='Number']
          message: Casting with Number() may coerce string IDs to numbers
      ~~~
      
      The remaining three casts appear legitimate: two casts to array indices,
      one in a server to turn an environment variable into a number.
      
      * Only implement timestamp IDs for Status IDs
      
      Per discussion in #4801, this is only being merged in for Status IDs at
      this point. We do this in a migration, as there is no longer use for
      a post-migration hook. We keep the initialization of the timestamp_id
      function as a Rake task, as it is also needed after db:schema:load (as
      db/schema.rb doesn't store Postgres functions).
      
      * Change internal streaming payloads to stringified IDs as well
      
      This is equivalent to 591a9af356faf2d5c7e66e3ec715502796c875cd from
      #5019, with an extra change for the addition to FeedManager#unpush.
      
      * Ensure we have a status_id_seq sequence
      
      Apparently this is not a given when specifying a custom ID function,
      so now we ensure it gets created. This uses the generic version of this
      function to more easily support adding additional tables with timestamp
      IDs in the future, although it would be possible to cut this down to a
      less generic version if necessary. It is only run during db:schema:load
      or the relevant migration, so the overhead is extraordinarily minimal.
      
      * Transition reblogs to new Redis format
      
      This provides a one-way migration to transition old Redis reblog entries
      into the new format, with a separate tracking entry for reblogs.
      
      It is not invertible because doing so could (if timestamp IDs are used)
      require a database query for each status in each users' feed, which is
      likely to be a significant toll on major instances.
      
      * Address review comments from @akihikodaki
      
      No functional changes.
      
      * Additional review changes
      
      * Heredoc cleanup
      
      * Run db:schema:load hooks for test in development
      
      This matches the behavior in Rails'
      ActiveRecord::Tasks::DatabaseTasks.each_current_configuration, which
      would otherwise break `rake db:setup` in development.
      
      It also moves some functionality out to a library, which will be a good
      place to put additional related functionality in the near future.
      468523f4
  22. Oct 03, 2017
    • Akihiko Odaki's avatar
      Validate id of ActivityPub representations (#5114) · 63f09797
      Akihiko Odaki authored
      Additionally, ActivityPub::FetchRemoteStatusService no longer parses
      activities.
      OStatus::Activity::Creation no longer delegates to ActivityPub because
      the provided ActivityPub representations are not signed while OStatus
      representations are.
      63f09797
  23. Oct 02, 2017
  24. Sep 29, 2017
  25. Sep 28, 2017
    • Eugen Rochko's avatar
      Change max redirects followed to 2 (#5136) · d2f56d1c
      Eugen Rochko authored
      I see no reason to allow more than that. Usually a redirect is
      HTTP->HTTPS, then maybe URL structure changed, but more than that
      is highly unlikely to be a legitimate use case.
      d2f56d1c
    • Eugen Rochko's avatar
      Add ability to specify alternative text for media attachments (#5123) · 4ec17711
      Eugen Rochko authored
      * Fix #117 - Add ability to specify alternative text for media attachments
      
      - POST /api/v1/media accepts `description` straight away
      - PUT /api/v1/media/:id to update `description` (only for unattached ones)
      - Serialized as `name` of Document object in ActivityPub
      - Uploads form adjusted for better performance and description input
      
      * Add tests
      
      * Change undo button blend mode to difference
      4ec17711
  26. Sep 25, 2017
  27. Sep 23, 2017
    • Eugen Rochko's avatar
      Add emoji autosuggest (#5053) · 1e02ba11
      Eugen Rochko authored
      * Add emoji autosuggest
      
      Some credit goes to glitch-soc/mastodon#149
      
      * Remove server-side shortcode->unicode conversion
      
      * Insert shortcode when suggestion is custom emoji
      
      * Remove remnant of server-side emojis
      
      * Update style of autosuggestions
      
      * Fix wrong emoji filenames generated in autosuggest item
      
      * Do not lazy load emoji picker, as that no longer works
      
      * Fix custom emoji autosuggest
      
      * Fix multiple "Custom" categories getting added to emoji index, only add once
      1e02ba11
Loading