Skip to content
Snippets Groups Projects
Unverified Commit 1309fdd3 authored by Thomas Citharel's avatar Thomas Citharel
Browse files

Add npm run lint to CI and to docs


Signed-off-by: default avatarThomas Citharel <tcit@tcit.fr>
parent b698eb47
No related branches found
No related tags found
No related merge requests found
......@@ -53,6 +53,19 @@ js_deps:
- js/node_modules
allow_failure: true
js_check:
stage: front
before_script:
- cd js
- npm install
script:
- npm run lint
after_script:
- cd ../
cache:
paths:
- js/node_modules
elixir_check:
stage: back
before_script:
......
......@@ -4,7 +4,7 @@
We format our code with the Elixir Formatter and check for issues with [Credo](https://github.com/rrrene/credo) (a few rules are not blocking).
Please run those two commands before pushing code :
Please run those two commands before pushing code:
* `mix format`
* `mix credo`
......@@ -15,4 +15,8 @@ These two commands must not return an error code, since they are required to pas
We use `tslint` with the `tslint-config-airbnb` preset.
Errors should be reported when running in dev mode `npm run dev` or when building a production bundle `npm run build`.
Please run the following command before pushing code `npm run lint`.
This command must not return an error code, since it's required to pass inside CI.
We also try to follow the [official Vue.js style guide](https://vuejs.org/v2/style-guide/).
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment