Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
Mobilizon
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
TeDomum
Mobilizon
Commits
1309fdd3
Unverified
Commit
1309fdd3
authored
6 years ago
by
Thomas Citharel
Browse files
Options
Downloads
Patches
Plain Diff
Add npm run lint to CI and to docs
Signed-off-by:
Thomas Citharel
<
tcit@tcit.fr
>
parent
b698eb47
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
.gitlab-ci.yml
+13
-0
13 additions, 0 deletions
.gitlab-ci.yml
support/guides/development/styleguide.md
+5
-1
5 additions, 1 deletion
support/guides/development/styleguide.md
with
18 additions
and
1 deletion
.gitlab-ci.yml
+
13
−
0
View file @
1309fdd3
...
...
@@ -53,6 +53,19 @@ js_deps:
-
js/node_modules
allow_failure
:
true
js_check
:
stage
:
front
before_script
:
-
cd js
-
npm install
script
:
-
npm run lint
after_script
:
-
cd ../
cache
:
paths
:
-
js/node_modules
elixir_check
:
stage
:
back
before_script
:
...
...
This diff is collapsed.
Click to expand it.
support/guides/development/styleguide.md
+
5
−
1
View file @
1309fdd3
...
...
@@ -4,7 +4,7 @@
We format our code with the Elixir Formatter and check for issues with
[
Credo
](
https://github.com/rrrene/credo
)
(
a
few rules are not blocking).
Please run those two commands before pushing code
:
Please run those two commands before pushing code:
*
`mix format`
*
`mix credo`
...
...
@@ -15,4 +15,8 @@ These two commands must not return an error code, since they are required to pas
We use
`tslint`
with the
`tslint-config-airbnb`
preset.
Errors should be reported when running in dev mode
`npm run dev`
or when building a production bundle
`npm run build`
.
Please run the following command before pushing code
`npm run lint`
.
This command must not return an error code, since it's required to pass inside CI.
We also try to follow the
[
official Vue.js style guide
](
https://vuejs.org/v2/style-guide/
)
.
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment