Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
Matrix
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Container Registry
Model registry
Operate
Environments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
TeDomum
Matrix
Commits
c87572d6
Unverified
Commit
c87572d6
authored
5 years ago
by
Michael Kaye
Committed by
GitHub
5 years ago
Browse files
Options
Downloads
Patches
Plain Diff
Update CONTRIBUTING.md about merging PRs. (#6846)
parent
c7d6d5c6
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
CONTRIBUTING.md
+14
-0
14 additions, 0 deletions
CONTRIBUTING.md
changelog.d/6846.doc
+1
-0
1 addition, 0 deletions
changelog.d/6846.doc
with
15 additions
and
0 deletions
CONTRIBUTING.md
+
14
−
0
View file @
c87572d6
...
...
@@ -200,6 +200,20 @@ Git allows you to add this signoff automatically when using the `-s`
flag to
`git commit`
, which uses the name and email set in your
`user.name`
and
`user.email`
git configs.
## Merge Strategy
We use the commit history of develop/master extensively to identify
when regressions were introduced and what changes have been made.
We aim to have a clean merge history, which means we normally squash-merge
changes into develop. For small changes this means there is no need to rebase
to clean up your PR before merging. Larger changes with an organised set of
commits may be merged as-is, if the history is judged to be useful.
This use of squash-merging will mean PRs built on each other will be hard to
merge. We suggest avoiding these where possible, and if required, ensuring
each PR has a tidy set of commits to ease merging.
## Conclusion
That's it! Matrix is a very open and collaborative project as you might expect
...
...
This diff is collapsed.
Click to expand it.
changelog.d/6846.doc
0 → 100644
+
1
−
0
View file @
c87572d6
Add details of PR merge strategy to contributing docs.
\ No newline at end of file
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment