Skip to content
Snippets Groups Projects
  1. Mar 25, 2021
  2. Mar 23, 2021
  3. Mar 22, 2021
  4. Mar 17, 2021
  5. Mar 16, 2021
  6. Mar 15, 2021
  7. Mar 14, 2021
  8. Mar 13, 2021
  9. Mar 07, 2021
    • Jeremy Lin's avatar
      CORS fixes · 7d0e234b
      Jeremy Lin authored
      * The Safari extension apparently now uses the origin `file://` and expects
        that to be returned (see bitwarden/browser#1311, bitwarden/server#800).
      
      * The `Access-Control-Allow-Origin` header was reflecting the value of the
        `Origin` header without checking whether the origin was actually allowed.
        This effectively allows any origin to interact with the server, which
        defeats the purpose of CORS.
      7d0e234b
  10. Mar 06, 2021
  11. Mar 04, 2021
  12. Feb 28, 2021
    • Jeremy Lin's avatar
      Check for data folder on startup · 513056f7
      Jeremy Lin authored
      Currently, when starting up for the first time (running standalone, outside
      of Docker), bitwarden_rs panics when the `openssl` tool isn't able to create
      `data/rsa_key.pem` due to the `data` dir not existing. Instead, print a more
      helpful error message telling the user to create the directory.
      513056f7
  13. Feb 27, 2021
  14. Feb 24, 2021
  15. Feb 19, 2021
  16. Feb 07, 2021
  17. Feb 06, 2021
  18. Feb 03, 2021
  19. Jan 31, 2021
    • BlackDex's avatar
      JSON Response updates and small fixes · 7dff8c01
      BlackDex authored
      Updated several json response models.
      Also fixed a few small bugs.
      
      ciphers.rs:
        - post_ciphers_create:
          * Prevent cipher creation to organization without a collection.
        - update_cipher_from_data:
          * ~~Fixed removal of user_uuid which prevent user-owned shared-cipher to be not editable anymore when set to read-only.~~
          * Cleanup the json_data by removing the `Response` key/values from several objects.
        - delete_all:
          * Do not delete all Collections during the Purge of an Organization (same as upstream).
      
      cipher.rs:
        - Cipher::to_json:
          * Updated json response to match upstream.
          * Return empty json object if there is no type_data instead of values which should not be set for the type_data.
      
      organizations.rs:
        * Added two new endpoints to prevent Javascript errors regarding tax
      
      organization.rs:
        - Organization::to_json:
          * Updated response model to match upstream
        - UserOrganization::to_json:
          * Updated response model to match upstream
      
      collection.rs:
        - Collection::{to_json, to_json_details}:
          * Updated the json response model, and added a detailed version used during the sync
        - hide_passwords_for_user:
          * Added this function to return if the passwords should be hidden or not for the user at the specific collection (used by `to_json_details`)
      
      Update 1: Some small changes after comments from @jjlin.
      Update 2: Fixed vault purge by user to make sure the cipher is not part of an organization.
      
      Resolves #971
      Closes #990, Closes #991
      7dff8c01
    • BlackDex's avatar
      Updated dependencies and small mail fixes · 58606796
      BlackDex authored
      - Updated rust nightly
      - Updated depenencies
      - Removed unicode support for regex (less dependencies)
      - Fixed dependency and nightly changes/deprications
      - Some mail changes for less spam point triggering
      58606796
  20. Jan 27, 2021
    • Jeremy Lin's avatar
      Fix collection access issues for owner/admin users · 67c65700
      Jeremy Lin authored
      The implementation of the `Manager` user type (#1242) introduced a regression
      whereby owner/admin users are incorrectly denied access to certain collection
      APIs if their access control for collections isn't set to "access all".
      
      Owner/admin users should always have full access to collection APIs, per
      https://bitwarden.com/help/article/user-types-access-control/#access-control:
      
      > Assigning Admins and Owners to Collections via Access Control will only
      > impact which Collections appear readily in the Filters section of their
      > Vault. Admins and Owners will always be able to access "un-assigned"
      > Collections via the Organization view.
      67c65700
  21. Jan 25, 2021
  22. Jan 24, 2021
  23. Jan 19, 2021
    • BlackDex's avatar
      Updated the admin interface · 235ff447
      BlackDex authored
      Mostly updated the admin interface, also some small other items.
      
      - Added more diagnostic information to (hopefully) decrease issue
        reporting, or at least solve them quicker.
      - Added an option to generate a support string which can be used to
        copy/paste on the forum or during the creation of an issue. It will
      try to hide the sensitive information automatically.
      - Changed the `Created At` and `Last Active` info to be in a column and
        able to sort them in the users overview.
      - Some small layout changes.
      - Updated javascript and css files to the latest versions available.
      - Decreased the png file sizes using `oxipng`
      - Updated target='_blank' links to have rel='noreferrer' to prevent
        javascript window.opener modifications.
      235ff447
  24. Dec 14, 2020
    • BlackDex's avatar
      Fix Key Rotation during password change · de86aa67
      BlackDex authored
      When ticking the 'Also rotate my account's encryption key' box, the key
      rotated ciphers are posted after the change of password.
      
      During the password change the security stamp was reseted which made
      the posted key's return an invalid auth. This reset is needed to prevent other clients from still being able to read/write.
      
      This fixes this by adding a new database column which stores a stamp exception which includes the allowed route and the current security stamp before it gets reseted.
      When the security stamp check fails it will check if there is a stamp exception and tries to match the route and security stamp.
      
      Currently it only allows for one exception. But if needed we could expand it by using a Vec<UserStampException> and change the functions accordingly.
      
      fixes #1240
      de86aa67
    • Jeremy Lin's avatar
      Clean up datetime output and code · 455a2336
      Jeremy Lin authored
      * For clarity, add `UTC` suffix for datetimes in the `Diagnostics` admin tab.
      * Format datetimes in the local timezone in the `Users` admin tab.
      * Refactor some datetime code and add doc comments.
      455a2336
  25. Dec 10, 2020
  26. Dec 08, 2020
    • BlackDex's avatar
      Updated icon downloading · 48baf723
      BlackDex authored
      - Added more checks to prevent panics (Removed unwrap)
      - Try do download from base domain or add www when the provided domain
        fails
      - Added some more domain validation checks to prevent errors
      - Added the ICON_BLACKLIST_REGEX to a Lazy Static HashMap which
        speeds-up the checks!
      - Validate the Regex before starting/config change.
      - Some cleanups
      - Disabled some noisy debugging from 2 crates.
      48baf723
    • Jeremy Lin's avatar
      Validate cipher updates with revision date · a9e9a397
      Jeremy Lin authored
      Prevent clients from updating a cipher if the local copy is stale.
      Validation is only performed when the client provides its last known
      revision date; this date isn't provided when using older clients,
      or when the operation doesn't involve updating an existing cipher.
      
      Upstream PR: https://github.com/bitwarden/server/pull/994
      a9e9a397
Loading