Skip to content
Snippets Groups Projects
  1. Jan 25, 2024
  2. Jan 12, 2024
  3. Jan 10, 2024
  4. Jan 01, 2024
    • Daniel García's avatar
      Update README.md · ae3a153b
      Daniel García authored
      Unverified
      ae3a153b
    • Stefan Melmuk's avatar
      enforce 2FA policy on removal of second factor and login (#3803) · 2c369937
      Stefan Melmuk authored
      * enforce 2fa policy on removal of second factor
      
      users should be revoked when their second factors are removed.
      
      we want to revoke users so they don't have to be invited again and
      organization admins and owners are aware that they no longer have
      access.
      
      we make an exception for non-confirmed users to speed up the invitation
      process as they would have to be restored before they can accept their
      invitation or be confirmed.
      
      if email is enabled, invited users have to add a second factor before
      they can accept the invitation to an organization with 2fa policy.
      and if it is not enabled that check is done when confirming the user.
      
      * use &str instead of String in log_event()
      
      * enforce the 2fa policy on login
      
      if a user doesn't have a second factor check if they are in an
      organization that has the 2fa policy enabled to revoke their access
      Unverified
      2c369937
    • THONY's avatar
      US or EU Data Region Selection (#3752) · d672ad3f
      THONY authored
      
      * add selection of data region for push
      
      * fix cargo check + rewrite config + add check url
      
      * fix clippy error
      
      * add comment in .env.template, adapt config.rs
      
      * Update .env.template
      
      Co-authored-by: default avatarWilliam Desportes <williamdes@wdes.fr>
      
      * Update .env.template
      
      Co-authored-by: default avatarWilliam Desportes <williamdes@wdes.fr>
      
      * Revert "Update .env.template"
      
      This reverts commit 5bed974ba7b9f481792d2228834585f053d47dc3.
      
      * Revert "Update .env.template"
      
      This reverts commit 0760eff95dfaf2a9cf97bb25f6cf7660bdf55173.
      
      * fix /connect/token to push identity
      
      * fix /connect/token to push identity
      
      * Fixed formatting when solving merge conflicts
      
      ---------
      
      Co-authored-by: default avatarWilliam Desportes <williamdes@wdes.fr>
      Co-authored-by: default avatarDaniel García <dani-garcia@users.noreply.github.com>
      Unverified
      d672ad3f
    • Matlink's avatar
      Fix #3413: push to users accessing the collections using groups (#3757) · a641b488
      Matlink authored
      * Fix #3413: push to users acessing the collections using groups
      
      * Notify groups only when enabled
      Unverified
      a641b488
    • Philipp Kolberg's avatar
      Allow customizing the featureStates (#4168) · 98b2178c
      Philipp Kolberg authored
      * Allow customizing the featureStates
      
      Use a comma separated list of features to enable using the FEATURE_FLAGS env variable
      
      * Move feature flag parsing to util
      
      * Fix formatting
      
      * Update supported feature flags
      
      * Rename feature_flags to experimental_client_feature_flags
      
      Additionally, use a caret (^) instead of an exclamation mark (!) to disable features
      
      * Fix formatting issue.
      
      * Add documentation to env template
      
      * Remove functionality to disable feature flags
      
      * Fix JSON key for feature states
      
      * Convert error to warning when feature flag is unrecognized
      
      * Simplify parsing of feature flags
      
      * Fix default value of feature flags in env template
      
      * Fix formatting
      Unverified
      98b2178c
    • Mathijs van Veluw's avatar
      Fix Single Org Policy check (#4207) · 76a3f0f5
      Mathijs van Veluw authored
      There was an error in the single org policy check to determine how many
      users there are in an org. The `or` check was at the wrong location in
      the DSL.
      
      This is now fixed.
      
      Fixes #4205
      Unverified
      76a3f0f5
    • Mathijs van Veluw's avatar
      Update Rust and Crates (#4211) · c5665e7b
      Mathijs van Veluw authored
      - Updated Rust to v1.75.0
      - Updated all the crates
      - Fixed warning generated by latest version of Rust
      Unverified
      c5665e7b
  5. Dec 24, 2023
  6. Dec 18, 2023
    • Chris's avatar
      Add additional build target which optimizes for size (#4096) · 3337594d
      Chris authored
      
      OpenWRT is a project which builds and distributes firmware for
      embedded devies like routers, access points, and so on. These
      devices are usually very limited in terms of storage. Therefore,
      optimizing binaries for size at the cost of execution speed is
      usually desired.
      
      This PR adds an additional build-target, namely "release-micro",
      which implements several parameters which optimize in favor of
      binary size.
      
      The following parameters were chosen:
      - opt-level "z": Optimize for size with disabled loop vectorization
      - strip "symbols": Strip debuginfo and symbols from binary
      - lto "fat": Enable link-time optimizations across all crates
      - codegen-units 1: Disable parallelization of code generation to
        allow for additional optimizations
      - panic "abort": Abort on Panic() instead of unwinding
      
      All these build parameters significantly reduce the binary size
      from >40MB to <15MB - the actual amount depends on the target
      architecture.
      
      We would like to upstream this new build target to keep our build
      environment simple. Other projects which deploy vaultwarden on
      size-constrained environments may benefit from this change too.
      
      Signed-off-by: default avatarChristian Lachner <gladiac@gmail.com>
      Unverified
      3337594d
    • Mathijs van Veluw's avatar
      Update crates (#4173) · 2daa8be1
      Mathijs van Veluw authored
      Update all crates instead of only the zerocopy from dependabot.
      Closes #4170
      Unverified
      2daa8be1
  7. Dec 13, 2023
    • Mathijs van Veluw's avatar
      Decrease JWT Refresh/Auth token (#4163) · eccb3ab9
      Mathijs van Veluw authored
      Large JWT's could cause issue because of header or body sizes of the
      HTTP request could get too large when you are a member of a lot of organizations.
      
      This PR removes these specific keys since they are not used either
      client side or server side.
      
      Because Bitwarden does add these in there JWT's i would suggest to keep
      the code we had but then commented out as a reference.
      
      Removing it and searching for this when needed would be a waist of time.
      
      Fixes #4156
      Unverified
      eccb3ab9
  8. Dec 09, 2023
    • Mathijs van Veluw's avatar
      Fix the version string (#4153) · 3246251f
      Mathijs van Veluw authored
      For some reason still not known, the `.git` directory was not copied
      into the container. I think buildkit (buildx) did this by default before, and
      stopped this with newer versions.
      
      This PR fixes this by also touching `build.rs` besides `src/main.rs`.
      
      This PR also updates Rust to v1.74.1 and some crates, including the
      latest version of Alpine 3.19.
      
      Fixes #4150
      Unverified
      3246251f
    • Mathijs van Veluw's avatar
      Several small fixes for open issues (#4143) · 8ab20022
      Mathijs van Veluw authored
      * Fix BWDC when re-run with cleared cache
      
      Using the BWDC with a cleared cache caused invited users to be converted
      to accepted users.
      
      The problem was a wrong check for the `restore` function.
      
      Fixes #4114
      
      * Remove useless variable
      
      During some refactoring this seems to be overlooked.
      This variable gets filled but isn't used at all afterwards.
      
      Fixes #4105
      
      * Check some `.git` paths to force a rebuild
      
      When a checked-out repo switches to a specific tag, and that tag does
      not have anything else changed in the files except the tag, it could
      happen that the build process doesn't see any changes, while it could be
      that the version string needs to be different.
      
      This commit ensures that if some specific paths are changed within the
      .git directory, cargo will be triggered to rebuild.
      
      Fixes #4087
      
      * Do not delete dir on file delete
      
      Previously during a `delete_file` check we also tried to delete the
      parent directory and ignored all errors, like not being empty for
      example.
      
      Since this function is called `delete_file` and does not mention
      anything in regards to a directory i have removed that code and it will
      now only delete the file and leave the rest as-is.
      
      If this somehow is still needed or wanted, which i do not think we want,
      then we should create a new function.
      
      Fixes #4081
      
      * Fix healthcheck when using an ENV file
      
      If someone is using a `.env` file or configured the `ENV_FILE` variable
      to use that as it's configuration, this was missed by the healthcheck.
      
      So, `DOMAIN` and `ROCKET_TLS` were not seen, and not used in these cases.
      
      This commit fixes this by checking for this file and if it exists, then
      it will load those variables first.
      
      Fixes #4112
      
      * Add missing route
      
      While there was a function and a derive, this endpoint wasn't part of
      the routes. Since Bitwarden does have this endpoint ill add the route
      instead of deleting it.
      
      Fixes #4076
      Fixes #4144
      
      * Update crates to update the openssl crate
      
      Because of a bug in the openssl-sys crate we pinned the version to an
      older version. This issue has been fixed and was released 2 days ago.
      
      This commit updates the openssl crates including others.
      This should also fix the issues with building Vaultwarden using newer
      versions of LibreSSL.
      
      Fixes #4051
      Unverified
      8ab20022
  9. Dec 04, 2023
    • Mathijs van Veluw's avatar
      Update Rust, Crates, Profile and Actions (#4126) · 34e00e14
      Mathijs van Veluw authored
      - Updated Rust to v1.74.0
      - Updated all crates (where possible)
      - Changed release profile to use
        * fat lto
        * 1 codegen-unit
        This should optimize a bit for speed and a lot for size ~15MB smaller
      - Updated Github actions to use caching for the bake process
      - Added a schedule to clean the cache every week to prevent stale Debian/Alpine base images
      - During the release action, the Alpine/static binaries are added as artifects.
        Later we could also automatically add them to the releases maybe.
      - Added CODEWONERS to prevent unchecked changes to github actions workflows
      Unverified
      34e00e14
    • Mathijs van Veluw's avatar
      Prevent generating an error during ws close (#4127) · 0fdda3bc
      Mathijs van Veluw authored
      When a WebSocket connection was closing it was sending a message after
      it was closed already. This generated an error in the logs.
      While this error didn't harm any of the functionallity of Vaultwarden it
      isn't nice to see them of course.
      
      This PR Fixes this by catching the close message and breaks the loop at
      that point. This prevents the `_` catch-all from replying the close
      message back to the client, which was causing the error message.
      
      Fixes #4090
      Unverified
      0fdda3bc
  10. Nov 15, 2023
  11. Nov 12, 2023
    • Mathijs van Veluw's avatar
      Add Protected Actions Check (#4067) · f863ffb8
      Mathijs van Veluw authored
      Since the feature `Login with device` some actions done via the
      web-vault need to be verified via an OTP instead of providing the MasterPassword.
      
      This only happens if a user used the `Login with device` on a device
      which uses either Biometrics login or PIN. These actions prevent the
      athorizing device to send the MasterPasswordHash. When this happens, the
      web-vault requests an OTP to be filled-in and this OTP is send to the
      users email address which is the same as the email address to login.
      
      The only way to bypass this is by logging in with the your password, in
      those cases a password is requested instead of an OTP.
      
      In case SMTP is not enabled, it will show an error message telling to
      user to login using there password.
      
      Fixes #4042
      Unverified
      f863ffb8
  12. Nov 08, 2023
  13. Nov 07, 2023
    • Mathijs van Veluw's avatar
      Fix missing alpine tag during buildx bake (#4043) · efc6eb00
      Mathijs van Veluw authored
      The bake recipt was missing the single `:alpine` tag for the alpine
      builds when we were releasing a `stable/latest` version of Vaultwarden.
      
      This PR fixes this by checking for those conditions and add the
      `:alpine` tag too.
      
      We will keep the `:latest-alpine` also, which i find even nicer then just
      `:alpine`
      
      Fixes #4035
      Unverified
      efc6eb00
  14. Nov 05, 2023
  15. Nov 04, 2023
  16. Oct 23, 2023
  17. Oct 22, 2023
    • Mathijs van Veluw's avatar
      Container building changes (#3958) · d722328f
      Mathijs van Veluw authored
      * WIP: Container building changes
      
      * Small updates
      
      - Updated to rust 1.73.0
      - Updated crates
      - Updated documentation
      - Added a bake.sh script to make baking easier
      
      * Update GitHub Actions Workflow
      
      - Updated workflow to use qemu and buildx bake
      
      In the future i would like to extract the alpine based binaries and add
      them as artifacts to the release.
      
      * Address review remarks and small updates
      
      - Addressed review remarks
      - Added `podman-bake.sh` script to build Vaultwarden with podman
      - Updated README
      - Updated crates
      - Added `VW_VERSION` support
      - Added annotations
      - Updated web-vault to v2023.9.1
      Unverified
      d722328f
    • Daniel García's avatar
      Unverified
      cb4b683d
  18. Oct 21, 2023
Loading