Skip to content
Snippets Groups Projects
  • Daniel Calviño Sánchez's avatar
    883a71ce
    Split the menu entry for external shares in two · 883a71ce
    Daniel Calviño Sánchez authored
    
    The external shares entry showed a "button" that, when pressed, replaced
    the button with the input to set the remote share address. The "button"
    was actually a label for the input, so when the label was focused it
    transferred the focus to the input and thus pressing enter or space did
    not show the input. Moreover, inputs inside links are not valid HTML,
    and once shown there was no way to hide the input again.
    
    Due to all this, and for consistency with the direct link input, the
    external share input was moved to a different menu item that is shown
    and hidden when the button, which nows is also a real button, is
    clicked.
    
    Signed-off-by: default avatarDaniel Calviño Sánchez <danxuliu@gmail.com>
    883a71ce
    History
    Split the menu entry for external shares in two
    Daniel Calviño Sánchez authored
    
    The external shares entry showed a "button" that, when pressed, replaced
    the button with the input to set the remote share address. The "button"
    was actually a label for the input, so when the label was focused it
    transferred the focus to the input and thus pressing enter or space did
    not show the input. Moreover, inputs inside links are not valid HTML,
    and once shown there was no way to hide the input again.
    
    Due to all this, and for consistency with the direct link input, the
    external share input was moved to a different menu item that is shown
    and hidden when the button, which nows is also a real button, is
    clicked.
    
    Signed-off-by: default avatarDaniel Calviño Sánchez <danxuliu@gmail.com>
public.scss 1.59 KiB