Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
Nextcloud
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Monitor
Service Desk
Analyze
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
TeDomum
Nextcloud
Commits
3bde7c2f
Commit
3bde7c2f
authored
10 years ago
by
Joas Schilling
Browse files
Options
Downloads
Patches
Plain Diff
When guessing the timezone, the offset might only be valid on a given timestamp
parent
e16d61e2
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
lib/private/datetimezone.php
+12
-4
12 additions, 4 deletions
lib/private/datetimezone.php
lib/public/idatetimezone.php
+2
-1
2 additions, 1 deletion
lib/public/idatetimezone.php
with
14 additions
and
5 deletions
lib/private/datetimezone.php
+
12
−
4
View file @
3bde7c2f
...
...
@@ -48,13 +48,14 @@ class DateTimeZone implements IDateTimeZone {
/**
* Get the timezone of the current user, based on his session information and config data
*
* @param bool|int $timestamp
* @return \DateTimeZone
*/
public
function
getTimeZone
()
{
public
function
getTimeZone
(
$timestamp
=
false
)
{
$timeZone
=
$this
->
config
->
getUserValue
(
$this
->
session
->
get
(
'user_id'
),
'core'
,
'timezone'
,
null
);
if
(
$timeZone
===
null
)
{
if
(
$this
->
session
->
exists
(
'timezone'
))
{
return
$this
->
guessTimeZoneFromOffset
(
$this
->
session
->
get
(
'timezone'
));
return
$this
->
guessTimeZoneFromOffset
(
$this
->
session
->
get
(
'timezone'
)
,
$timestamp
);
}
$timeZone
=
$this
->
getDefaultTimeZone
();
}
...
...
@@ -74,9 +75,10 @@ class DateTimeZone implements IDateTimeZone {
* we try to find it manually, before falling back to UTC.
*
* @param mixed $offset
* @param bool|int $timestamp
* @return \DateTimeZone
*/
protected
function
guessTimeZoneFromOffset
(
$offset
)
{
protected
function
guessTimeZoneFromOffset
(
$offset
,
$timestamp
)
{
try
{
// Note: the timeZone name is the inverse to the offset,
// so a positive offset means negative timeZone
...
...
@@ -93,7 +95,13 @@ class DateTimeZone implements IDateTimeZone {
// we try to guess one timezone that has the same offset
foreach
(
\DateTimeZone
::
listIdentifiers
()
as
$timeZone
)
{
$dtz
=
new
\DateTimeZone
(
$timeZone
);
$dtOffset
=
$dtz
->
getOffset
(
new
\DateTime
());
$dateTime
=
new
\DateTime
();
if
(
$timestamp
!==
false
)
{
$dateTime
->
setTimestamp
(
$timestamp
);
}
$dtOffset
=
$dtz
->
getOffset
(
$dateTime
);
if
(
$dtOffset
==
3600
*
$offset
)
{
return
$dtz
;
}
...
...
This diff is collapsed.
Click to expand it.
lib/public/idatetimezone.php
+
2
−
1
View file @
3bde7c2f
...
...
@@ -25,7 +25,8 @@ namespace OCP;
interface
IDateTimeZone
{
/**
* @param bool|int $timestamp
* @return \DateTimeZone
*/
public
function
getTimeZone
();
public
function
getTimeZone
(
$timestamp
=
false
);
}
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment