Merge pull request #17683 from nextcloud/enh/login-flow-v2-polish

Polish login flow v2

core/js/login/grant.js

-jQuery(document).ready(function() {
-	$('#submit').click(function (e) {
-		$('#submit + .submit-icon')
-			.removeClass('icon-confirm-white')
-			.addClass(OCA.Theming && OCA.Theming.inverted
-				? 'icon-loading-small'
-				: 'icon-loading-small-dark');
+document.querySelector('form').addEventListener('submit', function(e) {
+	const wrapper = document.getElementById('submit-wrapper')
+	if (wrapper === null) {
+		return
+	}
+	wrapper.getElementsByClassName('icon-confirm-white').forEach(function(el) {
+		el.classList.remove('icon-confirm-white')
+		el.classList.add(OCA.Theming && OCA.Theming.inverted ? 'icon-loading-small' : 'icon-loading-small-dark')
 	})
-})
\ No newline at end of file
+})

core/templates/loginflow/grant.php

@@ -45,8 +45,7 @@ $urlGenerator = $_['urlGenerator'];
 			<input type="hidden" name="stateToken" value="<?php p($_['stateToken']) ?>" />	
 			<input type="hidden" name="oauthState" value="<?php p($_['oauthState']) ?>" />	
 			<div id="submit-wrapper">
-				<input type="submit" id="submit" class="login primary" title="" value="<?php p($l->t('Grant access')); ?>" />
-				<div class="submit-icon icon-confirm-white"></div>
+				<input type="submit" class="login primary icon-confirm-white" title="" value="<?php p($l->t('Grant access')); ?>" />
 			</div>	
 		</form>
 	</p>

core/templates/loginflowv2/done.php

@@ -30,7 +30,8 @@ style('core', 'login/authpicker');
 <div class="picker-window">
 	<h2><?php p($l->t('Account connected')) ?></h2>
 	<p class="info">
-		<?php print_unescaped($l->t('Your client should now be connected! You can close this window.')) ?>
+		<?php p($l->t('Your client should now be connected!')) ?><br/>
+		<?php p($l->t('You can close this window.')) ?>
 	</p>
 
 	<br/>

core/templates/loginflowv2/grant.php

@@ -19,6 +19,7 @@
  *
  */
 
+script('core', 'login/grant');
 style('core', 'login/authpicker');
 
 /** @var array $_ */
@@ -42,8 +43,7 @@ $urlGenerator = $_['urlGenerator'];
 			<input type="hidden" name="requesttoken" value="<?php p($_['requesttoken']) ?>" />
 			<input type="hidden" name="stateToken" value="<?php p($_['stateToken']) ?>" />	
 			<div id="submit-wrapper">
-				<input type="submit" id="submit" class="login primary" title="" value="<?php p($l->t('Grant access')); ?>" />
-				<div class="submit-icon icon-confirm-white"></div>
+				<input type="submit" class="login primary icon-confirm-white" title="" value="<?php p($l->t('Grant access')); ?>" />
 			</div>	
 		</form>
 	</p>