Merge pull request #21818 from nextcloud/techdebt/noid/theming-bootstrap

Use IBootstrap for the app theming

apps/theming/lib/AppInfo/Application.php

@@ -2,6 +2,7 @@
 /**
  * @copyright Copyright (c) 2019 Robin Appelman <robin@icewind.nl>
  *
+ * @author Morris Jobke <hey@morrisjobke.de>
  * @author Robin Appelman <robin@icewind.nl>
  * @author Roeland Jago Douma <roeland@famdouma.nl>
  *
@@ -24,28 +25,26 @@
 
 namespace OCA\Theming\AppInfo;
 
-use OCA\Theming\Service\JSDataService;
-use OCP\AppFramework\IAppContainer;
-use OCP\IInitialStateService;
+use OCA\Theming\Capabilities;
+use OCA\Theming\Listener\BeforeTemplateRenderedListener;
+use OCP\AppFramework\App;
+use OCP\AppFramework\Bootstrap\IBootContext;
+use OCP\AppFramework\Bootstrap\IBootstrap;
+use OCP\AppFramework\Bootstrap\IRegistrationContext;
+use OCP\AppFramework\Http\Events\BeforeTemplateRenderedEvent;
 
-class Application extends \OCP\AppFramework\App {
+class Application extends App implements IBootstrap {
 	public const APP_ID = 'theming';
 
 	public function __construct() {
 		parent::__construct(self::APP_ID);
-
-		$container = $this->getContainer();
-		$this->registerInitialState($container);
 	}
 
-	private function registerInitialState(IAppContainer $container) {
-		/** @var IInitialStateService $initialState */
-		$initialState = $container->query(IInitialStateService::class);
+	public function register(IRegistrationContext $context): void {
+		$context->registerCapability(Capabilities::class);
+		$context->registerEventListener(BeforeTemplateRenderedEvent::class, BeforeTemplateRenderedListener::class);
+	}
 
-		$initialState->provideLazyInitialState(self::APP_ID, 'data', function () use ($container) {
-			/** @var JSDataService $data */
-			$data = $container->query(JSDataService::class);
-			return $data;
-		});
+	public function boot(IBootContext $context): void {
 	}
 }

apps/theming/appinfo/app.php → apps/theming/lib/Listener/BeforeTemplateRenderedListener.php

 <?php
+
+declare(strict_types=1);
+
 /**
- * @copyright Copyright (c) 2016 Bjoern Schiessle <bjoern@schiessle.org>
- * @copyright Copyright (c) 2016 Lukas Reschke <lukas@statuscode.ch>
+ * @copyright Copyright (c) 2020 Morris Jobke <hey@morrisjobke.de>
  *
- * @author Bjoern Schiessle <bjoern@schiessle.org>
- * @author Christoph Wurst <christoph@winzerhof-wurst.at>
- * @author Joas Schilling <coding@schilljs.com>
- * @author Julius Härtl <jus@bitgrid.net>
- * @author Lukas Reschke <lukas@statuscode.ch>
- * @author Robin Appelman <robin@icewind.nl>
+ * @author Morris Jobke <hey@morrisjobke.de>
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -27,23 +24,60 @@
  *
  */
 
+namespace OCA\Theming\Listener;
+
 use OCA\Theming\AppInfo\Application;
+use OCA\Theming\Service\JSDataService;
+use OCP\EventDispatcher\Event;
+use OCP\EventDispatcher\IEventListener;
+use OCP\IConfig;
+use OCP\IInitialStateService;
+use OCP\IServerContainer;
+use OCP\IURLGenerator;
+
+class BeforeTemplateRenderedListener implements IEventListener {
+
+	/** @var IInitialStateService */
+	private $initialStateService;
+	/** @var IURLGenerator */
+	private $urlGenerator;
+	/** @var IConfig */
+	private $config;
+	/** @var IServerContainer */
+	private $serverContainer;
+
+	public function __construct(
+		IInitialStateService $initialStateService,
+		IURLGenerator $urlGenerator,
+		IConfig $config,
+		IServerContainer $serverContainer
+	) {
+		$this->initialStateService = $initialStateService;
+		$this->urlGenerator = $urlGenerator;
+		$this->config = $config;
+		$this->serverContainer = $serverContainer;
+	}
+
+	public function handle(Event $event): void {
+		$serverContainer = $this->serverContainer;
+		$this->initialStateService->provideLazyInitialState(Application::APP_ID, 'data', function () use ($serverContainer) {
+			return $serverContainer->query(JSDataService::class);
+		});
+
+		$linkToCSS = $this->urlGenerator->linkToRoute(
+			'theming.Theming.getStylesheet',
+			[
+				'v' => $this->config->getAppValue('theming', 'cachebuster', '0'),
+			]
+		);
+		\OCP\Util::addHeader(
+			'link',
+			[
+				'rel' => 'stylesheet',
+				'href' => $linkToCSS,
+			]
+		);
 
-$app = \OC::$server->query(Application::class);
-$app->getContainer()->registerCapability(\OCA\Theming\Capabilities::class);
-
-$linkToCSS = \OC::$server->getURLGenerator()->linkToRoute(
-	'theming.Theming.getStylesheet',
-	[
-		'v' => \OC::$server->getConfig()->getAppValue('theming', 'cachebuster', '0'),
-	]
-);
-\OCP\Util::addHeader(
-	'link',
-	[
-		'rel' => 'stylesheet',
-		'href' => $linkToCSS,
-	]
-);
-
-\OCP\Util::addScript('theming', 'theming');
+		\OCP\Util::addScript('theming', 'theming');
+	}
+}