Skip to content
Snippets Groups Projects
Commit 65263817 authored by Daniel Calviño Sánchez's avatar Daniel Calviño Sánchez
Browse files

Wait for the comment to be added before changing to another file


If the server is too slow, changing to a different file immediately
after sending a new comment but without waiting for the comment to be
shown for the original file could cause the new comment to be shown for
the current file instead.

This is, indeed, a bug in the comments. However, it is not possible to
test it reliably in the acceptance tests, as it depends on how fast the
server adds the message and how fast the client changes to a different
file; sometimes the test would fail and sometimes it would not.

Therefore, now it is waited for the comment to be added before changing
to another file, as in this case it can be reliably tested that changing
to a different file does not cause the comments from the previous file
to be shown in the current file (this was a different bug already fixed
and due to which this test was added in the first place).

Signed-off-by: default avatarDaniel Calviño Sánchez <danxuliu@gmail.com>
parent d5725cb3
No related branches found
No related tags found
No related merge requests found
...@@ -24,6 +24,7 @@ Feature: app-comments ...@@ -24,6 +24,7 @@ Feature: app-comments
And I open the details view for "Folder" And I open the details view for "Folder"
And I open the "Comments" tab in the details view And I open the "Comments" tab in the details view
And I create a new comment with "Comment in Folder" as message And I create a new comment with "Comment in Folder" as message
And I see a comment with "Comment in Folder" as message
And I open the details view for "welcome.txt" And I open the details view for "welcome.txt"
# The "Comments" tab should already be opened # The "Comments" tab should already be opened
When I create a new comment with "Comment in welcome.txt" as message When I create a new comment with "Comment in welcome.txt" as message
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment