Refactor OC_Request into TrustedDomainHelper and IRequest
This changeset removes the static class `OC_Request` and moves the functions either into `IRequest` which is accessible via `\OC::$server::->getRequest()` or into a separated `TrustedDomainHelper` class for some helper methods which should not be publicly exposed. This changes only internal methods and nothing on the public API. Some public functions in `util.php` have been deprecated though in favour of the new non-static functions. Unfortunately some part of this code uses things like `__DIR__` and thus is not completely unit-testable. Where tests where possible they ahve been added though. Fixes https://github.com/owncloud/core/issues/13976 which was requested in https://github.com/owncloud/core/pull/13973#issuecomment-73492969
Showing
- lib/base.php 27 additions, 13 deletionslib/base.php
- lib/private/app.php 3 additions, 2 deletionslib/private/app.php
- lib/private/appframework/http/request.php 282 additions, 6 deletionslib/private/appframework/http/request.php
- lib/private/connector/sabre/file.php 18 additions, 12 deletionslib/private/connector/sabre/file.php
- lib/private/connector/sabre/request.php 1 addition, 1 deletionlib/private/connector/sabre/request.php
- lib/private/installer.php 0 additions, 1 deletionlib/private/installer.php
- lib/private/log/owncloud.php 3 additions, 2 deletionslib/private/log/owncloud.php
- lib/private/request.php 0 additions, 330 deletionslib/private/request.php
- lib/private/response.php 6 additions, 5 deletionslib/private/response.php
- lib/private/route/router.php 3 additions, 2 deletionslib/private/route/router.php
- lib/private/security/trusteddomainhelper.php 75 additions, 0 deletionslib/private/security/trusteddomainhelper.php
- lib/private/server.php 46 additions, 40 deletionslib/private/server.php
- lib/private/setup.php 4 additions, 2 deletionslib/private/setup.php
- lib/private/template.php 3 additions, 2 deletionslib/private/template.php
- lib/private/templatelayout.php 5 additions, 5 deletionslib/private/templatelayout.php
- lib/private/urlgenerator.php 2 additions, 1 deletionlib/private/urlgenerator.php
- lib/private/util.php 5 additions, 2 deletionslib/private/util.php
- lib/public/irequest.php 65 additions, 0 deletionslib/public/irequest.php
- lib/public/util.php 8 additions, 4 deletionslib/public/util.php
- ocs/v1.php 1 addition, 1 deletionocs/v1.php
Loading
Please register or sign in to comment