Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
Nextcloud
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Monitor
Service Desk
Analyze
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
TeDomum
Nextcloud
Commits
b1a6f66f
Unverified
Commit
b1a6f66f
authored
5 years ago
by
Arthur Schiwon
Browse files
Options
Downloads
Patches
Plain Diff
when we receive intentional empty whats new info, do not try to show it
Signed-off-by:
Arthur Schiwon
<
blizzz@arthur-schiwon.de
>
parent
869277b0
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
lib/private/Updater/ChangesCheck.php
+5
-1
5 additions, 1 deletion
lib/private/Updater/ChangesCheck.php
tests/lib/Updater/ChangesCheckTest.php
+4
-0
4 additions, 0 deletions
tests/lib/Updater/ChangesCheckTest.php
with
9 additions
and
1 deletion
lib/private/Updater/ChangesCheck.php
+
5
−
1
View file @
b1a6f66f
...
...
@@ -55,7 +55,11 @@ class ChangesCheck {
public
function
getChangesForVersion
(
string
$version
):
array
{
$version
=
$this
->
normalizeVersion
(
$version
);
$changesInfo
=
$this
->
mapper
->
getChanges
(
$version
);
return
json_decode
(
$changesInfo
->
getData
(),
true
);
$changesData
=
json_decode
(
$changesInfo
->
getData
(),
true
);
if
(
empty
(
$changesData
))
{
throw
new
DoesNotExistException
();
}
return
$changesData
;
}
/**
...
...
This diff is collapsed.
Click to expand it.
tests/lib/Updater/ChangesCheckTest.php
+
4
−
0
View file @
b1a6f66f
...
...
@@ -279,6 +279,10 @@ class ChangesCheckTest extends TestCase {
],
]
],
[
# 4 - empty
''
,
[]
],
];
}
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment