Fix #1782

Fix checkbox left margin glitch
Fix tests
fix unit tests

Signed-off-by: Morris Jobke <hey@morrisjobke.de>

apps/theming/lib/Controller/ThemingController.php

@@ -319,7 +319,7 @@ class ThemingController extends Controller {
 			$responseCss .= sprintf('input[type="checkbox"].checkbox:checked:enabled:not(.checkbox--white) + label:before {' .
 				'background-image:url(\'%s/core/img/actions/checkmark-white.svg\');' .
 				'background-color: %s; background-position: center center; background-size:contain;' .
-				'width:12px; height:12px; padding:0; margin:2px 6px 6px 2px; border-radius:1px;' .
+				'width:12px; height:12px; padding:0; margin:2px 6px 6px 9px; border-radius:1px;' .
 				"}\n",
 				\OC::$WEBROOT,
 				$elementColor

apps/theming/tests/Controller/ThemingControllerTest.php

@@ -428,7 +428,7 @@ class ThemingControllerTest extends TestCase {
 		$expectedData .= sprintf('input[type="checkbox"].checkbox:checked:enabled:not(.checkbox--white) + label:before {' .
 			'background-image:url(\'%s/core/img/actions/checkmark-white.svg\');' .
 			'background-color: %s; background-position: center center; background-size:contain;' .
-			'width:12px; height:12px; padding:0; margin:2px 6px 6px 2px; border-radius:1px;' .
+			'width:12px; height:12px; padding:0; margin:2px 6px 6px 9px; border-radius:1px;' .
 			"}\n",
 			\OC::$WEBROOT,
 			$color
@@ -517,7 +517,7 @@ class ThemingControllerTest extends TestCase {
 		$expectedData .= sprintf('input[type="checkbox"].checkbox:checked:enabled:not(.checkbox--white) + label:before {' .
 			'background-image:url(\'%s/core/img/actions/checkmark-white.svg\');' .
 			'background-color: #555555; background-position: center center; background-size:contain;' .
-			'width:12px; height:12px; padding:0; margin:2px 6px 6px 2px; border-radius:1px;' .
+			'width:12px; height:12px; padding:0; margin:2px 6px 6px 9px; border-radius:1px;' .
 			"}\n",
 			\OC::$WEBROOT
 		);
@@ -691,7 +691,7 @@ class ThemingControllerTest extends TestCase {
 		$expectedData .= sprintf('input[type="checkbox"].checkbox:checked:enabled:not(.checkbox--white) + label:before {' .
 			'background-image:url(\'%s/core/img/actions/checkmark-white.svg\');' .
 			'background-color: %s; background-position: center center; background-size:contain;' .
-			'width:12px; height:12px; padding:0; margin:2px 6px 6px 2px; border-radius:1px;' .
+			'width:12px; height:12px; padding:0; margin:2px 6px 6px 9px; border-radius:1px;' .
 			"}\n",
 			\OC::$WEBROOT,
 			$color
@@ -797,7 +797,7 @@ class ThemingControllerTest extends TestCase {
 		$expectedData .= sprintf('input[type="checkbox"].checkbox:checked:enabled:not(.checkbox--white) + label:before {' .
 			'background-image:url(\'%s/core/img/actions/checkmark-white.svg\');' .
 			'background-color: #555555; background-position: center center; background-size:contain;' .
-			'width:12px; height:12px; padding:0; margin:2px 6px 6px 2px; border-radius:1px;' .
+			'width:12px; height:12px; padding:0; margin:2px 6px 6px 9px; border-radius:1px;' .
 			"}\n",
 			\OC::$WEBROOT
 		);