Skip to content
Snippets Groups Projects
Unverified Commit c374bbf1 authored by Robin Appelman's avatar Robin Appelman Committed by Roeland Jago Douma
Browse files

allow authenticating using urlencoded passwords


this allows authenticating with passwords that contain non ascii-characters in contexts that otherwise do not allow it (http basic)

Signed-off-by: default avatarRobin Appelman <robin@icewind.nl>
parent 2dd04f76
No related branches found
No related tags found
No related merge requests found
...@@ -231,6 +231,20 @@ class Manager extends PublicEmitter implements IUserManager { ...@@ -231,6 +231,20 @@ class Manager extends PublicEmitter implements IUserManager {
} }
} }
// since http basic auth doesn't provide a standard way of handling non ascii password we allow password to be urlencoded
// we only do this decoding after using the plain password fails to maintain compatibility with any password that happens
// to contains urlencoded patterns by "accident".
$password = urldecode($password);
foreach ($this->backends as $backend) {
if ($backend->implementsActions(Backend::CHECK_PASSWORD)) {
$uid = $backend->checkPassword($loginName, $password);
if ($uid !== false) {
return $this->getUserObject($uid, $backend);
}
}
}
return false; return false;
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment