Skip to content
Snippets Groups Projects
Commit da4688d8 authored by Brice Maron's avatar Brice Maron
Browse files

Reorder code to avoid race condition in user creation

parent e9c7ecf2
No related branches found
No related tags found
No related merge requests found
...@@ -167,22 +167,7 @@ $(document).ready(function(){ ...@@ -167,22 +167,7 @@ $(document).ready(function(){
} }
var password=$('#newuserpassword').val(); var password=$('#newuserpassword').val();
var groups=$('#newusergroups').prev().children('div').data('settings').checked; var groups=$('#newusergroups').prev().children('div').data('settings').checked;
var tr var tr=$('#content table tbody tr').first().clone();
$.post(
OC.filePath('settings','ajax','createuser.php'),
{
username:username,
password:password,
groups:groups,
},
function(result){
if(result.status!='success'){
tr.remove();
OC.dialogs.alert(result.data.message, 'Error creating user');
}
}
);
tr=$('#content table tbody tr').first().clone();
tr.attr('data-uid',username); tr.attr('data-uid',username);
tr.find('td.name').text(username); tr.find('td.name').text(username);
var select=$('<select multiple="multiple" data-placehoder="Groups" title="Groups">'); var select=$('<select multiple="multiple" data-placehoder="Groups" title="Groups">');
...@@ -203,10 +188,24 @@ $(document).ready(function(){ ...@@ -203,10 +188,24 @@ $(document).ready(function(){
tr.find('td.remove').append($('<img alt="Delete" title="'+t('settings','Delete')+'" class="svg action" src="'+OC.imagePath('core','actions/delete')+'"/>')); tr.find('td.remove').append($('<img alt="Delete" title="'+t('settings','Delete')+'" class="svg action" src="'+OC.imagePath('core','actions/delete')+'"/>'));
} }
applyMultiplySelect(select); applyMultiplySelect(select);
$('#content table tbody').last().after(tr); $('#content table tbody').last().append(tr);
tr.find('select.quota option').attr('selected',null); tr.find('select.quota option').attr('selected',null);
tr.find('select.quota option').first().attr('selected','selected'); tr.find('select.quota option').first().attr('selected','selected');
tr.find('select.quota').data('previous','default'); tr.find('select.quota').data('previous','default');
$.post(
OC.filePath('settings','ajax','createuser.php'),
{
username:username,
password:password,
groups:groups,
},
function(result){
if(result.status!='success'){
tr.remove();
OC.dialogs.alert(result.data.message, 'Error creating user');
}
}
);
}); });
}); });
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment