Skip to content
Snippets Groups Projects
Commit de0dc30d authored by Christopher Schäpers's avatar Christopher Schäpers
Browse files

Update skipped tests messages

parent 12ee590b
No related branches found
No related tags found
No related merge requests found
...@@ -55,7 +55,7 @@ class Test_Image extends PHPUnit_Framework_TestCase { ...@@ -55,7 +55,7 @@ class Test_Image extends PHPUnit_Framework_TestCase {
} }
public function testMimeType() { public function testMimeType() {
$this->markTestSkipped("When loading an image from anything, but a file, the imagetype is always png"); $this->markTestSkipped("When loading from data or base64, imagetype is always image/png, see #4258.");
$img = new \OC_Image(OC::$SERVERROOT.'/tests/data/testimage.png'); $img = new \OC_Image(OC::$SERVERROOT.'/tests/data/testimage.png');
$this->assertEquals('image/png', $img->mimeType()); $this->assertEquals('image/png', $img->mimeType());
...@@ -105,7 +105,7 @@ class Test_Image extends PHPUnit_Framework_TestCase { ...@@ -105,7 +105,7 @@ class Test_Image extends PHPUnit_Framework_TestCase {
} }
public function testData() { public function testData() {
$this->markTestSkipped("Somehow data() doesn't equal file_get_contents's data"); $this->markTestSkipped("\OC_Image->data() converts to png before outputting data, see #4258.");
$img = new \OC_Image(OC::$SERVERROOT.'/tests/data/testimage.png'); $img = new \OC_Image(OC::$SERVERROOT.'/tests/data/testimage.png');
$expected = file_get_contents(OC::$SERVERROOT.'/tests/data/testimage.png'); $expected = file_get_contents(OC::$SERVERROOT.'/tests/data/testimage.png');
$this->assertEquals($expected, $img->data()); $this->assertEquals($expected, $img->data());
...@@ -120,7 +120,7 @@ class Test_Image extends PHPUnit_Framework_TestCase { ...@@ -120,7 +120,7 @@ class Test_Image extends PHPUnit_Framework_TestCase {
} }
public function testToString() { public function testToString() {
$this->markTestSkipped("Somehow data() doesn't equal file_get_contents's data"); $this->markTestSkipped("\OC_Image->data() converts to png before outputting data, see #4258.");
$img = new \OC_Image(OC::$SERVERROOT.'/tests/data/testimage.png'); $img = new \OC_Image(OC::$SERVERROOT.'/tests/data/testimage.png');
$expected = base64_encode(file_get_contents(OC::$SERVERROOT.'/tests/data/testimage.png')); $expected = base64_encode(file_get_contents(OC::$SERVERROOT.'/tests/data/testimage.png'));
$this->assertEquals($expected, (string)$img); $this->assertEquals($expected, (string)$img);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment