Skip to content
Snippets Groups Projects
  1. Oct 26, 2015
  2. Oct 25, 2015
    • Lukas Reschke's avatar
      Throw exception on `getPath` if file does not exist · 13e817e9
      Lukas Reschke authored
      Currently the `getPath` methods returned `NULL` in case when a file with the specified ID does not exist. This however mandates that developers are checking for the `NULL` case and if they do not the door for bugs with all kind of impact is widely opened.
      
      This is especially harmful if used in context with Views where the final result is limited based on the result of `getPath`, if `getPath` returns `NULL` PHP type juggles this to an empty string resulting in all possible kind of bugs.
      
      While one could argue that this is a misusage of the API the fact is that it is very often misused and an exception will trigger an immediate stop of execution as well as log this behaviour and show a pretty error page.
      
      I also adjusted some usages where I believe that we need to catch these errors, in most cases this is though simply an error that should hard-fail.
      13e817e9
  3. Jul 03, 2015
  4. Apr 10, 2015
  5. Apr 07, 2015
  6. Mar 26, 2015
  7. Feb 26, 2015
  8. Feb 23, 2015
  9. Jan 16, 2015
  10. Jun 06, 2014
  11. May 19, 2014
  12. May 13, 2014
  13. May 11, 2014
    • Lukas Reschke's avatar
      Fix Typo · cd3ed014
      Lukas Reschke authored
      I guess that should be `default` and not `defautl`, wondering how this ever worked.
      cd3ed014
  14. Dec 19, 2013
  15. Sep 30, 2013
  16. Feb 22, 2013
  17. Feb 14, 2013
  18. Feb 06, 2013
  19. Dec 16, 2012
  20. Oct 16, 2012
  21. Sep 23, 2012
  22. Sep 07, 2012
  23. Aug 29, 2012
  24. May 11, 2012
  25. Nov 29, 2011
  26. Nov 09, 2011
  27. Jul 29, 2011
  28. Jul 27, 2011
Loading