- Jul 15, 2016
-
-
Joas Schilling authored
-
- Jul 12, 2016
-
-
Robin Appelman authored
-
- Jul 08, 2016
-
-
Morris Jobke authored
* the setup check is still there
-
- May 26, 2016
-
-
Lukas Reschke authored
-
- May 24, 2016
-
-
Christoph Wurst authored
-
Christoph Wurst authored
-
- May 12, 2016
-
-
Lukas Reschke authored
The current logic for mod_rewrite relies on the fact that people have properly configured ownCloud, basically it reads from the `overwrite.cli.ur l` entry and then derives the `RewriteBase` from it. This usually works. However, since the ownCloud packages seem to install themselves at `/owncloud` (because subfolders are cool or so…) _a lot_ of people have just created a new Virtual Host for it or have simply symlinked the path etc. This means that `overwrite.cli.url` is wrong, which fails hard if it is used as RewriteBase since Apache does not know where it should serve files from. In the end the ownCloud instance will not be accessible anymore and users will be frustrated. Also some shared hosters like 1&1 (because using shared hosters is so awesome… ;-)) have somewhat dubious Apache configurations or use versions of mod_rewrite from the mediveal age. (because updating is money or so…) Anyhow. This makes this explicitly an opt-in configuration flag. If `htaccess.RewriteBase` is set then it will configure index.php-less URLs, if admins set that after installation and don't want to wait until the next ownCloud version they can run `occ maintenance:update:htaccess`. For ownCloud 9.0 we also have to add a repair step to make sure that instances that already have a RewriteBase configured continue to use it by copying it into the config file. That way all existing URLs stay valid. That one is not in this PR since this is unneccessary in master. Effectively this reduces another risk of breakage when updating from ownCloud 8 to ownCloud 9. Fixes https://github.com/owncloud/core/issues/24525, https://github.com/owncloud/core/issues/24426 and probably some more.
-
- May 11, 2016
-
-
Christoph Wurst authored
-
Christoph Wurst authored
add 'last_activity' column to session tokens and delete old ones via a background job
-
- May 02, 2016
-
-
Thomas Müller authored
-
- Apr 29, 2016
-
-
Roeland Jago Douma authored
* \OC\OCSClient * \OC\Preview * \OC\PreviewManager * \OC\Repair * \OC\RepairException * \OC\Search * \OC\ServerContainer * \OC\ServerNotAvailableException * \OC\ServiceUnavailableException * \OC\Setup * \OC\Streamer * \OC\SubAdmin * \OC\SystemConfig * \OC\TagManager * \OC\Tags * \OC\TempManager * \OC\TemplateLayout * \OC\URLGenerator * \OC\Updater
-
- Apr 26, 2016
-
-
Lukas Reschke authored
ownCloud may be configured to live at the root folder without a trailing slash being specified. In this case manually set the rewrite base to `/`
-
- Apr 20, 2016
-
-
Lukas Reschke authored
The new updater as shipped with ownCloud 9.0.x invokes `occ` via `shell_exec`. This means that the `\OC::$CLI` code is used when updating. This removes the manual `.htaccess` modifications, effectively leading to the fact that URLs without index.php in it stop working. This also affects share URLs which could be considered a rather serious regression. - User installs 9.0.0 via web - User shares /s/1234 - User updates to 9.0.1 via ownCloud updater - Link to /s/1234 is broken, /index.php/s/1234 works
-
- Mar 17, 2016
-
-
Lukas Reschke authored
The ownCloud update routine also runs the "updateHtaccess" code in case only an application gets updated. This leads to having entries multiple time in the .htaccess file leading to unpredictable behaviour. With 9.0 we added the "#### DO NOT CHANGE ANYTHING ABOVE THIS LINE ####" entry to the .htaccess file, this change uses it to ensure that only to the .htaccess gets written if the file has not been modified already. Since the .htaccess modifications are optional this is not a big deal. Without this change updates of applications can break the rewrite rules (ending in endless redirects) as well as breaking the code integrity checker.
-
- Mar 10, 2016
-
- Mar 09, 2016
-
-
Lukas Reschke authored
In case Apache is configured with an `Alias` such as with the ownCloud packages the rewrite rules will fail when no valid RewriteBase is configured.
-
- Jan 26, 2016
-
-
Morris Jobke authored
-
- Jan 22, 2016
-
-
Lukas Reschke authored
After the initial installation ownCloud will write some content into the .htaccess file such as the 404 or 403 directives. This adds a magic marker into the .htaccess file and only the content above this marker will be compared in the integrity checker.
-
- Jan 12, 2016
-
-
Thomas Müller authored
-
- Jan 11, 2016
-
-
Roeland Jago Douma authored
-
- Dec 18, 2015
-
-
Morris Jobke authored
-
- Dec 08, 2015
-
-
Lukas Reschke authored
-
Lukas Reschke authored
This is the same what we also do in updater.php and thus this aligns the code. Makes the code paths more consistent.
-
Lukas Reschke authored
This can now be achieved using the new code signing.
-
Lukas Reschke authored
When `DirectorySlash off` is set then Apache will not lookup folders anymore. This is required for example when we use the rewrite directives on an existing path such as `/core/search`. By default Apache would load `/core/search/` instead `/core/search` so the redirect would fail here. This leads however to the problem that URLs such as `localhost/owncloud` would not load anymore while `localhost/owncloud/` would. This has caused problems such as https://github.com/owncloud/core/pull/21015 With this change we add the `DirectorySlash off` directive only when the `.htaccess` is writable to the dynamic part of it. This would also make `localhost/owncloud` work again as it would trigger the 404 directive which triggers the redirect in base.php.
-
- Dec 02, 2015
-
-
Morris Jobke authored
-
- Dec 01, 2015
-
-
Lukas Reschke authored
-
Lukas Reschke authored
mod_rewrite as used by the front controller may require a `RewriteBase` in case the installation is done using an alias. Since we cannot enforce a writable `.htaccess` file this will move the `front_controller_active` environment variable into the main .htaccess file. If administrators decide to have this one not writable they can still enable this feature by setting the `front_controller_active` environment variable within the Apache config.
-
Lukas Reschke authored
This changeset allows ownCloud to run with pretty URLs, they will be used if mod_rewrite and mod_env are available. This means basically that the `index.php` in the URL is not shown to the user anymore. Also the not deprecated functions to generate URLs have been modified to support this behaviour, old functions such as `filePath` will still behave as before for compatibility reasons. Examples: http://localhost/owncloud/index.php/s/AIDyKbxiRZWAAjP => http://localhost/owncloud/s/AIDyKbxiRZWAAjP http://localhost/owncloud/index.php/apps/files/ => http://localhost/owncloud/apps/files/ Due to the way our CSS and JS is structured the .htaccess uses some hacks for the final result but could be worse... And I was just annoyed by all that users crying for the removal of `index.php` ;-)
-
- Jul 30, 2015
-
-
Lukas Reschke authored
-
- Jul 29, 2015
-
-
Thomas Müller authored
- less static calls - use params on sql queries - handle sql exception on database and user creation gracefully
-
Thomas Müller authored
-
Thomas Müller authored
-
- Jun 25, 2015
-
-
Morris Jobke authored
-
- Jun 23, 2015
-
-
Joas Schilling authored
-
- Mar 28, 2015
-
-
Lukas Reschke authored
Also used the opportunity to refactor it into an AppFramework controller so that we can unit test it. Fixes https://github.com/owncloud/core/issues/14956
-
- Mar 26, 2015
-
-
Jenkins for ownCloud authored
-
- Mar 16, 2015
-
-
Vincent Petry authored
-
- Mar 12, 2015
-
-
Thomas Müller authored
drop any fallback code related to curl - refs https://github.com/owncloud/core/pull/14838#issuecomment-78586447
-
- Mar 11, 2015
-
-
Thomas Müller authored
-