Skip to content
Snippets Groups Projects
  1. Feb 22, 2017
  2. Feb 13, 2017
  3. Feb 01, 2017
  4. Jan 23, 2017
  5. Jan 15, 2017
  6. Jan 10, 2017
  7. Jan 09, 2017
  8. Jan 06, 2017
  9. Jan 03, 2017
  10. Nov 18, 2016
  11. Oct 28, 2016
  12. Oct 25, 2016
  13. Aug 30, 2016
  14. Aug 18, 2016
  15. Jul 21, 2016
  16. Jul 15, 2016
  17. May 26, 2016
  18. May 23, 2016
  19. Apr 29, 2016
    • Roeland Jago Douma's avatar
      Move more from \OC to PSR-4 · f52c5b31
      Roeland Jago Douma authored
      * \OC\OCSClient
      * \OC\Preview
      * \OC\PreviewManager
      * \OC\Repair
      * \OC\RepairException
      * \OC\Search
      * \OC\ServerContainer
      * \OC\ServerNotAvailableException
      * \OC\ServiceUnavailableException
      * \OC\Setup
      * \OC\Streamer
      * \OC\SubAdmin
      * \OC\SystemConfig
      * \OC\TagManager
      * \OC\Tags
      * \OC\TempManager
      * \OC\TemplateLayout
      * \OC\URLGenerator
      * \OC\Updater
      Unverified
      f52c5b31
  20. Apr 14, 2016
  21. Apr 01, 2016
  22. Feb 12, 2016
  23. Feb 09, 2016
    • Lukas Reschke's avatar
      Move update notification code into app · abc675d8
      Lukas Reschke authored
      Moves the update notification code in a single app. This is required since we want to use SSO for the new updater and for this have some code running in ownCloud as well (and we don't want that in core neccessarily). This app can provide that in the future, right now it's only the update notification itself. Will continue working on the SSO right away but wanted to keep the PR small.
      
      Furthermore also makes some more code unit-testable...
      abc675d8
  24. Jan 27, 2016
  25. Jan 26, 2016
  26. Jan 13, 2016
  27. Jan 12, 2016
  28. Jan 07, 2016
  29. Dec 18, 2015
  30. Dec 17, 2015
  31. Dec 01, 2015
    • Lukas Reschke's avatar
      Add code integrity check · 49710155
      Lukas Reschke authored
      This PR implements the base foundation of the code signing and integrity check. In this PR implemented is the signing and verification logic, as well as commands to sign single apps or the core repository.
      
      Furthermore, there is a basic implementation to display problems with the code integrity on the update screen.
      
      Code signing basically happens the following way:
      
      - There is a ownCloud Root Certificate authority stored `resources/codesigning/root.crt` (in this PR I also ship the private key which we obviously need to change before a release :wink:). This certificate is not intended to be used for signing directly and only is used to sign new certificates.
      - Using the `integrity:sign-core` and `integrity:sign-app` commands developers can sign either the core release or a single app. The core release needs to be signed with a certificate that has a CN of `core`,  apps need to be signed with a certificate that either has a CN of `core` (shipped apps!)  or the AppID.
      - The command generates a signature.json file of the following format:
      ```json
      {
          "hashes": {
              "/filename.php": "2401fed2eea6f2c1027c482a633e8e25cd46701f811e2d2c10dc213fd95fa60e350bccbbebdccc73a042b1a2799f673fbabadc783284cc288e4f1a1eacb74e3d",
              "/lib/base.php": "55548cc16b457cd74241990cc9d3b72b6335f2e5f45eee95171da024087d114fcbc2effc3d5818a6d5d55f2ae960ab39fd0414d0c542b72a3b9e08eb21206dd9"
          },
          "certificate": "-----BEGIN CERTIFICATE-----MIIBvTCCASagAwIBAgIUPvawyqJwCwYazcv7iz16TWxfeUMwDQYJKoZIhvcNAQEF\nBQAwIzEhMB8GA1UECgwYb3duQ2xvdWQgQ29kZSBTaWduaW5nIENBMB4XDTE1MTAx\nNDEzMTcxMFoXDTE2MTAxNDEzMTcxMFowEzERMA8GA1UEAwwIY29udGFjdHMwgZ8w\nDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBANoQesGdCW0L2L+a2xITYipixkScrIpB\nkX5Snu3fs45MscDb61xByjBSlFgR4QI6McoCipPw4SUr28EaExVvgPSvqUjYLGps\nfiv0Cvgquzbx/X3mUcdk9LcFo1uWGtrTfkuXSKX41PnJGTr6RQWGIBd1V52q1qbC\nJKkfzyeMeuQfAgMBAAEwDQYJKoZIhvcNAQEFBQADgYEAvF/KIhRMQ3tYTmgHWsiM\nwDMgIDb7iaHF0fS+/Nvo4PzoTO/trev6tMyjLbJ7hgdCpz/1sNzE11Cibf6V6dsz\njCE9invP368Xv0bTRObRqeSNsGogGl5ceAvR0c9BG+NRIKHcly3At3gLkS2791bC\niG+UxI/MNcWV0uJg9S63LF8=\n-----END CERTIFICATE-----",
          "signature": "U29tZVNpZ25lZERhdGFFeGFtcGxl"
      }
      ```
      `hashes` is an array of all files in the folder with their corresponding SHA512 hashes (this is actually quite cheap to calculate), the `certificate` is the  certificate used for signing. It has to be issued by the ownCloud Root Authority and it's CN needs to be permitted to perform the required action. The `signature` is then a signature of the `hashes` which can be verified using the `certificate`.
      
      Steps to do in other PRs, this is already a quite huge one:
      - Add nag screen in case the code check fails to ensure that administrators are aware of this.
      - Add code verification also to OCC upgrade and unify display code more.
      - Add enforced code verification to apps shipped from the appstore with a level of "official"
      - Add enfocrced code verification to apps shipped from the appstore that were already signed in a previous release
      - Add some developer documentation on how devs can request their own certificate
      - Check when installing ownCloud
      - Add support for CRLs to allow revoking certificates
      
      **Note:** The upgrade checks are only run when the instance has a defined release channel of `stable` (defined in `version.php`). If you want to test this, you need to change the channel thus and then generate the core signature:
      
      ```
      ➜  master git:(add-integrity-checker) ✗ ./occ integrity:sign-core --privateKey=resources/codesigning/core.key --certificate=resources/codesigning/core.crt
      Successfully signed "core"
      ```
      
      Then increase the version and you should see something like the following:
      
      ![2015-11-04_12-02-57](https://cloud.githubusercontent.com/assets/878997/10936336/6adb1d14-82ec-11e5-8f06-9a74801c9abf.png)
      
      As you can see a failed code check will not prevent the further update. It will instead just be a notice to the admin. In a next step we will add some nag screen.
      
      For packaging stable releases this requires the following additional steps as a last action before zipping:
      1. Run `./occ integrity:sign-core` once
      2. Run `./occ integrity:sign-app` _for each_ app. However, this can be simply automated using a simple foreach on the apps folder.
      49710155
Loading