Skip to content
Snippets Groups Projects
  1. Jan 09, 2019
  2. Jan 08, 2019
  3. Jan 07, 2019
  4. Jan 03, 2019
  5. Jan 02, 2019
  6. Dec 21, 2018
  7. Dec 20, 2018
  8. Dec 17, 2018
  9. Dec 07, 2018
  10. Dec 06, 2018
  11. Dec 05, 2018
  12. Dec 04, 2018
  13. Nov 30, 2018
  14. Nov 29, 2018
  15. Nov 28, 2018
  16. Nov 24, 2018
    • Daniel Calviño Sánchez's avatar
      Wait for the comment to be added before changing to another file · 65263817
      Daniel Calviño Sánchez authored
      
      If the server is too slow, changing to a different file immediately
      after sending a new comment but without waiting for the comment to be
      shown for the original file could cause the new comment to be shown for
      the current file instead.
      
      This is, indeed, a bug in the comments. However, it is not possible to
      test it reliably in the acceptance tests, as it depends on how fast the
      server adds the message and how fast the client changes to a different
      file; sometimes the test would fail and sometimes it would not.
      
      Therefore, now it is waited for the comment to be added before changing
      to another file, as in this case it can be reliably tested that changing
      to a different file does not cause the comments from the previous file
      to be shown in the current file (this was a different bug already fixed
      and due to which this test was added in the first place).
      
      Signed-off-by: default avatarDaniel Calviño Sánchez <danxuliu@gmail.com>
      65263817
    • Daniel Calviño Sánchez's avatar
      Wait for the empty content element to be shown · d5725cb3
      Daniel Calviño Sánchez authored
      
      When the "Comments" tab is open the empty content element is always in
      the DOM, although it is only shown once the message collection was
      fetched and there were no messages. Due to this it is necessary to
      explicitly wait for it to be shown instead of relying on the implicit
      wait made to find the element; otherwise it would be found immediately
      and if the collection was not fetched yet it would not be visible,
      causing the test to fail.
      
      Signed-off-by: default avatarDaniel Calviño Sánchez <danxuliu@gmail.com>
      d5725cb3
  17. Nov 23, 2018
  18. Nov 22, 2018
Loading