Skip to content
Snippets Groups Projects
  1. Jan 07, 2016
  2. Dec 18, 2015
  3. Dec 17, 2015
  4. Dec 01, 2015
    • Lukas Reschke's avatar
      Add code integrity check · 49710155
      Lukas Reschke authored
      This PR implements the base foundation of the code signing and integrity check. In this PR implemented is the signing and verification logic, as well as commands to sign single apps or the core repository.
      
      Furthermore, there is a basic implementation to display problems with the code integrity on the update screen.
      
      Code signing basically happens the following way:
      
      - There is a ownCloud Root Certificate authority stored `resources/codesigning/root.crt` (in this PR I also ship the private key which we obviously need to change before a release :wink:). This certificate is not intended to be used for signing directly and only is used to sign new certificates.
      - Using the `integrity:sign-core` and `integrity:sign-app` commands developers can sign either the core release or a single app. The core release needs to be signed with a certificate that has a CN of `core`,  apps need to be signed with a certificate that either has a CN of `core` (shipped apps!)  or the AppID.
      - The command generates a signature.json file of the following format:
      ```json
      {
          "hashes": {
              "/filename.php": "2401fed2eea6f2c1027c482a633e8e25cd46701f811e2d2c10dc213fd95fa60e350bccbbebdccc73a042b1a2799f673fbabadc783284cc288e4f1a1eacb74e3d",
              "/lib/base.php": "55548cc16b457cd74241990cc9d3b72b6335f2e5f45eee95171da024087d114fcbc2effc3d5818a6d5d55f2ae960ab39fd0414d0c542b72a3b9e08eb21206dd9"
          },
          "certificate": "-----BEGIN CERTIFICATE-----MIIBvTCCASagAwIBAgIUPvawyqJwCwYazcv7iz16TWxfeUMwDQYJKoZIhvcNAQEF\nBQAwIzEhMB8GA1UECgwYb3duQ2xvdWQgQ29kZSBTaWduaW5nIENBMB4XDTE1MTAx\nNDEzMTcxMFoXDTE2MTAxNDEzMTcxMFowEzERMA8GA1UEAwwIY29udGFjdHMwgZ8w\nDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBANoQesGdCW0L2L+a2xITYipixkScrIpB\nkX5Snu3fs45MscDb61xByjBSlFgR4QI6McoCipPw4SUr28EaExVvgPSvqUjYLGps\nfiv0Cvgquzbx/X3mUcdk9LcFo1uWGtrTfkuXSKX41PnJGTr6RQWGIBd1V52q1qbC\nJKkfzyeMeuQfAgMBAAEwDQYJKoZIhvcNAQEFBQADgYEAvF/KIhRMQ3tYTmgHWsiM\nwDMgIDb7iaHF0fS+/Nvo4PzoTO/trev6tMyjLbJ7hgdCpz/1sNzE11Cibf6V6dsz\njCE9invP368Xv0bTRObRqeSNsGogGl5ceAvR0c9BG+NRIKHcly3At3gLkS2791bC\niG+UxI/MNcWV0uJg9S63LF8=\n-----END CERTIFICATE-----",
          "signature": "U29tZVNpZ25lZERhdGFFeGFtcGxl"
      }
      ```
      `hashes` is an array of all files in the folder with their corresponding SHA512 hashes (this is actually quite cheap to calculate), the `certificate` is the  certificate used for signing. It has to be issued by the ownCloud Root Authority and it's CN needs to be permitted to perform the required action. The `signature` is then a signature of the `hashes` which can be verified using the `certificate`.
      
      Steps to do in other PRs, this is already a quite huge one:
      - Add nag screen in case the code check fails to ensure that administrators are aware of this.
      - Add code verification also to OCC upgrade and unify display code more.
      - Add enforced code verification to apps shipped from the appstore with a level of "official"
      - Add enfocrced code verification to apps shipped from the appstore that were already signed in a previous release
      - Add some developer documentation on how devs can request their own certificate
      - Check when installing ownCloud
      - Add support for CRLs to allow revoking certificates
      
      **Note:** The upgrade checks are only run when the instance has a defined release channel of `stable` (defined in `version.php`). If you want to test this, you need to change the channel thus and then generate the core signature:
      
      ```
      ➜  master git:(add-integrity-checker) ✗ ./occ integrity:sign-core --privateKey=resources/codesigning/core.key --certificate=resources/codesigning/core.crt
      Successfully signed "core"
      ```
      
      Then increase the version and you should see something like the following:
      
      ![2015-11-04_12-02-57](https://cloud.githubusercontent.com/assets/878997/10936336/6adb1d14-82ec-11e5-8f06-9a74801c9abf.png)
      
      As you can see a failed code check will not prevent the further update. It will instead just be a notice to the admin. In a next step we will add some nag screen.
      
      For packaging stable releases this requires the following additional steps as a last action before zipping:
      1. Run `./occ integrity:sign-core` once
      2. Run `./occ integrity:sign-app` _for each_ app. However, this can be simply automated using a simple foreach on the apps folder.
      49710155
  5. Nov 28, 2015
    • Lukas Reschke's avatar
      Don't trust update server · f3e91068
      Lukas Reschke authored
      In case the update server may deliver malicious content this would allow an adversary to inject arbitrary HTML into the response. So very bad stuff.
      
      While signing the response would be better and something we can also do in the future (considering the code signing work), this is already a good first start.
      f3e91068
  6. Oct 09, 2015
  7. Sep 28, 2015
  8. Sep 23, 2015
  9. Jun 25, 2015
  10. Jun 11, 2015
  11. May 03, 2015
  12. Apr 03, 2015
  13. Mar 26, 2015
  14. Mar 17, 2015
  15. Mar 04, 2015
  16. Feb 26, 2015
  17. Feb 24, 2015
  18. Feb 23, 2015
  19. Feb 16, 2015
  20. Feb 02, 2015
  21. Jan 05, 2015
    • Adam Williamson's avatar
      allow css/js asset directory to be relocated (#13053) · bb79aac7
      Adam Williamson authored
      This allows the directory where CSS/JS asset collections are
      written to be changed, in case SERVERROOT is not writeable. Note
      it does *not* allow the expected URL to be changed: whatever
      directory is used, the server must be configured to serve it
      at WEBROOT/assets. It may be possible to add another config
      parameter to allow the admin to specify a custom asset URL,
      but I thought I'd keep the first implementation simple.
      bb79aac7
    • Robin McCorkell's avatar
      Fix JS asset generation · 2c44bc17
      Robin McCorkell authored
      At some point SeparatorFilter should be included upstream
      (kriswallsmith/assetic), then lib/private/assetic/separatorfilter.php can be
      removed and the `use` in lib/private/templatelayout.php rewritten.
      
      SeparatorFilter inserts a separator between assets, preventing issues when
      files are incorrectly terminated. For JS this is a semicolon.
      2c44bc17
  22. Dec 09, 2014
  23. Dec 06, 2014
  24. Nov 12, 2014
  25. Oct 23, 2014
  26. Oct 20, 2014
  27. Oct 17, 2014
    • Thomas Müller's avatar
      adding cssmin and jssmin(minify) · 93b0f1a3
      Thomas Müller authored
      adding argument deleteSelf to rmdirr() - if false the directory itself will not be deleted only it's content
      
      adding repair step to clean the asset cache after upgrade + coding style adjustments
      93b0f1a3
  28. Oct 16, 2014
  29. Oct 15, 2014
  30. Oct 06, 2014
  31. Sep 17, 2014
  32. Sep 11, 2014
  33. Aug 29, 2014
Loading